From: Jeff Law <jeffreyalaw@gmail.com>
To: Michael Collison <collison@rivosinc.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] vect: Verify that GET_MODE_NUNITS is greater than one.
Date: Fri, 21 Apr 2023 18:23:46 -0600 [thread overview]
Message-ID: <5ff6dba5-7928-4f3d-d9d4-870b083bdff4@gmail.com> (raw)
In-Reply-To: <20230314215256.4153026-1-collison@rivosinc.com>
On 3/14/23 15:52, Michael Collison wrote:
> While working on autovectorizing for the RISCV port I encountered an issue
> where can_duplicate_and_interleave_p assumes that GET_MODE_NUNITS is a
> evenly divisible by two. The RISC-V target has vector modes (e.g. VNx1DImode),
> where GET_MODE_NUNITS is equal to one.
>
> Tested on RISCV and x86_64-linux-gnu. Okay?
>
> 2023-03-09 Michael Collison <collison@rivosinc.com>
>
> * tree-vect-slp.cc (can_duplicate_and_interleave_p):
> Check that GET_MODE_NUNITS is greater than one.
Is this still relevant? I know other changes were made to deal with
the case where GET_MODE_NUNITS returns 1, but I don't know if they made
this obsolete.
Any chance we could get a testcase for this? I realize it might depend
on unmerged RVV bits.
jeff
prev parent reply other threads:[~2023-04-22 0:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 21:52 Michael Collison
2023-03-19 16:58 ` Jeff Law
2023-03-31 9:58 ` Richard Sandiford
2023-04-22 0:23 ` Jeff Law [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ff6dba5-7928-4f3d-d9d4-870b083bdff4@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=collison@rivosinc.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).