From: Richard Sandiford <richard.sandiford@arm.com>
To: Jojo R via Gcc-patches <gcc-patches@gcc.gnu.org>
Cc: rjiejie@linux.alibaba.com
Subject: Re: [PATCH] genrecog.cc (print_nonbool_test): Fix type error of SUBREG_BYTE
Date: Tue, 20 Sep 2022 09:33:27 +0100 [thread overview]
Message-ID: <mpto7va30o8.fsf@arm.com> (raw)
In-Reply-To: <20220919060141.5014-1-rjiejie@linux.alibaba.com> (Jojo R. via Gcc-patches's message of "Mon, 19 Sep 2022 14:01:41 +0800")
Jojo R via Gcc-patches <gcc-patches@gcc.gnu.org> writes:
> * gcc/genrecog.cc (print_nonbool_test): Fix type error of
> SUBREG_BYTE
We can't do this here. The code has done nothing to prove that the
subreg offset is a compile-time constant.
Thanks,
Richard
> ---
> gcc/genrecog.cc | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/gcc/genrecog.cc b/gcc/genrecog.cc
> index 77f8fb97853..319e437e334 100644
> --- a/gcc/genrecog.cc
> +++ b/gcc/genrecog.cc
> @@ -4619,6 +4619,7 @@ print_nonbool_test (output_state *os, const rtx_test &test)
> printf ("SUBREG_BYTE (");
> print_test_rtx (os, test);
> printf (")");
> + printf (".to_constant ()");
> break;
>
> case rtx_test::WIDE_INT_FIELD:
prev parent reply other threads:[~2022-09-20 8:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-19 6:01 Jojo R
2022-09-20 8:33 ` Richard Sandiford [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mpto7va30o8.fsf@arm.com \
--to=richard.sandiford@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=rjiejie@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).