public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH][gensupport] drop suppport for define_cond_exec from compact syntac
@ 2023-06-20 17:17 Tamar Christina
  2023-06-20 20:22 ` Richard Sandiford
  0 siblings, 1 reply; 2+ messages in thread
From: Tamar Christina @ 2023-06-20 17:17 UTC (permalink / raw)
  To: gcc-patches; +Cc: nd, richard.sandiford

[-- Attachment #1: Type: text/plain, Size: 1026 bytes --]

Hi All,

define_cond_exec does not support the special @@ syntax
and so can't support {@.  As such just remove support
for it.

Bootstrapped and no issues.

Ok for master?

Thanks,
Tamar

gcc/ChangeLog:

	PR bootstrap/110324
	* gensupport.cc (convert_syntax): Explicitly check for RTX code.

--- inline copy of patch -- 
diff --git a/gcc/gensupport.cc b/gcc/gensupport.cc
index 980b49cd4814c9f92cae5876a1bae936338df071..e39e6dacce25009df1ef83a0ab9ed309704ca74b 100644
--- a/gcc/gensupport.cc
+++ b/gcc/gensupport.cc
@@ -878,7 +878,8 @@ convert_syntax (rtx x, file_location loc)
   const char *templ;
   vec_conlist tconvec, convec, attrvec;
 
-  templ_index = GET_CODE (x) == DEFINE_INSN ? 3 : 2;
+  templ_index = 3;
+  gcc_assert (GET_CODE (x) == DEFINE_INSN);
 
   templ = XTMPL (x, templ_index);
 
@@ -1053,7 +1054,6 @@ process_rtx (rtx desc, file_location loc)
       break;
 
     case DEFINE_COND_EXEC:
-      convert_syntax (desc, loc);
       queue_pattern (desc, &define_cond_exec_tail, loc);
       break;
 




-- 

[-- Attachment #2: rb17410.patch --]
[-- Type: text/plain, Size: 700 bytes --]

diff --git a/gcc/gensupport.cc b/gcc/gensupport.cc
index 980b49cd4814c9f92cae5876a1bae936338df071..e39e6dacce25009df1ef83a0ab9ed309704ca74b 100644
--- a/gcc/gensupport.cc
+++ b/gcc/gensupport.cc
@@ -878,7 +878,8 @@ convert_syntax (rtx x, file_location loc)
   const char *templ;
   vec_conlist tconvec, convec, attrvec;
 
-  templ_index = GET_CODE (x) == DEFINE_INSN ? 3 : 2;
+  templ_index = 3;
+  gcc_assert (GET_CODE (x) == DEFINE_INSN);
 
   templ = XTMPL (x, templ_index);
 
@@ -1053,7 +1054,6 @@ process_rtx (rtx desc, file_location loc)
       break;
 
     case DEFINE_COND_EXEC:
-      convert_syntax (desc, loc);
       queue_pattern (desc, &define_cond_exec_tail, loc);
       break;
 




^ permalink raw reply	[flat|nested] 2+ messages in thread
* Re: [PATCH][gensupport] drop suppport for define_cond_exec from compact syntac
  2023-06-20 17:17 [PATCH][gensupport] drop suppport for define_cond_exec from compact syntac Tamar Christina
@ 2023-06-20 20:22 ` Richard Sandiford
  0 siblings, 0 replies; 2+ messages in thread
From: Richard Sandiford @ 2023-06-20 20:22 UTC (permalink / raw)
  To: Tamar Christina; +Cc: gcc-patches, nd

Tamar Christina <tamar.christina@arm.com> writes:
> Hi All,
>
> define_cond_exec does not support the special @@ syntax
> and so can't support {@.  As such just remove support
> for it.
>
> Bootstrapped and no issues.
>
> Ok for master?
>
> Thanks,
> Tamar
>
> gcc/ChangeLog:
>
> 	PR bootstrap/110324
> 	* gensupport.cc (convert_syntax): Explicitly check for RTX code.

OK, thanks.

Richard

> --- inline copy of patch -- 
> diff --git a/gcc/gensupport.cc b/gcc/gensupport.cc
> index 980b49cd4814c9f92cae5876a1bae936338df071..e39e6dacce25009df1ef83a0ab9ed309704ca74b 100644
> --- a/gcc/gensupport.cc
> +++ b/gcc/gensupport.cc
> @@ -878,7 +878,8 @@ convert_syntax (rtx x, file_location loc)
>    const char *templ;
>    vec_conlist tconvec, convec, attrvec;
>  
> -  templ_index = GET_CODE (x) == DEFINE_INSN ? 3 : 2;
> +  templ_index = 3;
> +  gcc_assert (GET_CODE (x) == DEFINE_INSN);
>  
>    templ = XTMPL (x, templ_index);
>  
> @@ -1053,7 +1054,6 @@ process_rtx (rtx desc, file_location loc)
>        break;
>  
>      case DEFINE_COND_EXEC:
> -      convert_syntax (desc, loc);
>        queue_pattern (desc, &define_cond_exec_tail, loc);
>        break;

^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-06-20 20:22 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-20 17:17 [PATCH][gensupport] drop suppport for define_cond_exec from compact syntac Tamar Christina
2023-06-20 20:22 ` Richard Sandiford

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).