From: Richard Biener <rguenther@suse.de>
To: gcc-patches@gcc.gnu.org
Cc: Jakub Jelinek <jakub@redhat.com>
Subject: Re: [PATCH] lto/109263 - lto-wrapper and -g0 -ggdb
Date: Mon, 27 Mar 2023 06:46:29 +0000 (UTC) [thread overview]
Message-ID: <nycvar.YFH.7.77.849.2303270645520.18795@jbgna.fhfr.qr> (raw)
On Thu, 23 Mar 2023, Richard Biener wrote:
> The following makes lto-wrapper deal with non-combined debug
> disabling / enabling option combinations properly. Interestingly
> -gno-dwarf also enables debug.
>
> Bootstrap / regtest running on x86_64-unknown-linux-gnu.
>
> OK? Or do we want to try harder to zap earlier -g0 when later
> -g* appear?
I pushed this to fix the regression, the patch stays valid even
when the patches rejecting negative variants of -ggdb and friends
is approved.
Richard.
> PR lto/109263
> * lto-wrapper.c (run_gcc): Parse alternate debug options
> as well, they always enable debug.
> ---
> gcc/lto-wrapper.cc | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/gcc/lto-wrapper.cc b/gcc/lto-wrapper.cc
> index fe8c5f6e80d..5186d040ce0 100644
> --- a/gcc/lto-wrapper.cc
> +++ b/gcc/lto-wrapper.cc
> @@ -1564,6 +1564,16 @@ run_gcc (unsigned argc, char *argv[])
> skip_debug = option->arg && !strcmp (option->arg, "0");
> break;
>
> + case OPT_gbtf:
> + case OPT_gctf:
> + case OPT_gdwarf:
> + case OPT_gdwarf_:
> + case OPT_ggdb:
> + case OPT_gvms:
> + /* Negative forms, if allowed, enable debug info as well. */
> + skip_debug = false;
> + break;
> +
> case OPT_dumpdir:
> incoming_dumppfx = dumppfx = option->arg;
> break;
>
--
Richard Biener <rguenther@suse.de>
SUSE Software Solutions Germany GmbH, Frankenstrasse 146, 90461 Nuernberg,
Germany; GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman;
HRB 36809 (AG Nuernberg)
next reply other threads:[~2023-03-27 6:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 6:46 Richard Biener [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-03-23 16:00 Richard Biener
2023-04-02 21:16 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.77.849.2303270645520.18795@jbgna.fhfr.qr \
--to=rguenther@suse.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).