From: Richard Biener <rguenther@suse.de>
To: "Andre Vieira (lists)" <andre.simoesdiasvieira@arm.com>
Cc: Richard Biener <richard.guenther@gmail.com>,
Richard Sandiford <Richard.Sandiford@arm.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH 3/3] Remove widen_plus/minus_expr tree codes
Date: Wed, 3 May 2023 12:29:14 +0000 (UTC) [thread overview]
Message-ID: <nycvar.YFH.7.77.849.2305031212240.4466@jbgna.fhfr.qr> (raw)
In-Reply-To: <b17b337e-369a-e78e-e065-94845dc8b0d4@arm.com>
On Fri, 28 Apr 2023, Andre Vieira (lists) wrote:
> This is a rebase of Joel's previous patch.
>
> This patch removes the old widen plus/minus tree codes which have been
> replaced by internal functions.
I guess that's obvious then. I wonder what we do to internal
fns in debug stmts? Looks like we throw those away and do not
generate debug stmts from calls.
Given you remove handling of the scalar WIDEN_PLUS/MINUS_EXPR
codes everywhere do we want to add checking code the scalar
IFNs do not appear in the IL? For at least some cases there
are corresponding functions handling internal functions that
you could have amended otherwise.
Richard.
> gcc/ChangeLog:
>
> 2023-04-28 Andre Vieira <andre.simoesdiasvieira@arm.com>
> Joel Hutton <joel.hutton@arm.com>
>
> * doc/generic.texi: Remove old tree codes.
> * expr.cc (expand_expr_real_2): Remove old tree code cases.
> * gimple-pretty-print.cc (dump_binary_rhs): Likewise.
> * optabs-tree.cc (optab_for_tree_code): Likewise.
> (supportable_half_widening_operation): Likewise.
> * tree-cfg.cc (verify_gimple_assign_binary): Likewise.
> * tree-inline.cc (estimate_operator_cost): Likewise.
> (op_symbol_code): Likewise.
> * tree-vect-data-refs.cc (vect_get_smallest_scalar_type): Likewise.
> (vect_analyze_data_ref_accesses): Likewise.
> * tree-vect-generic.cc (expand_vector_operations_1): Likewise.
> * cfgexpand.cc (expand_debug_expr): Likewise.
> * tree-vect-stmts.cc (vectorizable_conversion): Likewise.
> (supportable_widening_operation): Likewise.
> * gimple-range-op.cc (gimple_range_op_handler::maybe_non_standard):
> Likewise.
> * tree-vect-patterns.cc (vect_widened_op_tree): Refactor to replace
> usage in vect_recog_sad_pattern.
> (vect_recog_sad_pattern): Replace tree code widening pattern with
> internal function.
> (vect_recog_average_pattern): Likewise.
> * tree-pretty-print.cc (dump_generic_node): Remove tree code
> definition.
> * tree.def (WIDEN_PLUS_EXPR, WIDEN_MINUS_EXPR, VEC_WIDEN_PLUS_HI_EXPR,
> VEC_WIDEN_PLUS_LO_EXPR, VEC_WIDEN_MINUS_HI_EXPR,
> VEC_WIDEN_MINUS_LO_EXPR): Likewise
>
--
Richard Biener <rguenther@suse.de>
SUSE Software Solutions Germany GmbH, Frankenstrasse 146, 90461 Nuernberg,
Germany; GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman;
HRB 36809 (AG Nuernberg)
next prev parent reply other threads:[~2023-05-03 12:29 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-25 9:11 [ping][vect-patterns] Refactor widen_plus/widen_minus as internal_fns Joel Hutton
2022-05-27 13:23 ` Richard Biener
2022-05-31 10:07 ` Joel Hutton
2022-05-31 16:46 ` Tamar Christina
2022-06-01 10:11 ` Richard Biener
2022-06-06 17:20 ` Joel Hutton
2022-06-07 8:18 ` Richard Sandiford
2022-06-07 9:01 ` Joel Hutton
2022-06-09 14:03 ` Joel Hutton
2022-06-13 9:02 ` Richard Biener
2022-06-30 13:20 ` Joel Hutton
2022-07-12 12:32 ` Richard Biener
2023-03-17 10:14 ` Andre Vieira (lists)
2023-03-17 11:52 ` Richard Biener
2023-04-20 13:23 ` Andre Vieira (lists)
2023-04-24 11:57 ` Richard Biener
2023-04-24 13:01 ` Richard Sandiford
2023-04-25 12:30 ` Richard Biener
2023-04-28 16:06 ` Andre Vieira (lists)
2023-04-25 9:55 ` Andre Vieira (lists)
2023-04-28 12:36 ` [PATCH 1/3] Refactor to allow internal_fn's Andre Vieira (lists)
2023-05-03 11:55 ` Richard Biener
2023-05-04 15:20 ` Andre Vieira (lists)
2023-05-05 6:09 ` Richard Biener
2023-05-12 12:14 ` Andre Vieira (lists)
2023-05-12 13:18 ` Richard Biener
2023-04-28 12:37 ` [PATCH 2/3] Refactor widen_plus as internal_fn Andre Vieira (lists)
2023-05-03 12:11 ` Richard Biener
2023-05-03 19:07 ` Richard Sandiford
2023-05-12 12:16 ` Andre Vieira (lists)
2023-05-12 13:28 ` Richard Biener
2023-05-12 13:55 ` Andre Vieira (lists)
2023-05-12 14:01 ` Richard Sandiford
2023-05-15 10:20 ` Richard Biener
2023-05-15 10:47 ` Richard Sandiford
2023-05-15 11:01 ` Richard Biener
2023-05-15 11:10 ` Richard Sandiford
2023-05-15 11:53 ` Andre Vieira (lists)
2023-05-15 12:21 ` Richard Biener
2023-05-18 17:15 ` Andre Vieira (lists)
2023-05-22 13:06 ` Richard Biener
2023-06-01 16:27 ` Andre Vieira (lists)
2023-06-02 12:00 ` Richard Sandiford
2023-06-06 19:00 ` Jakub Jelinek
2023-06-06 21:28 ` [PATCH] modula2: Fix bootstrap Jakub Jelinek
2023-06-06 22:18 ` Gaius Mulley
2023-06-07 8:42 ` Andre Vieira (lists)
2023-06-13 14:48 ` Jakub Jelinek
2023-04-28 12:37 ` [PATCH 3/3] Remove widen_plus/minus_expr tree codes Andre Vieira (lists)
2023-05-03 12:29 ` Richard Biener [this message]
2023-05-10 9:15 ` Andre Vieira (lists)
2023-05-12 12:18 ` Andre Vieira (lists)
2022-06-13 9:18 ` [ping][vect-patterns] Refactor widen_plus/widen_minus as internal_fns Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.77.849.2305031212240.4466@jbgna.fhfr.qr \
--to=rguenther@suse.de \
--cc=Richard.Sandiford@arm.com \
--cc=andre.simoesdiasvieira@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).