* RE: [PATCH] Remove -save-temps from tests using -flto
[not found] <bd7c5e8e-5ef1-4ca2-b83a-7abec21b2cf2@DBAEUR03FT015.eop-EUR03.prod.protection.outlook.com>
@ 2023-06-19 9:59 ` Tamar Christina
2023-06-19 10:18 ` Richard Biener
0 siblings, 1 reply; 5+ messages in thread
From: Tamar Christina @ 2023-06-19 9:59 UTC (permalink / raw)
To: Richard Biener, gcc-patches
> -----Original Message-----
> From: Richard Biener <rguenther@suse.de>
> Sent: Monday, June 19, 2023 7:28 AM
> To: gcc-patches@gcc.gnu.org
> Cc: Tamar Christina <Tamar.Christina@arm.com>
> Subject: [PATCH] Remove -save-temps from tests using -flto
>
> The following removes -save-temps that doesn't seem to have any good
> reason from tests that also run with -flto added. That can cause ltrans files to
> race with other multilibs tested and I'm frequently seeing linker complaints
> that the architecture doesn't match here.
>
> I'm not sure whether the .ltrans.o files end up in a non gccN/ specific directory
> or if we end up sharing the same dir for different multilibs (not sure if it's easily
> possible to avoid that).
>
> Parallel testing on x86_64-unknown-linux-gnu in progress.
>
> Tamar, was there any reason to use -save-temps here?
At the time I was getting unresolved errors from these without it.
But perhaps that's something to do with dejagnu versions?
Tamar
>
> * gcc.dg/vect/vect-bic-bitmask-2.c: Remove -save-temps.
> * gcc.dg/vect/vect-bic-bitmask-3.c: Likewise.
> * gcc.dg/vect/vect-bic-bitmask-4.c: Likewise.
> * gcc.dg/vect/vect-bic-bitmask-5.c: Likewise.
> * gcc.dg/vect/vect-bic-bitmask-6.c: Likewise.
> * gcc.dg/vect/vect-bic-bitmask-8.c: Likewise.
> * gcc.dg/vect/vect-bic-bitmask-9.c: Likewise.
> * gcc.dg/vect/vect-bic-bitmask-10.c: Likewise.
> * gcc.dg/vect/vect-bic-bitmask-11.c: Likewise.
> ---
> gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-10.c | 2 +-
> gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-11.c | 2 +-
> gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-2.c | 2 +-
> gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-3.c | 2 +-
> gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-4.c | 2 +-
> gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-5.c | 2 +-
> gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-6.c | 2 +-
> gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-8.c | 2 +-
> gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-9.c | 2 +-
> 9 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-10.c
> b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-10.c
> index e9ec9603af6..e6810433d70 100644
> --- a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-10.c
> +++ b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-10.c
> @@ -1,6 +1,6 @@
> /* { dg-skip-if "missing optab for vectorization" { sparc*-*-* } } */
> /* { dg-do run } */
> -/* { dg-additional-options "-O3 -save-temps -fdump-tree-dce -w" } */
> +/* { dg-additional-options "-O3 -fdump-tree-dce -w" } */
>
> #include <stdint.h>
>
> diff --git a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-11.c
> b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-11.c
> index 06c103d3885..f83078b5d51 100644
> --- a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-11.c
> +++ b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-11.c
> @@ -1,6 +1,6 @@
> /* { dg-skip-if "missing optab for vectorization" { sparc*-*-* } } */
> /* { dg-do run } */
> -/* { dg-additional-options "-O3 -save-temps -fdump-tree-dce -w" } */
> +/* { dg-additional-options "-O3 -fdump-tree-dce -w" } */
>
> #include <stdint.h>
>
> diff --git a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-2.c
> b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-2.c
> index 059bfb3ae62..e33a824df07 100644
> --- a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-2.c
> +++ b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-2.c
> @@ -1,6 +1,6 @@
> /* { dg-skip-if "missing optab for vectorization" { sparc*-*-* } } */
> /* { dg-do run } */
> -/* { dg-additional-options "-O3 -save-temps -fdump-tree-dce -w" } */
> +/* { dg-additional-options "-O3 -fdump-tree-dce -w" } */
>
> #include <stdint.h>
>
> diff --git a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-3.c
> b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-3.c
> index 059bfb3ae62..e33a824df07 100644
> --- a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-3.c
> +++ b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-3.c
> @@ -1,6 +1,6 @@
> /* { dg-skip-if "missing optab for vectorization" { sparc*-*-* } } */
> /* { dg-do run } */
> -/* { dg-additional-options "-O3 -save-temps -fdump-tree-dce -w" } */
> +/* { dg-additional-options "-O3 -fdump-tree-dce -w" } */
>
> #include <stdint.h>
>
> diff --git a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-4.c
> b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-4.c
> index 91b82fb5988..8895d5c263c 100644
> --- a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-4.c
> +++ b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-4.c
> @@ -1,6 +1,6 @@
> /* { dg-skip-if "missing optab for vectorization" { sparc*-*-* } } */
> /* { dg-do run } */
> -/* { dg-additional-options "-O3 -save-temps -fdump-tree-dce -w" } */
> +/* { dg-additional-options "-O3 -fdump-tree-dce -w" } */
>
> #include <stdint.h>
>
> diff --git a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-5.c
> b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-5.c
> index 59f339fb8c5..77d4deb633c 100644
> --- a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-5.c
> +++ b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-5.c
> @@ -1,6 +1,6 @@
> /* { dg-skip-if "missing optab for vectorization" { sparc*-*-* } } */
> /* { dg-do run } */
> -/* { dg-additional-options "-O3 -save-temps -fdump-tree-dce -w" } */
> +/* { dg-additional-options "-O3 -fdump-tree-dce -w" } */
>
> #include <stdint.h>
>
> diff --git a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-6.c
> b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-6.c
> index 84df8371be5..7930346a602 100644
> --- a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-6.c
> +++ b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-6.c
> @@ -1,6 +1,6 @@
> /* { dg-skip-if "missing optab for vectorization" { sparc*-*-* } } */
> /* { dg-do run } */
> -/* { dg-additional-options "-O3 -save-temps -fdump-tree-dce -w" } */
> +/* { dg-additional-options "-O3 -fdump-tree-dce -w" } */
>
> #include <stdint.h>
>
> diff --git a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-8.c
> b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-8.c
> index b3e0b5ba92f..1af7104a37d 100644
> --- a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-8.c
> +++ b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-8.c
> @@ -1,6 +1,6 @@
> /* { dg-skip-if "missing optab for vectorization" { sparc*-*-* } } */
> /* { dg-do run } */
> -/* { dg-additional-options "-O3 -save-temps -fdump-tree-dce -w" } */
> +/* { dg-additional-options "-O3 -fdump-tree-dce -w" } */
>
> #include <stdint.h>
>
> diff --git a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-9.c
> b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-9.c
> index 5fcde11ad4e..f0a75604bcb 100644
> --- a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-9.c
> +++ b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-9.c
> @@ -1,6 +1,6 @@
> /* { dg-skip-if "missing optab for vectorization" { sparc*-*-* } } */
> /* { dg-do run } */
> -/* { dg-additional-options "-O3 -save-temps -fdump-tree-dce -w" } */
> +/* { dg-additional-options "-O3 -fdump-tree-dce -w" } */
>
> #include <stdint.h>
>
> --
> 2.35.3
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] Remove -save-temps from tests using -flto
2023-06-19 9:59 ` [PATCH] Remove -save-temps from tests using -flto Tamar Christina
@ 2023-06-19 10:18 ` Richard Biener
2023-06-19 10:50 ` Tamar Christina
0 siblings, 1 reply; 5+ messages in thread
From: Richard Biener @ 2023-06-19 10:18 UTC (permalink / raw)
To: Tamar Christina; +Cc: gcc-patches
On Mon, 19 Jun 2023, Tamar Christina wrote:
> > -----Original Message-----
> > From: Richard Biener <rguenther@suse.de>
> > Sent: Monday, June 19, 2023 7:28 AM
> > To: gcc-patches@gcc.gnu.org
> > Cc: Tamar Christina <Tamar.Christina@arm.com>
> > Subject: [PATCH] Remove -save-temps from tests using -flto
> >
> > The following removes -save-temps that doesn't seem to have any good
> > reason from tests that also run with -flto added. That can cause ltrans files to
> > race with other multilibs tested and I'm frequently seeing linker complaints
> > that the architecture doesn't match here.
> >
> > I'm not sure whether the .ltrans.o files end up in a non gccN/ specific directory
> > or if we end up sharing the same dir for different multilibs (not sure if it's easily
> > possible to avoid that).
> >
> > Parallel testing on x86_64-unknown-linux-gnu in progress.
> >
> > Tamar, was there any reason to use -save-temps here?
>
> At the time I was getting unresolved errors from these without it.
> But perhaps that's something to do with dejagnu versions?
I don't know. Can you check if there's an issue on your side when
removing -save-temps?
Richard.
> Tamar
>
> >
> > * gcc.dg/vect/vect-bic-bitmask-2.c: Remove -save-temps.
> > * gcc.dg/vect/vect-bic-bitmask-3.c: Likewise.
> > * gcc.dg/vect/vect-bic-bitmask-4.c: Likewise.
> > * gcc.dg/vect/vect-bic-bitmask-5.c: Likewise.
> > * gcc.dg/vect/vect-bic-bitmask-6.c: Likewise.
> > * gcc.dg/vect/vect-bic-bitmask-8.c: Likewise.
> > * gcc.dg/vect/vect-bic-bitmask-9.c: Likewise.
> > * gcc.dg/vect/vect-bic-bitmask-10.c: Likewise.
> > * gcc.dg/vect/vect-bic-bitmask-11.c: Likewise.
> > ---
> > gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-10.c | 2 +-
> > gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-11.c | 2 +-
> > gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-2.c | 2 +-
> > gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-3.c | 2 +-
> > gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-4.c | 2 +-
> > gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-5.c | 2 +-
> > gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-6.c | 2 +-
> > gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-8.c | 2 +-
> > gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-9.c | 2 +-
> > 9 files changed, 9 insertions(+), 9 deletions(-)
> >
> > diff --git a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-10.c
> > b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-10.c
> > index e9ec9603af6..e6810433d70 100644
> > --- a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-10.c
> > +++ b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-10.c
> > @@ -1,6 +1,6 @@
> > /* { dg-skip-if "missing optab for vectorization" { sparc*-*-* } } */
> > /* { dg-do run } */
> > -/* { dg-additional-options "-O3 -save-temps -fdump-tree-dce -w" } */
> > +/* { dg-additional-options "-O3 -fdump-tree-dce -w" } */
> >
> > #include <stdint.h>
> >
> > diff --git a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-11.c
> > b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-11.c
> > index 06c103d3885..f83078b5d51 100644
> > --- a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-11.c
> > +++ b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-11.c
> > @@ -1,6 +1,6 @@
> > /* { dg-skip-if "missing optab for vectorization" { sparc*-*-* } } */
> > /* { dg-do run } */
> > -/* { dg-additional-options "-O3 -save-temps -fdump-tree-dce -w" } */
> > +/* { dg-additional-options "-O3 -fdump-tree-dce -w" } */
> >
> > #include <stdint.h>
> >
> > diff --git a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-2.c
> > b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-2.c
> > index 059bfb3ae62..e33a824df07 100644
> > --- a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-2.c
> > +++ b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-2.c
> > @@ -1,6 +1,6 @@
> > /* { dg-skip-if "missing optab for vectorization" { sparc*-*-* } } */
> > /* { dg-do run } */
> > -/* { dg-additional-options "-O3 -save-temps -fdump-tree-dce -w" } */
> > +/* { dg-additional-options "-O3 -fdump-tree-dce -w" } */
> >
> > #include <stdint.h>
> >
> > diff --git a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-3.c
> > b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-3.c
> > index 059bfb3ae62..e33a824df07 100644
> > --- a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-3.c
> > +++ b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-3.c
> > @@ -1,6 +1,6 @@
> > /* { dg-skip-if "missing optab for vectorization" { sparc*-*-* } } */
> > /* { dg-do run } */
> > -/* { dg-additional-options "-O3 -save-temps -fdump-tree-dce -w" } */
> > +/* { dg-additional-options "-O3 -fdump-tree-dce -w" } */
> >
> > #include <stdint.h>
> >
> > diff --git a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-4.c
> > b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-4.c
> > index 91b82fb5988..8895d5c263c 100644
> > --- a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-4.c
> > +++ b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-4.c
> > @@ -1,6 +1,6 @@
> > /* { dg-skip-if "missing optab for vectorization" { sparc*-*-* } } */
> > /* { dg-do run } */
> > -/* { dg-additional-options "-O3 -save-temps -fdump-tree-dce -w" } */
> > +/* { dg-additional-options "-O3 -fdump-tree-dce -w" } */
> >
> > #include <stdint.h>
> >
> > diff --git a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-5.c
> > b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-5.c
> > index 59f339fb8c5..77d4deb633c 100644
> > --- a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-5.c
> > +++ b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-5.c
> > @@ -1,6 +1,6 @@
> > /* { dg-skip-if "missing optab for vectorization" { sparc*-*-* } } */
> > /* { dg-do run } */
> > -/* { dg-additional-options "-O3 -save-temps -fdump-tree-dce -w" } */
> > +/* { dg-additional-options "-O3 -fdump-tree-dce -w" } */
> >
> > #include <stdint.h>
> >
> > diff --git a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-6.c
> > b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-6.c
> > index 84df8371be5..7930346a602 100644
> > --- a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-6.c
> > +++ b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-6.c
> > @@ -1,6 +1,6 @@
> > /* { dg-skip-if "missing optab for vectorization" { sparc*-*-* } } */
> > /* { dg-do run } */
> > -/* { dg-additional-options "-O3 -save-temps -fdump-tree-dce -w" } */
> > +/* { dg-additional-options "-O3 -fdump-tree-dce -w" } */
> >
> > #include <stdint.h>
> >
> > diff --git a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-8.c
> > b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-8.c
> > index b3e0b5ba92f..1af7104a37d 100644
> > --- a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-8.c
> > +++ b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-8.c
> > @@ -1,6 +1,6 @@
> > /* { dg-skip-if "missing optab for vectorization" { sparc*-*-* } } */
> > /* { dg-do run } */
> > -/* { dg-additional-options "-O3 -save-temps -fdump-tree-dce -w" } */
> > +/* { dg-additional-options "-O3 -fdump-tree-dce -w" } */
> >
> > #include <stdint.h>
> >
> > diff --git a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-9.c
> > b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-9.c
> > index 5fcde11ad4e..f0a75604bcb 100644
> > --- a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-9.c
> > +++ b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-9.c
> > @@ -1,6 +1,6 @@
> > /* { dg-skip-if "missing optab for vectorization" { sparc*-*-* } } */
> > /* { dg-do run } */
> > -/* { dg-additional-options "-O3 -save-temps -fdump-tree-dce -w" } */
> > +/* { dg-additional-options "-O3 -fdump-tree-dce -w" } */
> >
> > #include <stdint.h>
> >
> > --
> > 2.35.3
>
--
Richard Biener <rguenther@suse.de>
SUSE Software Solutions Germany GmbH, Frankenstrasse 146, 90461 Nuernberg,
Germany; GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman;
HRB 36809 (AG Nuernberg)
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] Remove -save-temps from tests using -flto
2023-06-19 10:18 ` Richard Biener
@ 2023-06-19 10:50 ` Tamar Christina
2023-06-19 11:19 ` Richard Biener
0 siblings, 1 reply; 5+ messages in thread
From: Tamar Christina @ 2023-06-19 10:50 UTC (permalink / raw)
To: Richard Biener; +Cc: gcc-patches
> -----Original Message-----
> From: Richard Biener <rguenther@suse.de>
> Sent: Monday, June 19, 2023 11:19 AM
> To: Tamar Christina <Tamar.Christina@arm.com>
> Cc: gcc-patches@gcc.gnu.org
> Subject: RE: [PATCH] Remove -save-temps from tests using -flto
>
> On Mon, 19 Jun 2023, Tamar Christina wrote:
>
> > > -----Original Message-----
> > > From: Richard Biener <rguenther@suse.de>
> > > Sent: Monday, June 19, 2023 7:28 AM
> > > To: gcc-patches@gcc.gnu.org
> > > Cc: Tamar Christina <Tamar.Christina@arm.com>
> > > Subject: [PATCH] Remove -save-temps from tests using -flto
> > >
> > > The following removes -save-temps that doesn't seem to have any good
> > > reason from tests that also run with -flto added. That can cause
> > > ltrans files to race with other multilibs tested and I'm frequently
> > > seeing linker complaints that the architecture doesn't match here.
> > >
> > > I'm not sure whether the .ltrans.o files end up in a non gccN/
> > > specific directory or if we end up sharing the same dir for
> > > different multilibs (not sure if it's easily possible to avoid that).
> > >
> > > Parallel testing on x86_64-unknown-linux-gnu in progress.
> > >
> > > Tamar, was there any reason to use -save-temps here?
> >
> > At the time I was getting unresolved errors from these without it.
> > But perhaps that's something to do with dejagnu versions?
>
> I don't know. Can you check if there's an issue on your side when removing -
> save-temps?
Nope no issues, all tests still pass.
Regards,
Tamar
>
> Richard.
>
> > Tamar
> >
> > >
> > > * gcc.dg/vect/vect-bic-bitmask-2.c: Remove -save-temps.
> > > * gcc.dg/vect/vect-bic-bitmask-3.c: Likewise.
> > > * gcc.dg/vect/vect-bic-bitmask-4.c: Likewise.
> > > * gcc.dg/vect/vect-bic-bitmask-5.c: Likewise.
> > > * gcc.dg/vect/vect-bic-bitmask-6.c: Likewise.
> > > * gcc.dg/vect/vect-bic-bitmask-8.c: Likewise.
> > > * gcc.dg/vect/vect-bic-bitmask-9.c: Likewise.
> > > * gcc.dg/vect/vect-bic-bitmask-10.c: Likewise.
> > > * gcc.dg/vect/vect-bic-bitmask-11.c: Likewise.
> > > ---
> > > gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-10.c | 2 +-
> > > gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-11.c | 2 +-
> > > gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-2.c | 2 +-
> > > gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-3.c | 2 +-
> > > gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-4.c | 2 +-
> > > gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-5.c | 2 +-
> > > gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-6.c | 2 +-
> > > gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-8.c | 2 +-
> > > gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-9.c | 2 +-
> > > 9 files changed, 9 insertions(+), 9 deletions(-)
> > >
> > > diff --git a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-10.c
> > > b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-10.c
> > > index e9ec9603af6..e6810433d70 100644
> > > --- a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-10.c
> > > +++ b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-10.c
> > > @@ -1,6 +1,6 @@
> > > /* { dg-skip-if "missing optab for vectorization" { sparc*-*-* } }
> > > */
> > > /* { dg-do run } */
> > > -/* { dg-additional-options "-O3 -save-temps -fdump-tree-dce -w" }
> > > */
> > > +/* { dg-additional-options "-O3 -fdump-tree-dce -w" } */
> > >
> > > #include <stdint.h>
> > >
> > > diff --git a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-11.c
> > > b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-11.c
> > > index 06c103d3885..f83078b5d51 100644
> > > --- a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-11.c
> > > +++ b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-11.c
> > > @@ -1,6 +1,6 @@
> > > /* { dg-skip-if "missing optab for vectorization" { sparc*-*-* } }
> > > */
> > > /* { dg-do run } */
> > > -/* { dg-additional-options "-O3 -save-temps -fdump-tree-dce -w" }
> > > */
> > > +/* { dg-additional-options "-O3 -fdump-tree-dce -w" } */
> > >
> > > #include <stdint.h>
> > >
> > > diff --git a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-2.c
> > > b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-2.c
> > > index 059bfb3ae62..e33a824df07 100644
> > > --- a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-2.c
> > > +++ b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-2.c
> > > @@ -1,6 +1,6 @@
> > > /* { dg-skip-if "missing optab for vectorization" { sparc*-*-* } }
> > > */
> > > /* { dg-do run } */
> > > -/* { dg-additional-options "-O3 -save-temps -fdump-tree-dce -w" }
> > > */
> > > +/* { dg-additional-options "-O3 -fdump-tree-dce -w" } */
> > >
> > > #include <stdint.h>
> > >
> > > diff --git a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-3.c
> > > b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-3.c
> > > index 059bfb3ae62..e33a824df07 100644
> > > --- a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-3.c
> > > +++ b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-3.c
> > > @@ -1,6 +1,6 @@
> > > /* { dg-skip-if "missing optab for vectorization" { sparc*-*-* } }
> > > */
> > > /* { dg-do run } */
> > > -/* { dg-additional-options "-O3 -save-temps -fdump-tree-dce -w" }
> > > */
> > > +/* { dg-additional-options "-O3 -fdump-tree-dce -w" } */
> > >
> > > #include <stdint.h>
> > >
> > > diff --git a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-4.c
> > > b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-4.c
> > > index 91b82fb5988..8895d5c263c 100644
> > > --- a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-4.c
> > > +++ b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-4.c
> > > @@ -1,6 +1,6 @@
> > > /* { dg-skip-if "missing optab for vectorization" { sparc*-*-* } }
> > > */
> > > /* { dg-do run } */
> > > -/* { dg-additional-options "-O3 -save-temps -fdump-tree-dce -w" }
> > > */
> > > +/* { dg-additional-options "-O3 -fdump-tree-dce -w" } */
> > >
> > > #include <stdint.h>
> > >
> > > diff --git a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-5.c
> > > b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-5.c
> > > index 59f339fb8c5..77d4deb633c 100644
> > > --- a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-5.c
> > > +++ b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-5.c
> > > @@ -1,6 +1,6 @@
> > > /* { dg-skip-if "missing optab for vectorization" { sparc*-*-* } }
> > > */
> > > /* { dg-do run } */
> > > -/* { dg-additional-options "-O3 -save-temps -fdump-tree-dce -w" }
> > > */
> > > +/* { dg-additional-options "-O3 -fdump-tree-dce -w" } */
> > >
> > > #include <stdint.h>
> > >
> > > diff --git a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-6.c
> > > b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-6.c
> > > index 84df8371be5..7930346a602 100644
> > > --- a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-6.c
> > > +++ b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-6.c
> > > @@ -1,6 +1,6 @@
> > > /* { dg-skip-if "missing optab for vectorization" { sparc*-*-* } }
> > > */
> > > /* { dg-do run } */
> > > -/* { dg-additional-options "-O3 -save-temps -fdump-tree-dce -w" }
> > > */
> > > +/* { dg-additional-options "-O3 -fdump-tree-dce -w" } */
> > >
> > > #include <stdint.h>
> > >
> > > diff --git a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-8.c
> > > b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-8.c
> > > index b3e0b5ba92f..1af7104a37d 100644
> > > --- a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-8.c
> > > +++ b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-8.c
> > > @@ -1,6 +1,6 @@
> > > /* { dg-skip-if "missing optab for vectorization" { sparc*-*-* } }
> > > */
> > > /* { dg-do run } */
> > > -/* { dg-additional-options "-O3 -save-temps -fdump-tree-dce -w" }
> > > */
> > > +/* { dg-additional-options "-O3 -fdump-tree-dce -w" } */
> > >
> > > #include <stdint.h>
> > >
> > > diff --git a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-9.c
> > > b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-9.c
> > > index 5fcde11ad4e..f0a75604bcb 100644
> > > --- a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-9.c
> > > +++ b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-9.c
> > > @@ -1,6 +1,6 @@
> > > /* { dg-skip-if "missing optab for vectorization" { sparc*-*-* } }
> > > */
> > > /* { dg-do run } */
> > > -/* { dg-additional-options "-O3 -save-temps -fdump-tree-dce -w" }
> > > */
> > > +/* { dg-additional-options "-O3 -fdump-tree-dce -w" } */
> > >
> > > #include <stdint.h>
> > >
> > > --
> > > 2.35.3
> >
>
> --
> Richard Biener <rguenther@suse.de>
> SUSE Software Solutions Germany GmbH, Frankenstrasse 146, 90461
> Nuernberg, Germany; GF: Ivo Totev, Andrew Myers, Andrew McDonald,
> Boudien Moerman; HRB 36809 (AG Nuernberg)
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] Remove -save-temps from tests using -flto
2023-06-19 10:50 ` Tamar Christina
@ 2023-06-19 11:19 ` Richard Biener
0 siblings, 0 replies; 5+ messages in thread
From: Richard Biener @ 2023-06-19 11:19 UTC (permalink / raw)
To: Tamar Christina; +Cc: gcc-patches
On Mon, 19 Jun 2023, Tamar Christina wrote:
> > -----Original Message-----
> > From: Richard Biener <rguenther@suse.de>
> > Sent: Monday, June 19, 2023 11:19 AM
> > To: Tamar Christina <Tamar.Christina@arm.com>
> > Cc: gcc-patches@gcc.gnu.org
> > Subject: RE: [PATCH] Remove -save-temps from tests using -flto
> >
> > On Mon, 19 Jun 2023, Tamar Christina wrote:
> >
> > > > -----Original Message-----
> > > > From: Richard Biener <rguenther@suse.de>
> > > > Sent: Monday, June 19, 2023 7:28 AM
> > > > To: gcc-patches@gcc.gnu.org
> > > > Cc: Tamar Christina <Tamar.Christina@arm.com>
> > > > Subject: [PATCH] Remove -save-temps from tests using -flto
> > > >
> > > > The following removes -save-temps that doesn't seem to have any good
> > > > reason from tests that also run with -flto added. That can cause
> > > > ltrans files to race with other multilibs tested and I'm frequently
> > > > seeing linker complaints that the architecture doesn't match here.
> > > >
> > > > I'm not sure whether the .ltrans.o files end up in a non gccN/
> > > > specific directory or if we end up sharing the same dir for
> > > > different multilibs (not sure if it's easily possible to avoid that).
> > > >
> > > > Parallel testing on x86_64-unknown-linux-gnu in progress.
> > > >
> > > > Tamar, was there any reason to use -save-temps here?
> > >
> > > At the time I was getting unresolved errors from these without it.
> > > But perhaps that's something to do with dejagnu versions?
> >
> > I don't know. Can you check if there's an issue on your side when removing -
> > save-temps?
>
> Nope no issues, all tests still pass.
Pushed then.
Richard.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] Remove -save-temps from tests using -flto
@ 2023-06-19 6:28 Richard Biener
0 siblings, 0 replies; 5+ messages in thread
From: Richard Biener @ 2023-06-19 6:28 UTC (permalink / raw)
To: gcc-patches; +Cc: tamar.christina
The following removes -save-temps that doesn't seem to have any
good reason from tests that also run with -flto added. That can
cause ltrans files to race with other multilibs tested and I'm
frequently seeing linker complaints that the architecture
doesn't match here.
I'm not sure whether the .ltrans.o files end up in a non gccN/
specific directory or if we end up sharing the same dir for
different multilibs (not sure if it's easily possible to avoid that).
Parallel testing on x86_64-unknown-linux-gnu in progress.
Tamar, was there any reason to use -save-temps here?
* gcc.dg/vect/vect-bic-bitmask-2.c: Remove -save-temps.
* gcc.dg/vect/vect-bic-bitmask-3.c: Likewise.
* gcc.dg/vect/vect-bic-bitmask-4.c: Likewise.
* gcc.dg/vect/vect-bic-bitmask-5.c: Likewise.
* gcc.dg/vect/vect-bic-bitmask-6.c: Likewise.
* gcc.dg/vect/vect-bic-bitmask-8.c: Likewise.
* gcc.dg/vect/vect-bic-bitmask-9.c: Likewise.
* gcc.dg/vect/vect-bic-bitmask-10.c: Likewise.
* gcc.dg/vect/vect-bic-bitmask-11.c: Likewise.
---
gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-10.c | 2 +-
gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-11.c | 2 +-
gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-2.c | 2 +-
gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-3.c | 2 +-
gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-4.c | 2 +-
gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-5.c | 2 +-
gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-6.c | 2 +-
gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-8.c | 2 +-
gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-9.c | 2 +-
9 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-10.c b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-10.c
index e9ec9603af6..e6810433d70 100644
--- a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-10.c
+++ b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-10.c
@@ -1,6 +1,6 @@
/* { dg-skip-if "missing optab for vectorization" { sparc*-*-* } } */
/* { dg-do run } */
-/* { dg-additional-options "-O3 -save-temps -fdump-tree-dce -w" } */
+/* { dg-additional-options "-O3 -fdump-tree-dce -w" } */
#include <stdint.h>
diff --git a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-11.c b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-11.c
index 06c103d3885..f83078b5d51 100644
--- a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-11.c
+++ b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-11.c
@@ -1,6 +1,6 @@
/* { dg-skip-if "missing optab for vectorization" { sparc*-*-* } } */
/* { dg-do run } */
-/* { dg-additional-options "-O3 -save-temps -fdump-tree-dce -w" } */
+/* { dg-additional-options "-O3 -fdump-tree-dce -w" } */
#include <stdint.h>
diff --git a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-2.c b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-2.c
index 059bfb3ae62..e33a824df07 100644
--- a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-2.c
+++ b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-2.c
@@ -1,6 +1,6 @@
/* { dg-skip-if "missing optab for vectorization" { sparc*-*-* } } */
/* { dg-do run } */
-/* { dg-additional-options "-O3 -save-temps -fdump-tree-dce -w" } */
+/* { dg-additional-options "-O3 -fdump-tree-dce -w" } */
#include <stdint.h>
diff --git a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-3.c b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-3.c
index 059bfb3ae62..e33a824df07 100644
--- a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-3.c
+++ b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-3.c
@@ -1,6 +1,6 @@
/* { dg-skip-if "missing optab for vectorization" { sparc*-*-* } } */
/* { dg-do run } */
-/* { dg-additional-options "-O3 -save-temps -fdump-tree-dce -w" } */
+/* { dg-additional-options "-O3 -fdump-tree-dce -w" } */
#include <stdint.h>
diff --git a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-4.c b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-4.c
index 91b82fb5988..8895d5c263c 100644
--- a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-4.c
+++ b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-4.c
@@ -1,6 +1,6 @@
/* { dg-skip-if "missing optab for vectorization" { sparc*-*-* } } */
/* { dg-do run } */
-/* { dg-additional-options "-O3 -save-temps -fdump-tree-dce -w" } */
+/* { dg-additional-options "-O3 -fdump-tree-dce -w" } */
#include <stdint.h>
diff --git a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-5.c b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-5.c
index 59f339fb8c5..77d4deb633c 100644
--- a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-5.c
+++ b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-5.c
@@ -1,6 +1,6 @@
/* { dg-skip-if "missing optab for vectorization" { sparc*-*-* } } */
/* { dg-do run } */
-/* { dg-additional-options "-O3 -save-temps -fdump-tree-dce -w" } */
+/* { dg-additional-options "-O3 -fdump-tree-dce -w" } */
#include <stdint.h>
diff --git a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-6.c b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-6.c
index 84df8371be5..7930346a602 100644
--- a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-6.c
+++ b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-6.c
@@ -1,6 +1,6 @@
/* { dg-skip-if "missing optab for vectorization" { sparc*-*-* } } */
/* { dg-do run } */
-/* { dg-additional-options "-O3 -save-temps -fdump-tree-dce -w" } */
+/* { dg-additional-options "-O3 -fdump-tree-dce -w" } */
#include <stdint.h>
diff --git a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-8.c b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-8.c
index b3e0b5ba92f..1af7104a37d 100644
--- a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-8.c
+++ b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-8.c
@@ -1,6 +1,6 @@
/* { dg-skip-if "missing optab for vectorization" { sparc*-*-* } } */
/* { dg-do run } */
-/* { dg-additional-options "-O3 -save-temps -fdump-tree-dce -w" } */
+/* { dg-additional-options "-O3 -fdump-tree-dce -w" } */
#include <stdint.h>
diff --git a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-9.c b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-9.c
index 5fcde11ad4e..f0a75604bcb 100644
--- a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-9.c
+++ b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-9.c
@@ -1,6 +1,6 @@
/* { dg-skip-if "missing optab for vectorization" { sparc*-*-* } } */
/* { dg-do run } */
-/* { dg-additional-options "-O3 -save-temps -fdump-tree-dce -w" } */
+/* { dg-additional-options "-O3 -fdump-tree-dce -w" } */
#include <stdint.h>
--
2.35.3
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-06-19 11:19 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <bd7c5e8e-5ef1-4ca2-b83a-7abec21b2cf2@DBAEUR03FT015.eop-EUR03.prod.protection.outlook.com>
2023-06-19 9:59 ` [PATCH] Remove -save-temps from tests using -flto Tamar Christina
2023-06-19 10:18 ` Richard Biener
2023-06-19 10:50 ` Tamar Christina
2023-06-19 11:19 ` Richard Biener
2023-06-19 6:28 Richard Biener
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).