* [PATCH V2] test: Fix FAIL of pr97428.c for RVV
@ 2023-11-07 12:09 Juzhe-Zhong
2023-11-07 13:50 ` Richard Biener
0 siblings, 1 reply; 3+ messages in thread
From: Juzhe-Zhong @ 2023-11-07 12:09 UTC (permalink / raw)
To: gcc-patches; +Cc: rguenther, jeffreyalaw, Juzhe-Zhong
This test shows vectorizing stmts using SLP 4 times instead of 2 for RVV.
The reason is RVV has 512 bit vector.
Here is comparison between RVV ans ARM SVE:
https://godbolt.org/z/xc5KE5rPs
Confirm GCN also matches 4 SLP. This patch is passed on both GCN and RVV.
Ok for trunk ?
gcc/testsuite/ChangeLog:
* gcc.dg/vect/pr97428.c: Adapt for RVV and GCN.
---
gcc/testsuite/gcc.dg/vect/pr97428.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/gcc/testsuite/gcc.dg/vect/pr97428.c b/gcc/testsuite/gcc.dg/vect/pr97428.c
index ad6416096aa..f77adb1be97 100644
--- a/gcc/testsuite/gcc.dg/vect/pr97428.c
+++ b/gcc/testsuite/gcc.dg/vect/pr97428.c
@@ -43,5 +43,6 @@ void foo_i2(dcmlx4_t dst[], const dcmlx_t src[], int n)
/* { dg-final { scan-tree-dump "Detected interleaving store of size 16" "vect" } } */
/* We're not able to peel & apply re-aligning to make accesses well-aligned for !vect_hw_misalign,
but we could by peeling the stores for alignment and applying re-aligning loads. */
-/* { dg-final { scan-tree-dump-times "vectorizing stmts using SLP" 2 "vect" { xfail { ! vect_hw_misalign } } } } */
+/* { dg-final { scan-tree-dump-times "vectorizing stmts using SLP" 2 "vect" { target { { vect_hw_misalign } && { ! vect512 } } } } } */
+/* { dg-final { scan-tree-dump-times "vectorizing stmts using SLP" 4 "vect" { target { vect512 } } } } */
/* { dg-final { scan-tree-dump-not "gap of 6 elements" "vect" } } */
--
2.36.3
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH V2] test: Fix FAIL of pr97428.c for RVV
2023-11-07 12:09 [PATCH V2] test: Fix FAIL of pr97428.c for RVV Juzhe-Zhong
@ 2023-11-07 13:50 ` Richard Biener
2023-11-07 15:20 ` 钟居哲
0 siblings, 1 reply; 3+ messages in thread
From: Richard Biener @ 2023-11-07 13:50 UTC (permalink / raw)
To: Juzhe-Zhong; +Cc: gcc-patches, jeffreyalaw
On Tue, 7 Nov 2023, Juzhe-Zhong wrote:
> This test shows vectorizing stmts using SLP 4 times instead of 2 for RVV.
> The reason is RVV has 512 bit vector.
> Here is comparison between RVV ans ARM SVE:
> https://godbolt.org/z/xc5KE5rPs
>
> Confirm GCN also matches 4 SLP. This patch is passed on both GCN and RVV.
>
> Ok for trunk ?
Does --param vect-epilogues-nomask=0 help?
> gcc/testsuite/ChangeLog:
>
> * gcc.dg/vect/pr97428.c: Adapt for RVV and GCN.
>
> ---
> gcc/testsuite/gcc.dg/vect/pr97428.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gcc/testsuite/gcc.dg/vect/pr97428.c b/gcc/testsuite/gcc.dg/vect/pr97428.c
> index ad6416096aa..f77adb1be97 100644
> --- a/gcc/testsuite/gcc.dg/vect/pr97428.c
> +++ b/gcc/testsuite/gcc.dg/vect/pr97428.c
> @@ -43,5 +43,6 @@ void foo_i2(dcmlx4_t dst[], const dcmlx_t src[], int n)
> /* { dg-final { scan-tree-dump "Detected interleaving store of size 16" "vect" } } */
> /* We're not able to peel & apply re-aligning to make accesses well-aligned for !vect_hw_misalign,
> but we could by peeling the stores for alignment and applying re-aligning loads. */
> -/* { dg-final { scan-tree-dump-times "vectorizing stmts using SLP" 2 "vect" { xfail { ! vect_hw_misalign } } } } */
> +/* { dg-final { scan-tree-dump-times "vectorizing stmts using SLP" 2 "vect" { target { { vect_hw_misalign } && { ! vect512 } } } } } */
> +/* { dg-final { scan-tree-dump-times "vectorizing stmts using SLP" 4 "vect" { target { vect512 } } } } */
> /* { dg-final { scan-tree-dump-not "gap of 6 elements" "vect" } } */
>
--
Richard Biener <rguenther@suse.de>
SUSE Software Solutions Germany GmbH,
Frankenstrasse 146, 90461 Nuernberg, Germany;
GF: Ivo Totev, Andrew McDonald, Werner Knoblich; (HRB 36809, AG Nuernberg)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Re: [PATCH V2] test: Fix FAIL of pr97428.c for RVV
2023-11-07 13:50 ` Richard Biener
@ 2023-11-07 15:20 ` 钟居哲
0 siblings, 0 replies; 3+ messages in thread
From: 钟居哲 @ 2023-11-07 15:20 UTC (permalink / raw)
To: rguenther; +Cc: gcc-patches, Jeff Law
[-- Attachment #1: Type: text/plain, Size: 2140 bytes --]
Yes! Thanks a lot.
Fix as you suggested in V3:
https://gcc.gnu.org/pipermail/gcc-patches/2023-November/635591.html
juzhe.zhong@rivai.ai
From: Richard Biener
Date: 2023-11-07 21:50
To: Juzhe-Zhong
CC: gcc-patches; jeffreyalaw
Subject: Re: [PATCH V2] test: Fix FAIL of pr97428.c for RVV
On Tue, 7 Nov 2023, Juzhe-Zhong wrote:
> This test shows vectorizing stmts using SLP 4 times instead of 2 for RVV.
> The reason is RVV has 512 bit vector.
> Here is comparison between RVV ans ARM SVE:
> https://godbolt.org/z/xc5KE5rPs
>
> Confirm GCN also matches 4 SLP. This patch is passed on both GCN and RVV.
>
> Ok for trunk ?
Does --param vect-epilogues-nomask=0 help?
> gcc/testsuite/ChangeLog:
>
> * gcc.dg/vect/pr97428.c: Adapt for RVV and GCN.
>
> ---
> gcc/testsuite/gcc.dg/vect/pr97428.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gcc/testsuite/gcc.dg/vect/pr97428.c b/gcc/testsuite/gcc.dg/vect/pr97428.c
> index ad6416096aa..f77adb1be97 100644
> --- a/gcc/testsuite/gcc.dg/vect/pr97428.c
> +++ b/gcc/testsuite/gcc.dg/vect/pr97428.c
> @@ -43,5 +43,6 @@ void foo_i2(dcmlx4_t dst[], const dcmlx_t src[], int n)
> /* { dg-final { scan-tree-dump "Detected interleaving store of size 16" "vect" } } */
> /* We're not able to peel & apply re-aligning to make accesses well-aligned for !vect_hw_misalign,
> but we could by peeling the stores for alignment and applying re-aligning loads. */
> -/* { dg-final { scan-tree-dump-times "vectorizing stmts using SLP" 2 "vect" { xfail { ! vect_hw_misalign } } } } */
> +/* { dg-final { scan-tree-dump-times "vectorizing stmts using SLP" 2 "vect" { target { { vect_hw_misalign } && { ! vect512 } } } } } */
> +/* { dg-final { scan-tree-dump-times "vectorizing stmts using SLP" 4 "vect" { target { vect512 } } } } */
> /* { dg-final { scan-tree-dump-not "gap of 6 elements" "vect" } } */
>
--
Richard Biener <rguenther@suse.de>
SUSE Software Solutions Germany GmbH,
Frankenstrasse 146, 90461 Nuernberg, Germany;
GF: Ivo Totev, Andrew McDonald, Werner Knoblich; (HRB 36809, AG Nuernberg)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-07 15:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-07 12:09 [PATCH V2] test: Fix FAIL of pr97428.c for RVV Juzhe-Zhong
2023-11-07 13:50 ` Richard Biener
2023-11-07 15:20 ` 钟居哲
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).