From: Alexandre Oliva <oliva@adacore.com>
To: "Kewen.Lin" <linkw@linux.ibm.com>
Cc: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>,
Mike Stump <mikestump@comcast.net>,
David Edelsohn <dje.gcc@gmail.com>,
Segher Boessenkool <segher@kernel.crashing.org>,
Kewen Lin <linkw@gcc.gnu.org>,
gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] [testsuite] [powerpc] adjust -m32 counts for fold-vec-extract*
Date: Thu, 25 May 2023 07:05:55 -0300 [thread overview]
Message-ID: <or5y8gbu9o.fsf@lxoliva.fsfla.org> (raw)
In-Reply-To: <0737fbfc-726c-ffca-5f36-d6b3f0decfec@linux.ibm.com> (Kewen Lin's message of "Thu, 25 May 2023 13:44:00 +0800")
On May 25, 2023, "Kewen.Lin" <linkw@linux.ibm.com> wrote:
> Thanks for fixing, I tested this on ppc64le and ppc64 {-m64,-m32}
> well.
Thanks!
> I think this is for PR101169, could you add it as PR marker?
Nice, will do!
>> -/* { dg-final { scan-assembler-times {\maddi\M|\madd\M} 3 { target ilp32 } } } */
>> +/* { dg-final { scan-assembler-times {\maddi\M|\madd\M} 2 { target ilp32 } } } */
> So both lp64 and ilp32 have the same count, could we merge it and
> remove the selectors?
We could, but... I thought I wouldn't, since they were different
before, and they're likely to diverge again in the future. I thought
that combining them might suggest that they ought to be the same, when
we already know that this is not the case.
I'll prepare an alternate patch that combines them.
--
Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/
Free Software Activist GNU Toolchain Engineer
Disinformation flourishes because many people care deeply about injustice
but very few check the facts. Ask me about <https://stallmansupport.org>
next prev parent reply other threads:[~2023-05-25 10:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-24 5:51 Alexandre Oliva
2023-05-25 5:44 ` Kewen.Lin
2023-05-25 10:05 ` Alexandre Oliva [this message]
2023-05-25 11:22 ` Segher Boessenkool
2023-05-25 13:55 ` Alexandre Oliva
2023-05-25 15:33 ` Segher Boessenkool
2024-04-22 10:11 ` [PATCH v2] " Alexandre Oliva
2024-05-25 8:17 ` Alexandre Oliva
2024-05-27 3:11 ` Kewen.Lin
2024-05-29 17:01 ` Alexandre Oliva
2023-05-31 9:00 ` [PATCH] " Kewen.Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=or5y8gbu9o.fsf@lxoliva.fsfla.org \
--to=oliva@adacore.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=linkw@gcc.gnu.org \
--cc=linkw@linux.ibm.com \
--cc=mikestump@comcast.net \
--cc=ro@CeBiTec.Uni-Bielefeld.DE \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).