From: Alexandre Oliva <oliva@adacore.com>
To: Richard Biener <richard.guenther@gmail.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] fix frange_nextafter odr violation
Date: Fri, 09 Jun 2023 09:26:29 -0300 [thread overview]
Message-ID: <orh6rg2556.fsf@lxoliva.fsfla.org> (raw)
In-Reply-To: <CAFiYyc3Qo7cVWqNtQHL_EK7f_RPeWTo7L1TGgHatxiY2mDOYLw@mail.gmail.com> (Richard Biener's message of "Fri, 9 Jun 2023 11:03:42 +0200")
On Jun 9, 2023, Richard Biener <richard.guenther@gmail.com> wrote:
> On Thu, Jun 8, 2023 at 4:38 PM Alexandre Oliva via Gcc-patches
> <gcc-patches@gcc.gnu.org> wrote:
>> C++ requires inline functions to be declared inline and defined in
>> every translation unit that uses them. frange_nextafter is used in
>> gimple-range-op.cc but it's only defined as inline in
>> range-op-float.cc. Drop the extraneous inline specifier.
> OK
>> for gcc/ChangeLog
>>
>> * range-op-float.cc (frange_nextafter): Drop inline.
>> (frelop_early_resolve): Add static.
>> (frange_float): Likewise.
The problem is also present in gcc-13. Ok there as well? Regstrapped
on x86_64-linux-gnu.
--
Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/
Free Software Activist GNU Toolchain Engineer
Disinformation flourishes because many people care deeply about injustice
but very few check the facts. Ask me about <https://stallmansupport.org>
next prev parent reply other threads:[~2023-06-09 12:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-08 14:37 Alexandre Oliva
2023-06-09 9:03 ` Richard Biener
2023-06-09 12:26 ` Alexandre Oliva [this message]
2023-06-09 12:50 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=orh6rg2556.fsf@lxoliva.fsfla.org \
--to=oliva@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).