From: Alexandre Oliva <oliva@gnu.org>
To: Eric Gallager <egall@gwmail.gwu.edu>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>,
Paolo Bonzini <bonzini@gnu.org>,
neroden@gcc.gnu.org, Ralf.Wildenhues@gmx.de
Subject: Re: [PING][PATCH][WIP] have configure probe prefix for gmp/mpfr/mpc [PR44425]
Date: Tue, 21 Jun 2022 00:17:41 -0300 [thread overview]
Message-ID: <orh74eg0x6.fsf@lxoliva.fsfla.org> (raw)
In-Reply-To: <CAMfHzOsv-sT3a77CVm7pY+ehjANKH6vry2irKzXRTUQtTbznqw@mail.gmail.com> (Eric Gallager's message of "Thu, 9 Jun 2022 16:04:50 -0400")
Hello, Eric,
On Jun 9, 2022, Eric Gallager <egall@gwmail.gwu.edu> wrote:
> (cc-ing the build machinery maintainers listed in MAINTAINERS this time)
Thanks, I'd missed it the first time.
> On Thu, Jun 2, 2022 at 11:53 AM Eric Gallager <egall@gwmail.gwu.edu> wrote:
>> So, I'm working on fixing PR bootstrap/44425, and have this patch to
>> have the top-level configure script check in the value passed to
>> `--prefix=` when looking for gmp/mpfr/mpc. It "works" (in that
>> configuring with just `--prefix=` and none of
>> `--with-gmp=`/`--with-mpfr=`/`--with-mpc=` now works where it failed
>> before), but unfortunately it results in a bunch of duplicated
>> `-I`/`-L` flags stuck in ${gmplibs} and ${gmpinc}... is that
>> acceptable or should I try another approach?
I wonder if it would make sense to add -L${libdir} and -I${includedir}
to host flags. It would obviate the explicit flag-setting for each of
the libs, and it would address the apparent double-setting when prefix
is set, or confusingly partial overrides when --with-*-include and
--with-*-lib are used.
It would be IMHO preferrable to use libdir and includedir, rather than
prefix, especially for cases in which exec_prefix != prefix, but takes
some work for libdir and includedir to be expanded correctly during
configure. E.g., libdir is normally set to ${exec_prefix}/lib, and
exec_prefix defaults to ${prefix}, but a shell won't expand multiple
layers of macros like make does, so configure needs some help with that.
--
Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/
Free Software Activist GNU Toolchain Engineer
Disinformation flourishes because many people care deeply about injustice
but very few check the facts. Ask me about <https://stallmansupport.org>
next prev parent reply other threads:[~2022-06-21 3:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-02 15:53 [PATCH][WIP] " Eric Gallager
2022-06-09 20:04 ` [PING][PATCH][WIP] " Eric Gallager
2022-06-10 11:22 ` Xi Ruoyao
2022-06-11 14:23 ` Eric Gallager
2022-06-21 3:17 ` Alexandre Oliva [this message]
2022-06-13 11:02 ` [PATCH][WIP] " Richard Biener
2022-06-13 14:27 ` Eric Gallager
2022-06-14 13:14 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=orh74eg0x6.fsf@lxoliva.fsfla.org \
--to=oliva@gnu.org \
--cc=Ralf.Wildenhues@gmx.de \
--cc=bonzini@gnu.org \
--cc=egall@gwmail.gwu.edu \
--cc=gcc-patches@gcc.gnu.org \
--cc=neroden@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).