From: Xi Ruoyao <xry111@xry111.site>
To: Eric Gallager <egall@gwmail.gwu.edu>,
gcc-patches <gcc-patches@gcc.gnu.org>
Cc: Paolo Bonzini <bonzini@gnu.org>, aoliva@gcc.gnu.org, neroden@gcc.gnu.org
Subject: Re: [PING][PATCH][WIP] have configure probe prefix for gmp/mpfr/mpc [PR44425]
Date: Fri, 10 Jun 2022 19:22:19 +0800 [thread overview]
Message-ID: <6b83d5a42ee91313c2d37da1f55a08819258e589.camel@xry111.site> (raw)
In-Reply-To: <CAMfHzOsv-sT3a77CVm7pY+ehjANKH6vry2irKzXRTUQtTbznqw@mail.gmail.com>
On Thu, 2022-06-09 at 16:04 -0400, Eric Gallager via Gcc-patches wrote:
> Hi, I'd like to ping this patch:
> https://gcc.gnu.org/pipermail/gcc-patches/2022-June/596126.html
> (cc-ing the build machinery maintainers listed in MAINTAINERS this
> time)
>
> On Thu, Jun 2, 2022 at 11:53 AM Eric Gallager <egall@gwmail.gwu.edu>
> wrote:
> >
> > So, I'm working on fixing PR bootstrap/44425, and have this patch to
> > have the top-level configure script check in the value passed to
> > `--prefix=` when looking for gmp/mpfr/mpc. It "works" (in that
> > configuring with just `--prefix=` and none of
> > `--with-gmp=`/`--with-mpfr=`/`--with-mpc=` now works where it failed
> > before), but unfortunately it results in a bunch of duplicated
> > `-I`/`-L` flags stuck in ${gmplibs} and ${gmpinc}... is that
> > acceptable or should I try another approach?
> > Eric
A patch should not edit configure directly. configure.ac should be
edited and configure should be regenerated from it.
--
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University
next prev parent reply other threads:[~2022-06-10 11:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-02 15:53 [PATCH][WIP] " Eric Gallager
2022-06-09 20:04 ` [PING][PATCH][WIP] " Eric Gallager
2022-06-10 11:22 ` Xi Ruoyao [this message]
2022-06-11 14:23 ` Eric Gallager
2022-06-21 3:17 ` Alexandre Oliva
2022-06-13 11:02 ` [PATCH][WIP] " Richard Biener
2022-06-13 14:27 ` Eric Gallager
2022-06-14 13:14 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b83d5a42ee91313c2d37da1f55a08819258e589.camel@xry111.site \
--to=xry111@xry111.site \
--cc=aoliva@gcc.gnu.org \
--cc=bonzini@gnu.org \
--cc=egall@gwmail.gwu.edu \
--cc=gcc-patches@gcc.gnu.org \
--cc=neroden@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).