* [PATCH] [arm] xfail fp-uint64-convert-double tests
@ 2022-12-02 9:34 Alexandre Oliva
2022-12-05 16:42 ` Jeff Law
0 siblings, 1 reply; 2+ messages in thread
From: Alexandre Oliva @ 2022-12-02 9:34 UTC (permalink / raw)
To: gcc-patches
Cc: Nick Clifton, Richard Earnshaw, Ramana Radhakrishnan,
Kyrylo Tkachov, Rainer Orth, Mike Stump
The FP emulation on ARM doesn't take rounding modes into account. The
tests require hard_float, but that only tests for calls when adding
doubles. There are arm targets that support hardware adds, but that
emulate conversions.
Regstraped on x86_64-linux-gnu, also tested with crosses to riscv64-elf
and arm-eabi. Ok to install?
PS: I've pondered changing hard_float instead, but decided that could
impact other tests that rely on its current behavior. Then I considered
adding a variant of hard_float that tested for conversions, but thought
that it was overkill.
for gcc/testsuite/ChangeLog
* gcc.dg/torture/fp-uint64-convert-double-1.c: Expect fail on
arm-*-eabi*.
* gcc.dg/torture/fp-uint64-convert-double-2.c: Likewise.
---
.../gcc.dg/torture/fp-uint64-convert-double-1.c | 2 +-
.../gcc.dg/torture/fp-uint64-convert-double-2.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/gcc/testsuite/gcc.dg/torture/fp-uint64-convert-double-1.c b/gcc/testsuite/gcc.dg/torture/fp-uint64-convert-double-1.c
index 0c7bf003e93ed..61cfa96374631 100644
--- a/gcc/testsuite/gcc.dg/torture/fp-uint64-convert-double-1.c
+++ b/gcc/testsuite/gcc.dg/torture/fp-uint64-convert-double-1.c
@@ -1,5 +1,5 @@
/* PR84407 */
-/* { dg-do run } */
+/* { dg-do run { xfail { arm-*-eabi* } } } */
/* { dg-require-effective-target fenv } */
/* { dg-require-effective-target hard_float } */
/* { dg-additional-options "-frounding-math -fexcess-precision=standard" } */
diff --git a/gcc/testsuite/gcc.dg/torture/fp-uint64-convert-double-2.c b/gcc/testsuite/gcc.dg/torture/fp-uint64-convert-double-2.c
index ac24b351a46d6..b32b28a329580 100644
--- a/gcc/testsuite/gcc.dg/torture/fp-uint64-convert-double-2.c
+++ b/gcc/testsuite/gcc.dg/torture/fp-uint64-convert-double-2.c
@@ -1,5 +1,5 @@
/* PR84407 */
-/* { dg-do run } */
+/* { dg-do run { xfail { arm-*-eabi* } } } */
/* { dg-require-effective-target fenv } */
/* { dg-require-effective-target hard_float } */
/* { dg-additional-options "-frounding-math" } */
--
Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/
Free Software Activist GNU Toolchain Engineer
Disinformation flourishes because many people care deeply about injustice
but very few check the facts. Ask me about <https://stallmansupport.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] [arm] xfail fp-uint64-convert-double tests
2022-12-02 9:34 [PATCH] [arm] xfail fp-uint64-convert-double tests Alexandre Oliva
@ 2022-12-05 16:42 ` Jeff Law
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Law @ 2022-12-05 16:42 UTC (permalink / raw)
To: Alexandre Oliva, gcc-patches
Cc: Nick Clifton, Richard Earnshaw, Ramana Radhakrishnan,
Kyrylo Tkachov, Rainer Orth, Mike Stump
On 12/2/22 02:34, Alexandre Oliva via Gcc-patches wrote:
>
> The FP emulation on ARM doesn't take rounding modes into account. The
> tests require hard_float, but that only tests for calls when adding
> doubles. There are arm targets that support hardware adds, but that
> emulate conversions.
>
> Regstraped on x86_64-linux-gnu, also tested with crosses to riscv64-elf
> and arm-eabi. Ok to install?
>
> PS: I've pondered changing hard_float instead, but decided that could
> impact other tests that rely on its current behavior. Then I considered
> adding a variant of hard_float that tested for conversions, but thought
> that it was overkill.
>
>
> for gcc/testsuite/ChangeLog
>
> * gcc.dg/torture/fp-uint64-convert-double-1.c: Expect fail on
> arm-*-eabi*.
> * gcc.dg/torture/fp-uint64-convert-double-2.c: Likewise.
OK
jeff
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-12-05 16:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-02 9:34 [PATCH] [arm] xfail fp-uint64-convert-double tests Alexandre Oliva
2022-12-05 16:42 ` Jeff Law
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).