public inbox for
 help / color / mirror / Atom feed
* [PATCH 12/12] ipa: Avoid looking for IPA-SRA replacements where there are none
@ 2022-11-12  1:47 Martin Jambor
  0 siblings, 0 replies; only message in thread
From: Martin Jambor @ 2022-11-12  1:47 UTC (permalink / raw)
  To: GCC Patches; +Cc: Jan Hubicka, Jan Hubicka


while modifying the code, I realized that we do look into statements
even when there are no replacements.  This patch adds the necessary
early bail-outs to avoid that.

ipa_param_body_adjustments::modify_call_stmt cannot have the same at
the very beginning because calls can still contain otherwise removed
parameters that need to be removed from the statements too.

Bootstrapped and tested on x86_64-linux.  OK for master?




2022-11-11  Martin Jambor  <>

	(ipa_param_body_adjustments::modify_expression): Bail out early if
	there are no replacements.
	(ipa_param_body_adjustments::modify_assignment): Likewise.


2022-11-11  Martin Jambor  <>

	PR ipa/103227
	PR ipa/107640
	* gcc.dg/ipa/pr107640-2.c: New test.
 gcc/ | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gcc/ b/gcc/
index e92cfc0b6d5..da19d64cbce 100644
--- a/gcc/
+++ b/gcc/
@@ -1762,6 +1762,8 @@ ipa_param_body_adjustments::modify_expression (tree *expr_p, bool convert)
   tree expr = *expr_p;
+  if (m_replacements.is_empty ())
+    return false;
   if (TREE_CODE (expr) == BIT_FIELD_REF
       || TREE_CODE (expr) == IMAGPART_EXPR
       || TREE_CODE (expr) == REALPART_EXPR)
@@ -1809,7 +1811,7 @@ ipa_param_body_adjustments::modify_assignment (gimple *stmt,
   tree *lhs_p, *rhs_p;
   bool any;
-  if (!gimple_assign_single_p (stmt))
+  if (m_replacements.is_empty () || !gimple_assign_single_p (stmt))
     return false;
   rhs_p = gimple_assign_rhs1_ptr (stmt);

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-11-12  1:47 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-12  1:47 [PATCH 12/12] ipa: Avoid looking for IPA-SRA replacements where there are none Martin Jambor

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).