public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Martin Jambor <mjambor@suse.cz>
To: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] ipa: Avoid invalid gimple when IPA-CP and IPA-SRA disagree on types (108384)
Date: Mon, 06 Feb 2023 15:16:09 +0100	[thread overview]
Message-ID: <ri6ilgeanh2.fsf@suse.cz> (raw)
In-Reply-To: <07DD5AA3-1575-4DD6-8EA8-9B733AAE4D2C@gmail.com>

Hi,

On Fri, Feb 03 2023, Bernhard Reutner-Fischer wrote:
> On 3 February 2023 12:35:32 CET, Richard Biener via Gcc-patches
>>
>>I think it's OK as-is given this explanation.
>>
>
> s/derefernce/dereference/
>

Thanks for noticing.  I am about to commit the following as an obvious
fix.

Martin


A fix to a typo spotted by Bernhard Reutner-Fischer.  Tested by
building the compiler with the fix.

gcc/ChangeLog:

2023-02-06  Martin Jambor  <mjambor@suse.cz>

	* ipa-sra.cc (adjust_parameter_descriptions): Fix a typo in a dump.
---
 gcc/ipa-sra.cc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gcc/ipa-sra.cc b/gcc/ipa-sra.cc
index 7a2b4dc8608..0495f446bf4 100644
--- a/gcc/ipa-sra.cc
+++ b/gcc/ipa-sra.cc
@@ -4249,8 +4249,8 @@ adjust_parameter_descriptions (cgraph_node *node, isra_func_summary *ifs)
 
   dump_list_of_param_indices (node, "are dead on arrival or have a type "
 			      "mismatch with IPA-CP", dump_dead_indices);
-  dump_list_of_param_indices (node, "are not safe to derefernce in all callers",
-			      dump_bad_cond_indices);
+  dump_list_of_param_indices (node, "are not safe to dereference in all "
+			      "callers", dump_bad_cond_indices);
 
   return ret;
 }
-- 
2.39.0



      reply	other threads:[~2023-02-06 14:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-02 16:19 Martin Jambor
2023-02-03  7:30 ` Richard Biener
2023-02-03  9:40   ` Martin Jambor
2023-02-03 11:35     ` Richard Biener
2023-02-03 16:49       ` Bernhard Reutner-Fischer
2023-02-06 14:16         ` Martin Jambor [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ri6ilgeanh2.fsf@suse.cz \
    --to=mjambor@suse.cz \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=rep.dot.nop@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).