[PATCH, commited] Fortran: remove dead code [PR104321]

[PATCH, commited] Fortran: remove dead code [PR104321]

[Harald Anlauf]

[-- Attachment #1: Type: text/plain, Size: 235 bytes --]

Dear all,

I've committed the attached patch from the PR that removes
a dead code snippet, see discussion.

Regtested originally by Tobias, and reconfirmed on
x86_64-pc-linux-gnu.

Pushed as r13-6862-gb5fce899dbbd72 .

Thanks,
Harald


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: pr104321.diff --]
[-- Type: text/x-patch, Size: 1115 bytes --]

From b5fce899dbbd7246d003209b2fe3b04f8738dddd Mon Sep 17 00:00:00 2001
From: Harald Anlauf <anlauf@gmx.de>
Date: Sat, 25 Mar 2023 19:59:45 +0100
Subject: [PATCH] Fortran: remove dead code [PR104321]

gcc/fortran/ChangeLog:

	PR fortran/104321
	* trans-decl.cc (gfc_conv_cfi_to_gfc): Remove dead code.
---
 gcc/fortran/trans-decl.cc | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/gcc/fortran/trans-decl.cc b/gcc/fortran/trans-decl.cc
index 77610df340b..25737881ae0 100644
--- a/gcc/fortran/trans-decl.cc
+++ b/gcc/fortran/trans-decl.cc
@@ -7165,9 +7165,6 @@ gfc_conv_cfi_to_gfc (stmtblock_t *init, stmtblock_t *finally,
 			   size_var, LT_EXPR, build_int_cst (TREE_TYPE (idx), 1),
 			   gfc_finish_block (&loop_body));
       /* if (cond) { block2 }  */
-      tmp = fold_build2_loc (input_location, MODIFY_EXPR, void_type_node,
-			     data, fold_convert (TREE_TYPE (data),
-						 null_pointer_node));
       tmp = build3_v (COND_EXPR, cond_var, gfc_finish_block (&block2),
 		      build_empty_stmt (input_location));
       gfc_add_expr_to_block (&block, tmp);
--
2.35.3

Re: [PATCH, commited] Fortran: remove dead code [PR104321]

[Paul Richard Thomas]

[-- Attachment #1: Type: text/plain, Size: 578 bytes --]

Hi Harald,

If you will excuse the British cultural reference, that's a Norwegian Blue
alright! Good spot.

OK for mainline.

Thanks

Paul


On Sat, 25 Mar 2023 at 19:13, Harald Anlauf via Fortran <fortran@gcc.gnu.org>
wrote:

> Dear all,
>
> I've committed the attached patch from the PR that removes
> a dead code snippet, see discussion.
>
> Regtested originally by Tobias, and reconfirmed on
> x86_64-pc-linux-gnu.
>
> Pushed as r13-6862-gb5fce899dbbd72 .
>
> Thanks,
> Harald
>
>

-- 
"If you can't explain it simply, you don't understand it well enough" -
Albert Einstein

Re: [PATCH, commited] Fortran: remove dead code [PR104321]

[Harald Anlauf]

Hi Paul,
 
> If you will excuse the British cultural reference, that's a Norwegian Blue alright! Good spot.
 
ROTFL!

I first had to look up the "Norwegian Blue", and then I remembered.  :)

You're bringing back the fun to gfortran hacking!

Cheers,
Harald
  

On Sat, 25 Mar 2023 at 19:13, Harald Anlauf via Fortran <fortran@gcc.gnu.org[mailto:fortran@gcc.gnu.org]> wrote:Dear all,

I've committed the attached patch from the PR that removes
a dead code snippet, see discussion.

Regtested originally by Tobias, and reconfirmed on
x86_64-pc-linux-gnu.

Pushed as r13-6862-gb5fce899dbbd72 .

Thanks,
Harald
  
 --
"If you can't explain it simply, you don't understand it well enough" - Albert Einstein

Re: [PATCH, commited] Fortran: remove dead code [PR104321]

[Thomas Koenig]

On 26.03.23 08:52, Paul Richard Thomas via Fortran wrote:
> If you will excuse the British cultural reference, that's a Norwegian Blue
> alright! Good spot.

Still pining for the fjords, I gather?