* [PATCH] Fortran: frontend passes do_subscript leaks gmp memory [PR97345]
@ 2023-01-10 21:56 Harald Anlauf
0 siblings, 0 replies; only message in thread
From: Harald Anlauf @ 2023-01-10 21:56 UTC (permalink / raw)
To: fortran, gcc-patches
[-- Attachment #1: Type: text/plain, Size: 404 bytes --]
Dear all,
the attached obvious patch fixes a memory leak with gmp variables
that are set but apparently (=valgrind) never cleared. No new
testcase as the current testsuite gives enough coverage
(confirmed by trying a faulty version...) and as per discussion
with Steve (see PR).
Committed after regtesting on x86_64-pc-linux-gnu as:
r13-5095-gfec9fc1a17ec44461cee841513f1b6b8ad680fe4
Thanks,
Harald
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: pr97345.diff --]
[-- Type: text/x-patch, Size: 1291 bytes --]
From fec9fc1a17ec44461cee841513f1b6b8ad680fe4 Mon Sep 17 00:00:00 2001
From: Harald Anlauf <anlauf@gmx.de>
Date: Tue, 10 Jan 2023 22:41:17 +0100
Subject: [PATCH] Fortran: frontend passes do_subscript leaks gmp memory
[PR97345]
gcc/fortran/ChangeLog:
PR fortran/97345
* frontend-passes.cc (do_subscript): Clear used gmp variables.
---
gcc/fortran/frontend-passes.cc | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/gcc/fortran/frontend-passes.cc b/gcc/fortran/frontend-passes.cc
index 612c12d233d..db2b98290d6 100644
--- a/gcc/fortran/frontend-passes.cc
+++ b/gcc/fortran/frontend-passes.cc
@@ -2892,7 +2892,12 @@ do_subscript (gfc_expr **e)
cmp = mpz_cmp (do_end, do_start);
if ((sgn > 0 && cmp < 0) || (sgn < 0 && cmp > 0))
- break;
+ {
+ mpz_clear (do_start);
+ mpz_clear (do_end);
+ mpz_clear (do_step);
+ break;
+ }
}
/* May have to correct the end value if the step does not equal
@@ -2965,6 +2970,12 @@ do_subscript (gfc_expr **e)
mpz_clear (val);
}
}
+
+ if (have_do_start)
+ mpz_clear (do_start);
+ if (have_do_end)
+ mpz_clear (do_end);
+ mpz_clear (do_step);
}
}
}
--
2.35.3
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-01-10 21:56 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-10 21:56 [PATCH] Fortran: frontend passes do_subscript leaks gmp memory [PR97345] Harald Anlauf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).