From: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
To: "Jørgen Kvalsvik" <j@lambda.is>
Cc: Jan Hubicka <hubicka@ucw.cz>,
gcc-patches@gcc.gnu.org, richard.guenther@gmail.com
Subject: Re: [PATCH v10 1/2] Add condition coverage (MC/DC)
Date: Mon, 15 Apr 2024 13:18:54 +0200 [thread overview]
Message-ID: <ydd34rmdgbl.fsf@CeBiTec.Uni-Bielefeld.DE> (raw)
In-Reply-To: <8c5c6825-38ef-4dd3-b225-ddbec9eba3f6@lambda.is> (=?utf-8?Q?=22J=C3=B8rgen?= Kvalsvik"'s message of "Mon, 15 Apr 2024 11:39:21 +0200")
Hi Jørgen,
>> the new gcc.misc-tests/gcov-22.c test loops on SPARC (both Solaris and
>> Linux). I've filed PR gcov-profile/114720 for this, but couldn't find
>> any bugzilla account of yours to Cc:
>> Rainer
>>
>
> Rainer,
>
> Could you please try this patch? I don't have a sparc nor non-glibc build
> (and getting a virtual one up will take a while). I suppose the problem is
given that the test also FAILs on Linux/sparc64, it's not a
glibc-vs-non-glibc issue.
FWIW, there are both Solaris/SPARC and Linux/sparc64 systems available
in the cfarm; no need to build one yourself. But fully agreed, running
a full bootstrap to verify a single testcase is a bit much if it can be
done more easily ;-)
> that after longjmp the return address is to the call to setdest(), not
> jump() (like is assumed), which creates the loop. If so, just guarding the
> longjmp should be fine, the point of the test is to make sure that both
> branches can be taken and recorded when the cond is a setjmp. If it works I
> will document it and post the patch.
I've just tried the patch on both sparc-sun-solaris2.11 and
i386-pc-solaris2.11 and the test now PASSes on both.
Thanks.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
next prev parent reply other threads:[~2024-04-15 11:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-23 11:17 Jørgen Kvalsvik
2024-02-23 11:18 ` [PATCH v10 2/2] Add gcov MC/DC tests for GDC Jørgen Kvalsvik
2024-02-23 11:44 ` Iain Buclaw
2024-04-05 8:34 ` [PATCH] testsuite: Fix up error on gcov1.d Jakub Jelinek
2024-04-05 8:57 ` Richard Biener
2024-03-12 20:40 ` Ping [PATCH v10 1/2] Add condition coverage (MC/DC) Jørgen Kvalsvik
2024-03-21 12:23 ` Ping^2 " Jørgen Kvalsvik
2024-04-03 7:32 ` Ping^3 " Jørgen Kvalsvik
2024-04-04 12:10 ` Jan Hubicka
2024-04-04 12:54 ` Jørgen Kvalsvik
2024-04-04 13:56 ` Jan Hubicka
2024-04-05 13:00 ` Rainer Orth
2024-04-05 13:34 ` Jørgen Kvalsvik
2024-04-05 14:03 ` H.J. Lu
2024-04-15 8:53 ` Rainer Orth
2024-04-15 9:03 ` Jørgen Kvalsvik
2024-04-15 9:39 ` Jørgen Kvalsvik
2024-04-15 11:18 ` Rainer Orth [this message]
2024-04-15 11:34 ` Jørgen Kvalsvik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ydd34rmdgbl.fsf@CeBiTec.Uni-Bielefeld.DE \
--to=ro@cebitec.uni-bielefeld.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=hubicka@ucw.cz \
--cc=j@lambda.is \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).