From: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
To: Richard Biener via Gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] lto-plugin: use locking only for selected targets
Date: Thu, 07 Jul 2022 13:52:16 +0200 [thread overview]
Message-ID: <yddlet5b0nj.fsf@CeBiTec.Uni-Bielefeld.DE> (raw)
In-Reply-To: <CAFiYyc0YJLmAm3Z5+-tvu6xOGVdu7uGE0qrh=Hj50MuARjFfXg@mail.gmail.com> (Richard Biener via Gcc-patches's message of "Thu, 7 Jul 2022 13:46:55 +0200")
Richard Biener via Gcc-patches <gcc-patches@gcc.gnu.org> writes:
>> +if test x$use_locking = xyes; then
>> + AC_DEFINE(HAVE_PTHREAD_LOCKING, 1,
>> + [Define if the system-provided pthread locking mechanism.])
This isn't even a sentence. At least I cannot parse it. Besides, it
seems to be misnamed since the test doesn't check if pthread_mutex_lock
and friends are present on the target, but if they should be used.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
next prev parent reply other threads:[~2022-07-07 11:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-04 11:32 [PATCH] lto-plugin: Add path to libatomic for riscv64 Martin Liška
2022-07-04 12:28 ` Richard Biener
2022-07-04 12:28 ` Richard Biener
2022-07-04 13:09 ` Martin Liška
2022-07-05 7:27 ` Richard Biener
2022-07-07 11:43 ` [PATCH] lto-plugin: use locking only for selected targets Martin Liška
2022-07-07 11:46 ` Richard Biener
2022-07-07 11:52 ` Rainer Orth [this message]
2022-07-07 13:18 ` Martin Liška
2022-07-07 13:18 ` Martin Liška
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yddlet5b0nj.fsf@CeBiTec.Uni-Bielefeld.DE \
--to=ro@cebitec.uni-bielefeld.de \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).