public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH] testsuite: Fix gcc.dg/vect/vect-fmax-1.c etc. on SPARC [PR104756]
@ 2023-01-23 10:38 Rainer Orth
  2023-01-23 12:41 ` Richard Biener
  0 siblings, 1 reply; 2+ messages in thread
From: Rainer Orth @ 2023-01-23 10:38 UTC (permalink / raw)
  To: gcc-patches; +Cc: Richard Sandiford

[-- Attachment #1: Type: text/plain, Size: 1953 bytes --]

The gcc.dg/vect/vect-fmax-?.c etc. tests FAIL on 32 and 64-bit SPARC:

FAIL: gcc.dg/vect/vect-fmax-1.c -flto -ffat-lto-objects  scan-tree-dump vect "Detected reduction"
FAIL: gcc.dg/vect/vect-fmax-1.c scan-tree-dump vect "Detected reduction"
FAIL: gcc.dg/vect/vect-fmax-2.c -flto -ffat-lto-objects  scan-tree-dump vect "Detected reduction"
FAIL: gcc.dg/vect/vect-fmax-2.c scan-tree-dump vect "Detected reduction"
FAIL: gcc.dg/vect/vect-fmax-3.c -flto -ffat-lto-objects  scan-tree-dump vect "Detected reduction"
FAIL: gcc.dg/vect/vect-fmax-3.c scan-tree-dump vect "Detected reduction"
FAIL: gcc.dg/vect/vect-fmin-1.c -flto -ffat-lto-objects  scan-tree-dump vect "Detected reduction"
FAIL: gcc.dg/vect/vect-fmin-1.c -flto -ffat-lto-objects  scan-tree-dump vect "Detected reduction"
FAIL: gcc.dg/vect/vect-fmin-1.c scan-tree-dump vect "Detected reduction"
FAIL: gcc.dg/vect/vect-fmin-1.c scan-tree-dump vect "Detected reduction"
FAIL: gcc.dg/vect/vect-fmin-2.c -flto -ffat-lto-objects  scan-tree-dump vect "Detected reduction"
FAIL: gcc.dg/vect/vect-fmin-2.c scan-tree-dump vect "Detected reduction"
FAIL: gcc.dg/vect/vect-fmin-3.c -flto -ffat-lto-objects  scan-tree-dump vect "Detected reduction"
FAIL: gcc.dg/vect/vect-fmin-3.c scan-tree-dump vect "Detected reduction"

As discussed in the PR, they require vect_float support, but the tests
don't declare it.

This patch fixes this.

Tested on sparc-sun-solaris2.11 and i386-pc-solaris2.11.

Ok for trunk?

	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University


2023-01-20  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

	gcc/testsuite:
	PR testsuite/104756
	* gcc.dg/vect/vect-fmax-1.c: Require vect_float.
	* gcc.dg/vect/vect-fmax-2.c: Likewise.
	* gcc.dg/vect/vect-fmax-3.c: Likewise.
	* gcc.dg/vect/vect-fmin-1.c: Likewise.
	* gcc.dg/vect/vect-fmin-2.c: Likewise.
	* gcc.dg/vect/vect-fmin-3.c: Likewise.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: sparc-testsuite-pr104756.patch --]
[-- Type: text/x-patch, Size: 1971 bytes --]

# HG changeset patch
# Parent  32612dd0fa89c5184649a574bec1c462dd63061a
testsuite: Fix gcc.dg/vect/vect-fmax-1.c etc. on SPARC [PR104756]

diff --git a/gcc/testsuite/gcc.dg/vect/vect-fmax-1.c b/gcc/testsuite/gcc.dg/vect/vect-fmax-1.c
--- a/gcc/testsuite/gcc.dg/vect/vect-fmax-1.c
+++ b/gcc/testsuite/gcc.dg/vect/vect-fmax-1.c
@@ -1,3 +1,5 @@
+/* { dg-require-effective-target vect_float } */
+
 #include "tree-vect.h"
 
 #ifndef TYPE
diff --git a/gcc/testsuite/gcc.dg/vect/vect-fmax-2.c b/gcc/testsuite/gcc.dg/vect/vect-fmax-2.c
--- a/gcc/testsuite/gcc.dg/vect/vect-fmax-2.c
+++ b/gcc/testsuite/gcc.dg/vect/vect-fmax-2.c
@@ -1,3 +1,5 @@
+/* { dg-require-effective-target vect_float } */
+
 #define TYPE double
 #define FN __builtin_fmax
 
diff --git a/gcc/testsuite/gcc.dg/vect/vect-fmax-3.c b/gcc/testsuite/gcc.dg/vect/vect-fmax-3.c
--- a/gcc/testsuite/gcc.dg/vect/vect-fmax-3.c
+++ b/gcc/testsuite/gcc.dg/vect/vect-fmax-3.c
@@ -1,3 +1,5 @@
+/* { dg-require-effective-target vect_float } */
+
 #include "tree-vect.h"
 
 void __attribute__((noipa))
diff --git a/gcc/testsuite/gcc.dg/vect/vect-fmin-1.c b/gcc/testsuite/gcc.dg/vect/vect-fmin-1.c
--- a/gcc/testsuite/gcc.dg/vect/vect-fmin-1.c
+++ b/gcc/testsuite/gcc.dg/vect/vect-fmin-1.c
@@ -1,3 +1,5 @@
+/* { dg-require-effective-target vect_float } */
+
 #include "tree-vect.h"
 
 #ifndef TYPE
diff --git a/gcc/testsuite/gcc.dg/vect/vect-fmin-2.c b/gcc/testsuite/gcc.dg/vect/vect-fmin-2.c
--- a/gcc/testsuite/gcc.dg/vect/vect-fmin-2.c
+++ b/gcc/testsuite/gcc.dg/vect/vect-fmin-2.c
@@ -1,3 +1,5 @@
+/* { dg-require-effective-target vect_float } */
+
 #ifndef TYPE
 #define TYPE double
 #define FN __builtin_fmin
diff --git a/gcc/testsuite/gcc.dg/vect/vect-fmin-3.c b/gcc/testsuite/gcc.dg/vect/vect-fmin-3.c
--- a/gcc/testsuite/gcc.dg/vect/vect-fmin-3.c
+++ b/gcc/testsuite/gcc.dg/vect/vect-fmin-3.c
@@ -1,3 +1,5 @@
+/* { dg-require-effective-target vect_float } */
+
 #include "tree-vect.h"
 
 void __attribute__((noipa))

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] testsuite: Fix gcc.dg/vect/vect-fmax-1.c etc. on SPARC [PR104756]
  2023-01-23 10:38 [PATCH] testsuite: Fix gcc.dg/vect/vect-fmax-1.c etc. on SPARC [PR104756] Rainer Orth
@ 2023-01-23 12:41 ` Richard Biener
  0 siblings, 0 replies; 2+ messages in thread
From: Richard Biener @ 2023-01-23 12:41 UTC (permalink / raw)
  To: Rainer Orth; +Cc: gcc-patches, Richard Sandiford

On Mon, Jan 23, 2023 at 11:39 AM Rainer Orth
<ro@cebitec.uni-bielefeld.de> wrote:
>
> The gcc.dg/vect/vect-fmax-?.c etc. tests FAIL on 32 and 64-bit SPARC:
>
> FAIL: gcc.dg/vect/vect-fmax-1.c -flto -ffat-lto-objects  scan-tree-dump vect "Detected reduction"
> FAIL: gcc.dg/vect/vect-fmax-1.c scan-tree-dump vect "Detected reduction"
> FAIL: gcc.dg/vect/vect-fmax-2.c -flto -ffat-lto-objects  scan-tree-dump vect "Detected reduction"
> FAIL: gcc.dg/vect/vect-fmax-2.c scan-tree-dump vect "Detected reduction"
> FAIL: gcc.dg/vect/vect-fmax-3.c -flto -ffat-lto-objects  scan-tree-dump vect "Detected reduction"
> FAIL: gcc.dg/vect/vect-fmax-3.c scan-tree-dump vect "Detected reduction"
> FAIL: gcc.dg/vect/vect-fmin-1.c -flto -ffat-lto-objects  scan-tree-dump vect "Detected reduction"
> FAIL: gcc.dg/vect/vect-fmin-1.c -flto -ffat-lto-objects  scan-tree-dump vect "Detected reduction"
> FAIL: gcc.dg/vect/vect-fmin-1.c scan-tree-dump vect "Detected reduction"
> FAIL: gcc.dg/vect/vect-fmin-1.c scan-tree-dump vect "Detected reduction"
> FAIL: gcc.dg/vect/vect-fmin-2.c -flto -ffat-lto-objects  scan-tree-dump vect "Detected reduction"
> FAIL: gcc.dg/vect/vect-fmin-2.c scan-tree-dump vect "Detected reduction"
> FAIL: gcc.dg/vect/vect-fmin-3.c -flto -ffat-lto-objects  scan-tree-dump vect "Detected reduction"
> FAIL: gcc.dg/vect/vect-fmin-3.c scan-tree-dump vect "Detected reduction"
>
> As discussed in the PR, they require vect_float support, but the tests
> don't declare it.
>
> This patch fixes this.
>
> Tested on sparc-sun-solaris2.11 and i386-pc-solaris2.11.
>
> Ok for trunk?

OK.

>         Rainer
>
> --
> -----------------------------------------------------------------------------
> Rainer Orth, Center for Biotechnology, Bielefeld University
>
>
> 2023-01-20  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
>
>         gcc/testsuite:
>         PR testsuite/104756
>         * gcc.dg/vect/vect-fmax-1.c: Require vect_float.
>         * gcc.dg/vect/vect-fmax-2.c: Likewise.
>         * gcc.dg/vect/vect-fmax-3.c: Likewise.
>         * gcc.dg/vect/vect-fmin-1.c: Likewise.
>         * gcc.dg/vect/vect-fmin-2.c: Likewise.
>         * gcc.dg/vect/vect-fmin-3.c: Likewise.
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-01-23 12:41 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-23 10:38 [PATCH] testsuite: Fix gcc.dg/vect/vect-fmax-1.c etc. on SPARC [PR104756] Rainer Orth
2023-01-23 12:41 ` Richard Biener

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).