public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [COMMITTED] contrib: Fix make_sunver.pl warning
@ 2023-02-17 12:34 Rainer Orth
  0 siblings, 0 replies; only message in thread
From: Rainer Orth @ 2023-02-17 12:34 UTC (permalink / raw)
  To: gcc-patches; +Cc: Petr Sumbera

[-- Attachment #1: Type: text/plain, Size: 750 bytes --]

Petr informed me that perl 5.32 bundled with Solaris 11.4 warns about
make_sunver.pl:

Unescaped left brace in regex is passed through in regex; marked by <-- HERE in m/^([ \t]*){ <-- HERE $/ at /vol/gcc/src/hg/master/local/libgomp/../contrib/make_sunver.pl line 216.

I didn't notice since I'm using a common installation of perl 5.12
across Solaris versions that doesn't show that warning.

His patch fixes the issue.  Tested on Solaris 11.3 (perl 5.12) and 11.4
(perl 5.32).

Committed to trunk.

	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University


2023-01-20  Petr Sumbera  <petr.sumbera@oracle.com>

	contrib:
	* make_sunver.pl: Escape brace.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: sol2-contrib-make_sunver.patch --]
[-- Type: text/x-patch, Size: 438 bytes --]

# HG changeset patch
# Parent  a9c533b97d6828dce4fa8418864a1fa65f5c46b3
contrib: Fix make_sunver.pl warning

diff --git a/contrib/make_sunver.pl b/contrib/make_sunver.pl
--- a/contrib/make_sunver.pl
+++ b/contrib/make_sunver.pl
@@ -213,7 +213,7 @@ while (<F>) {
     if (/^[ \t]*$/) { print; next; }
 
     # Lines of the form '{'
-    if (/^([ \t]*){$/) {
+    if (/^([ \t]*)\{$/) {
 	if ($in_extern) {
 	    print "$1##{\n";
 	} else {

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-02-17 12:34 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-17 12:34 [COMMITTED] contrib: Fix make_sunver.pl warning Rainer Orth

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).