java/1126: gcjh needs to output space before leading "::" with JArray's

java/1126: gcjh needs to output space before leading "::" with JArray's

[paul]

>Number:         1126
>Category:       java
>Synopsis:       gcjh needs to output space before leading "::" with JArray's
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    tromey
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Dec 20 12:06:20 PST 2000
>Closed-Date:    Sat Dec 25 09:41:37 PST 1999
>Last-Modified:  Sat Dec 25 09:50:00 PST 1999
>Originator:     Paul Reilly
>Release:        gcjh (2.96 19991130 (experimental))
>Organization:
>Environment:

>Description:
gcjh adds a leading "::" to the template class type
when outputing JArray's so that the right namespace will
be used.  The problem with something like 
JArray(::java::lang::String *) is that "<:" is an 
"alternative token representation" for '[' according to
"g++ -dy".  Martin v. Loewis suggested putting a space before
the "::".  I tried this and it works.
>How-To-Repeat:

>Fix:
I think the only change that is needed to gcjh is to 
make line 764 of gjavah.c look like this:

      fputs (" ::", stream);
>Release-Note:

>Audit-Trail:

Formerly PR gcj/119


From: Tom Tromey <tromey@cygnus.com>
To: paul@pajato.com
Cc: java-gnats@sourceware.cygnus.com
Subject: Re: gcj/119: gcjh needs to output space before leading "::" with JArray's
Date: Mon, 13 Dec 1999 07:39:57 -0800 (PST)

 Hi, thanks for the bug report.
 I can't reproduce this bug.  For me, gcjh never prints JArray<::...>.
 My reading of the code is that the leading "::" is never generated in
 the case where decode_signature_piece is processing an array.
 
 Can you send me a simple (standalone) Java source file that
 demonstrates the bug?  That would help a lot.  Otherwise, I am going
 to close the PR.
 
 Tom
Responsible-Changed-From-To: apbianco->tromey
Responsible-Changed-By: tromey
Responsible-Changed-When: Fri Dec 17 12:24:41 1999
Responsible-Changed-Why:
    I fixed it.
State-Changed-From-To: open->feedback
State-Changed-By: tromey
State-Changed-When: Fri Dec 17 12:24:41 1999
State-Changed-Why:
    I've checked in a fix for this.
    Now gjavah generates JArray< ::java::blah::blah>.
    Please try it out and get back to me.
    If you can't try it out, tell me and I'll close the PR

From: tromey@cygnus.com
To: apbianco@cygnus.com, java-gnats@sourceware.cygnus.com, paul@pajato.com,
  tromey@cygnus.com
Cc:  
Subject: Re: gcj/119
Date: 17 Dec 1999 20:24:41 -0000

 Synopsis: gcjh needs to output space before leading "::" with JArray's
 
 Responsible-Changed-From-To: apbianco->tromey
 Responsible-Changed-By: tromey
 Responsible-Changed-When: Fri Dec 17 12:24:41 1999
 Responsible-Changed-Why:
     I fixed it.
 State-Changed-From-To: open->feedback
 State-Changed-By: tromey
 State-Changed-When: Fri Dec 17 12:24:41 1999
 State-Changed-Why:
     I've checked in a fix for this.
     Now gjavah generates JArray< ::java::blah::blah>.
     Please try it out and get back to me.
     If you can't try it out, tell me and I'll close the PR
 
 http://sourceware.cygnus.com/cgi-bin/gnatsweb.pl?cmd=view&pr=119&database=java

From: Paul Reilly <preilly@allaire.com>
To: apbianco@cygnus.com, java-gnats@sourceware.cygnus.com, tromey@cygnus.com
Cc:  
Subject: Re: gcj/119
Date: 25 Dec 1999 05:47:53 -0500

 tromey@cygnus.com writes:
 
 >     I've checked in a fix for this.
 >     Now gjavah generates JArray< ::java::blah::blah>.
 >     Please try it out and get back to me.
 >     If you can't try it out, tell me and I'll close the PR
 
 Works great.  Thanks.
 
 -Paul
State-Changed-From-To: feedback->closed
State-Changed-By: tromey
State-Changed-When: Sat Dec 25 09:41:37 1999
State-Changed-Why:
    Reported as working.

From: tromey@cygnus.com
To: java-gnats@sourceware.cygnus.com, paul@pajato.com, tromey@cygnus.com
Cc:  
Subject: Re: gcj/119
Date: 25 Dec 1999 17:41:37 -0000

 Synopsis: gcjh needs to output space before leading "::" with JArray's
 
 State-Changed-From-To: feedback->closed
 State-Changed-By: tromey
 State-Changed-When: Sat Dec 25 09:41:37 1999
 State-Changed-Why:
     Reported as working.
 
 http://sourceware.cygnus.com/cgi-bin/gnatsweb.pl?cmd=view&pr=119&database=java
>Unformatted: