java/1264: Zipfile lossage on non-Unix systems

java/1264: Zipfile lossage on non-Unix systems

[zastai]

>Number:         1264
>Category:       java
>Synopsis:       Zipfile lossage on non-Unix systems
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    tromey
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Dec 20 12:18:28 PST 2000
>Closed-Date:    Tue May 30 08:05:49 PDT 2000
>Last-Modified:  Tue May 30 08:16:00 PDT 2000
>Originator:     zastai@hotmail.com
>Release:        gcj-2.95.2
>Organization:
>Environment:
i386-pc-msdosdjgpp
>Description:
 * ZIP support is broken (at least for ZIP files created
    with zip 2.3).
   Solution: lseek to zipd->filestart - 4 in open_in_zip
    (jcf-io.c).
   This _may_ be the result of having local extra fields
    in the zipfile (my version stores UTC modification
    time), but I doubt it.
   This _may_ be the result of zipfiles having different-
    sized headers on different platforms (ie Unix-based,
    DOS-based, OS/2-based and VMS-based zipfiles are all
    handled by zip, but might have different header sizes.
    This seems the most likely cause.
>How-To-Repeat:
Try to have gcj find classes in a zipfile that originated on MSDOS.
>Fix:
Offset seeks in zipfile; offset used may be dependent on the OS the zipfile originated on.
>Release-Note:

>Audit-Trail:

Formerly PR gcj/246


From: Tom Tromey <tromey@cygnus.com>
To: zastai@hotmail.com
Cc: java-gnats@sourceware.cygnus.com
Subject: Re: gcj/246: Zipfile lossage on non-Unix systems
Date: Fri, 26 May 2000 09:51:08 -0700 (PDT)

 >>>>> ">" == zastai  <zastai@hotmail.com> writes:
 
 >>  * ZIP support is broken (at least for ZIP files created
 >>     with zip 2.3).
 
 It is possible that this bug was already fixed.
 The zip-reading code in gcj had a bug.
 
 This is the gcc patch I'm thinking of:
 
 2000-04-26  Tom Tromey  <tromey@cygnus.com>
 
 	* zextract.c (find_zip_file_start): New function.
 	(read_zip_archive): Use it.
 
 
 Could you try this somehow?
 If not, could you send a *minimal* zip file that shows the problem?
 Please encode it in some reasonable way, and please CC java-gnats
 (currently CCd) so that the file ends up in the PR.
 
 Thanks,
 Tom
Responsible-Changed-From-To: apbianco->tromey
Responsible-Changed-By: tromey
Responsible-Changed-When: Tue May 30 08:05:49 2000
Responsible-Changed-Why:
    Mine
State-Changed-From-To: open->closed
State-Changed-By: tromey
State-Changed-When: Tue May 30 08:05:49 2000
State-Changed-Why:
    Reported as fixed

From: tromey@cygnus.com
To: apbianco@cygnus.com, java-gnats@sourceware.cygnus.com, tromey@cygnus.com,
  zastai@hotmail.com
Cc:  
Subject: Re: gcj/246
Date: 30 May 2000 15:05:49 -0000

 Synopsis: Zipfile lossage on non-Unix systems
 
 Responsible-Changed-From-To: apbianco->tromey
 Responsible-Changed-By: tromey
 Responsible-Changed-When: Tue May 30 08:05:49 2000
 Responsible-Changed-Why:
     Mine
 State-Changed-From-To: open->closed
 State-Changed-By: tromey
 State-Changed-When: Tue May 30 08:05:49 2000
 State-Changed-Why:
     Reported as fixed
 
 http://sourceware.cygnus.com/cgi-bin/gnatsweb.pl?cmd=view&pr=246&database=java
>Unformatted: