public inbox for gcc-prs@sourceware.org help / color / mirror / Atom feed
From: Benjamin Kosnik <bkoz@redhat.com> To: pme@gcc.gnu.org Cc: gcc-prs@gcc.gnu.org Subject: Re: libstdc++/2071 Date: Tue, 12 Jun 2001 13:26:00 -0000 [thread overview] Message-ID: <20010612202603.11524.qmail@sourceware.cygnus.com> (raw) The following reply was made to PR libstdc++/2071; it has been noted by GNATS. From: Benjamin Kosnik <bkoz@redhat.com> To: rittle@labs.mot.com Cc: mark@codesourcery.com, gcc-gnats@gcc.gnu.org, pedwards@disaster.jaj.com Subject: Re: libstdc++/2071 Date: Tue, 12 Jun 2001 13:24:28 -0700 (PDT) > No, you are not an idiot! I can believe that you found another > (hopefully, minor) independent bug with the library. However, in both > Solaris and FreeBSD (the two platforms known to have the interactive > and/or pipe-based cin bug explained in libstdc++/2071), we find: > > ; grep SEEK_ /usr/include/stdio.h|grep define > #define SEEK_SET 0 > #define SEEK_CUR 1 > #define SEEK_END 2 > > In include/bits/ios_base.h, we fine: > > static const seekdir beg = seekdir(0); > static const seekdir cur = seekdir(SEEK_CUR); > static const seekdir end = seekdir(SEEK_END); > > For maximal portability, I might recommend that we patch the first > line to read as follows (but in practice, I'm not sure it matters at > all since I have never seen a libc define SEEK_SET any other way): Yup. Now that I've had some sleep, I can see that this is an non-issue. The standard mandates beg as 0, so we are actually correct as is, without any additional patching. Thanks for the sanity check. benjamin
next reply other threads:[~2001-06-12 13:26 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2001-06-12 13:26 Benjamin Kosnik [this message] -- strict thread matches above, loose matches on Subject: below -- 2001-06-12 16:36 libstdc++/2071 Phil Edwards 2001-06-12 16:26 libstdc++/2071 Loren James Rittle 2001-06-12 2:06 libstdc++/2071 Mark Mitchell 2001-06-12 1:56 libstdc++/2071 Loren James Rittle 2001-06-11 19:06 libstdc++/2071 Benjamin Kosnik 2001-06-05 13:16 libstdc++/2071 pme
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20010612202603.11524.qmail@sourceware.cygnus.com \ --to=bkoz@redhat.com \ --cc=gcc-prs@gcc.gnu.org \ --cc=pme@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).