Re: libgcj/3499: Calendar return GMT in non-GMT timezone, such as JST-9

Re: libgcj/3499: Calendar return GMT in non-GMT timezone, such as JST-9

[tromey]

Synopsis: Calendar return GMT in non-GMT timezone, such as JST-9

Responsible-Changed-From-To: unassigned->tromey
Responsible-Changed-By: tromey
Responsible-Changed-When: Sun Jul  1 15:45:06 2001
Responsible-Changed-Why:
    I'm handling this.
State-Changed-From-To: open->closed
State-Changed-By: tromey
State-Changed-When: Sun Jul  1 15:45:06 2001
State-Changed-Why:
    On the gcc trunk we already have a new implementation
    of GregorianCalendar which does not use this code.
    The new implementation is much better.
    I'm closing this PR because I believe this problem is
    fixed with the new code (which, btw, came from Classpath).
    
    If you could try the new code that would be great.
    If not that's ok; you can try it when the trunk is released
    again.
    

http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view&pr=3499&database=gcc

libgcj/3499: Calendar return GMT in non-GMT timezone, such as JST-9

[tjkawa]

>Number:         3499
>Category:       libgcj
>Synopsis:       Calendar return GMT in non-GMT timezone, such as JST-9
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    unassigned
>State:          open
>Class:          wrong-code
>Submitter-Id:   net
>Arrival-Date:   Sat Jun 30 14:06:01 PDT 2001
>Closed-Date:
>Last-Modified:
>Originator:     Tsujikawa Tohru
>Release:        gcc version 3.0
>Organization:
>Environment:
x86, Linux-2.4.5, glibc 2.2.3
>Description:
in libgcj/java/util/natGregorianCalendar.cc, computeFields():

> if (zone->getRawOffset() == 0 || ! zone->useDaylightTime())
>   {
> (suppressed)
>       tim = *(struct tm*) gmtime (&t);
> (suppressed)
>   }
> else
>   {
> (suppressed)
>       tim = *(struct tm*) localtime (&t);
> (suppressed)
> }


I think this should be:

> if (zone->getRawOffset() == 0 || zone->useDaylightTime())

In Japan, timezone is JST-9 and no daylight time.
So, this function returns GMT.
>How-To-Repeat:

>Fix:

>Release-Note:
>Audit-Trail:
>Unformatted: