java/3949: fastjar exits success if @file not found

java/3949: fastjar exits success if @file not found

[pimlott]

>Number:         3949
>Category:       java
>Synopsis:       fastjar exits success if @file not found
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    unassigned
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Aug 06 08:16:00 PDT 2001
>Closed-Date:
>Last-Modified:
>Originator:     Andrew Pimlott
>Release:        gcc 3.0
>Organization:
>Environment:

>Description:
When fastjar can't find the file specified by @file, it
reports an error but exits with status 0.
>How-To-Repeat:
fastjar -cf out.jar @no_such_file; echo $?
>Fix:

>Release-Note:
>Audit-Trail:
>Unformatted:

Re: java/3949: fastjar exits success if @file not found

[apbianco]

Synopsis: fastjar exits success if @file not found

State-Changed-From-To: feedback->closed
State-Changed-By: apbianco
State-Changed-When: Tue Aug 28 18:34:59 2001
State-Changed-Why:
    I checked the patch in:
    
      http://gcc.gnu.org/ml/gcc-patches/2001-08/msg01641.html
    

http://sources.redhat.com/cgi-bin/gnatsweb.pl?cmd=view&pr=3949&database=gcc

Re: java/3949: fastjar exits success if @file not found

[apbianco]

Synopsis: fastjar exits success if @file not found

Responsible-Changed-From-To: unassigned->apbianco
Responsible-Changed-By: apbianco
Responsible-Changed-When: Wed Aug 15 13:59:05 2001
Responsible-Changed-Why:
    Mine.
State-Changed-From-To: open->feedback
State-Changed-By: apbianco
State-Changed-When: Wed Aug 15 13:59:05 2001
State-Changed-Why:
    A patch has been submitted and will be checked in shortly.

http://sources.redhat.com/cgi-bin/gnatsweb.pl?cmd=view&pr=3949&database=gcc

Re: java/3949: fastjar exits success if @file not found

[Alexandre Petit-Bianco]

The following reply was made to PR java/3949; it has been noted by GNATS.

From: Alexandre Petit-Bianco <apbianco@cygnus.com>
To: pimlott@idiomtech.com
Cc: gcc-gnats@gcc.gnu.org
Subject: Re: java/3949: fastjar exits success if @file not found
Date: Wed, 15 Aug 2001 13:45:20 -0700 (PDT)

 pimlott@idiomtech.com writes:
 
 > however, the report is still a bug, because the problem should be
 > reflected in the exit status.
 
 Thanks. I'll be checking this in shortly.
 
 ./A
 
 2001-08-15  Alexandre Petit-Bianco  <apbianco@redhat.com>
 
         * jartool.c (add_to_jar): Return 1 if stat initialy failed.
         Fixes java/3949.
 
 Index: jartool.c
 ===================================================================
 RCS file: /cvs/gcc/gcc/fastjar/jartool.c,v
 retrieving revision 1.6
 diff -u -p -r1.6 jartool.c
 --- jartool.c   2001/07/04 18:33:53     1.6
 +++ jartool.c   2001/08/15 20:44:15
 @@ -799,6 +799,7 @@ int add_to_jar(int fd, const char *new_d
    
    if(stat_return == -1){
      perror(file);
 +    return 1;
    } else if(S_ISDIR(statbuf.st_mode)){
      char *fullname;
      char *t_ptr;