public inbox for gcc-prs@sourceware.org
help / color / mirror / Atom feed
* libstdc++/4146: input, num_get, regression from 2.95
@ 2001-08-27 11:46 bkoz
0 siblings, 0 replies; 6+ messages in thread
From: bkoz @ 2001-08-27 11:46 UTC (permalink / raw)
To: gcc-gnats; +Cc: wall
>Number: 4146
>Category: libstdc++
>Synopsis: input, num_get, regression from 2.95
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: unassigned
>State: open
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Mon Aug 27 11:46:01 PDT 2001
>Closed-Date:
>Last-Modified:
>Originator: wall@chop.swmed.edu
>Release: gcc-3.x
>Organization:
>Environment:
linux
>Description:
http://gcc.gnu.org/ml/libstdc++/2001-08/msg00191.html
In general, making people wade through 4 files of code to fix a bug is a guarantee of a DOA bug report. If you can simplify this down to one file, or one function, or say 5 lines, your chances of getting it fixed in some sane time schedule go waaaaaaaay up.
That being said, I'll try to look at this in the next month or so.
-benjamin
>How-To-Repeat:
>Fix:
>Release-Note:
>Audit-Trail:
>Unformatted:
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: libstdc++/4146: input, num_get, regression from 2.95
@ 2001-12-05 14:46 bkoz
0 siblings, 0 replies; 6+ messages in thread
From: bkoz @ 2001-12-05 14:46 UTC (permalink / raw)
To: bkoz; +Cc: gcc-prs
The following reply was made to PR libstdc++/4146; it has been noted by GNATS.
From: bkoz@gcc.gnu.org
To: bkoz@gcc.gnu.org, bkoz@gnu.org, gcc-bugs@gcc.gnu.org,
gcc-gnats@gcc.gnu.org, gcc-prs@gcc.gnu.org, wall@chop.swmed.edu
Cc:
Subject: Re: libstdc++/4146: input, num_get, regression from 2.95
Date: 5 Dec 2001 22:35:19 -0000
Synopsis: input, num_get, regression from 2.95
State-Changed-From-To: feedback->closed
State-Changed-By: bkoz
State-Changed-When: Wed Dec 5 14:35:18 2001
State-Changed-Why:
fixed.
http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&pr=4146&database=gcc
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: libstdc++/4146: input, num_get, regression from 2.95
@ 2001-12-05 14:35 bkoz
0 siblings, 0 replies; 6+ messages in thread
From: bkoz @ 2001-12-05 14:35 UTC (permalink / raw)
To: bkoz, bkoz, gcc-bugs, gcc-gnats, gcc-prs, wall
Synopsis: input, num_get, regression from 2.95
State-Changed-From-To: feedback->closed
State-Changed-By: bkoz
State-Changed-When: Wed Dec 5 14:35:18 2001
State-Changed-Why:
fixed.
http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&pr=4146&database=gcc
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: libstdc++/4146: input, num_get, regression from 2.95
@ 2001-11-23 1:53 bkoz
0 siblings, 0 replies; 6+ messages in thread
From: bkoz @ 2001-11-23 1:53 UTC (permalink / raw)
To: bkoz; +Cc: gcc-prs
The following reply was made to PR libstdc++/4146; it has been noted by GNATS.
From: bkoz@gcc.gnu.org
To: bkoz@gcc.gnu.org, bkoz@gnu.org, gcc-bugs@gcc.gnu.org,
gcc-gnats@gcc.gnu.org, gcc-prs@gcc.gnu.org, wall@chop.swmed.edu
Cc:
Subject: Re: libstdc++/4146: input, num_get, regression from 2.95
Date: 1 Dec 2001 02:29:28 -0000
Synopsis: input, num_get, regression from 2.95
State-Changed-From-To: analyzed->feedback
State-Changed-By: bkoz
State-Changed-When: Fri Nov 30 18:29:28 2001
State-Changed-Why:
Hey. I just examined this with current gcc-3.1 head. Sorry for the delay, by the way.
You're right, it was very simple:
in read_pdb_file, the ifstream is opened, read, closed, then re-opened. This is all fine, but the file is reopened without clearing error bits, thus failing to deal with the resulting data.
On line 197 of my copy of these sources:
pdb_file.open(pdb_file_name, std::ios::in);
pdb_file.clear(); // XXX bkoz DR 22 need to clear eofbit.
while (pdb_file >> dummy)
Adding the clear solves the problem....
Anyway. Try this: it should solve your problem.
I noticed that the output file is formatted a bit differently between gcc-2.96 and gcc-3.x:
2.96:
ATOM 2 CA ASN 584 22.622 -18.771 28.061 1.00 30.76
gcc-3.x:
ATOM 1 N ASN 584 23.122 -19.077 26.733 1.00 31.16
Notice the different spacing right before the floating poin type. I believe this is correct:
align (right) << " " // 4 spaces
setwidth (8) << output 6-digit numeric type.
Looks right to me.
Here's hoping this solves your problem.
http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&pr=4146&database=gcc
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: libstdc++/4146: input, num_get, regression from 2.95
@ 2001-11-23 1:46 bkoz
0 siblings, 0 replies; 6+ messages in thread
From: bkoz @ 2001-11-23 1:46 UTC (permalink / raw)
To: bkoz, bkoz, gcc-bugs, gcc-gnats, gcc-prs, wall
Synopsis: input, num_get, regression from 2.95
State-Changed-From-To: analyzed->feedback
State-Changed-By: bkoz
State-Changed-When: Fri Nov 30 18:29:28 2001
State-Changed-Why:
Hey. I just examined this with current gcc-3.1 head. Sorry for the delay, by the way.
You're right, it was very simple:
in read_pdb_file, the ifstream is opened, read, closed, then re-opened. This is all fine, but the file is reopened without clearing error bits, thus failing to deal with the resulting data.
On line 197 of my copy of these sources:
pdb_file.open(pdb_file_name, std::ios::in);
pdb_file.clear(); // XXX bkoz DR 22 need to clear eofbit.
while (pdb_file >> dummy)
Adding the clear solves the problem....
Anyway. Try this: it should solve your problem.
I noticed that the output file is formatted a bit differently between gcc-2.96 and gcc-3.x:
2.96:
ATOM 2 CA ASN 584 22.622 -18.771 28.061 1.00 30.76
gcc-3.x:
ATOM 1 N ASN 584 23.122 -19.077 26.733 1.00 31.16
Notice the different spacing right before the floating poin type. I believe this is correct:
align (right) << " " // 4 spaces
setwidth (8) << output 6-digit numeric type.
Looks right to me.
Here's hoping this solves your problem.
http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&pr=4146&database=gcc
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: libstdc++/4146: input, num_get, regression from 2.95
@ 2001-10-29 10:25 bkoz
0 siblings, 0 replies; 6+ messages in thread
From: bkoz @ 2001-10-29 10:25 UTC (permalink / raw)
To: bkoz, bkoz, gcc-bugs, gcc-prs, nobody, wall
Synopsis: input, num_get, regression from 2.95
Responsible-Changed-From-To: unassigned->bkoz
Responsible-Changed-By: bkoz
Responsible-Changed-When: Mon Oct 29 10:24:58 2001
Responsible-Changed-Why:
This is mine.
State-Changed-From-To: open->analyzed
State-Changed-By: bkoz
State-Changed-When: Mon Oct 29 10:24:58 2001
State-Changed-Why:
This is a bug
http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&pr=4146&database=gcc
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2001-12-05 22:46 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-08-27 11:46 libstdc++/4146: input, num_get, regression from 2.95 bkoz
2001-10-29 10:25 bkoz
2001-11-23 1:46 bkoz
2001-11-23 1:53 bkoz
2001-12-05 14:35 bkoz
2001-12-05 14:46 bkoz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).