public inbox for gcc-prs@sourceware.org
help / color / mirror / Atom feed
* Re: libstdc++/4532: typo in bits/stl_algo.h for partial_sort
@ 2001-10-20 19:06 rodrigc
  0 siblings, 0 replies; 2+ messages in thread
From: rodrigc @ 2001-10-20 19:06 UTC (permalink / raw)
  To: brendan, gcc-bugs, gcc-prs, nobody

Synopsis: typo in bits/stl_algo.h for partial_sort

State-Changed-From-To: open->closed
State-Changed-By: rodrigc
State-Changed-When: Sat Oct 20 19:06:01 2001
State-Changed-Why:
    Patch applied.

http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view&pr=4532&database=gcc


^ permalink raw reply	[flat|nested] 2+ messages in thread

* libstdc++/4532: typo in bits/stl_algo.h for partial_sort
@ 2001-10-11  5:16 brendan
  0 siblings, 0 replies; 2+ messages in thread
From: brendan @ 2001-10-11  5:16 UTC (permalink / raw)
  To: gcc-gnats

>Number:         4532
>Category:       libstdc++
>Synopsis:       typo in bits/stl_algo.h for partial_sort
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    unassigned
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Oct 11 05:16:01 PDT 2001
>Closed-Date:
>Last-Modified:
>Originator:     Brendan Kehoe
>Release:        CVS tree
>Organization:
>Environment:

>Description:
In bits/stl_algo.h, the partial_sort method has the line

__glibcpp_function_requires(_LessThanComparableConcept<_ValueType);

This is missing the closing `>' on the template parameter, which only becomes visible when you turn on concept checks.
>How-To-Repeat:

>Fix:
Change the line to
__glibcpp_function_requires(_LessThanComparableConcept<_ValueType>);

Attached patch makes that change.
>Release-Note:
>Audit-Trail:
>Unformatted:
----gnatsweb-attachment----
Content-Type: text/plain; name="diffs-algo.txt"
Content-Disposition: inline; filename="diffs-algo.txt"

2001-10-04  Brendan Kehoe  <brendan@zen.org>

	* bits/stl_algo.h (partial_sort): Add missing `>' on the
	template parameter _ValueType.


Index: include/bits/stl_algo.h
===================================================================
RCS file: /cvs/gcc/egcs/libstdc++-v3/include/bits/stl_algo.h,v
retrieving revision 1.11
diff -u -p -r1.11 stl_algo.h
--- stl_algo.h	2001/07/20 01:17:13	1.11
+++ stl_algo.h	2001/10/10 11:44:30
@@ -1952,7 +1952,7 @@ __result, __binary_pred, _IterType());
       // concept requirements
       __glibcpp_function_requires(_Mutable_RandomAccessIteratorConcept<
 	    _RandomAccessIter>);
-      __glibcpp_function_requires(_LessThanComparableConcept<_ValueType);
+      __glibcpp_function_requires(_LessThanComparableConcept<_ValueType>);
     
       make_heap(__first, __middle);
       for (_RandomAccessIter __i = __middle; __i < __last; ++__i)


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2001-10-20 19:06 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-10-20 19:06 libstdc++/4532: typo in bits/stl_algo.h for partial_sort rodrigc
  -- strict thread matches above, loose matches on Subject: below --
2001-10-11  5:16 brendan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).