Re: libgcj/4728: java.util.zip.GZIPOutputStream.write(int) doesn't update CRC

Re: libgcj/4728: java.util.zip.GZIPOutputStream.write(int) doesn't update CRC

[tromey]

Synopsis: java.util.zip.GZIPOutputStream.write(int) doesn't update CRC

Responsible-Changed-From-To: unassigned->tromey
Responsible-Changed-By: tromey
Responsible-Changed-When: Mon Oct 29 13:49:57 2001
Responsible-Changed-Why:
    I'm handling it.
State-Changed-From-To: open->closed
State-Changed-By: tromey
State-Changed-When: Mon Oct 29 13:49:57 2001
State-Changed-Why:
    Thanks a lot for your report and analysis.
    I checked in the fix.
    It will appear in gcc 3.1.
    If it looks like 3.0.3 will be released (I don't know)
    then I think this patch should go in to it as well.

http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&pr=4728&database=gcc

libgcj/4728: java.util.zip.GZIPOutputStream.write(int) doesn't update CRC

[roman.kagan]

>Number:         4728
>Category:       libgcj
>Synopsis:       java.util.zip.GZIPOutputStream.write(int) doesn't update CRC
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    unassigned
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Oct 29 03:46:00 PST 2001
>Closed-Date:
>Last-Modified:
>Originator:     Roman Kagan
>Release:        gcc-3.0.2
>Organization:
>Environment:
any
>Description:
Writing to java.util.zip.GZIPOutputStream using write(int)
method results in an invalid GZIP file with a wrong CRC.
>How-To-Repeat:

>Fix:
The problem is due to that write(int) in GZIPOutputStream
is inherited from java.util.zip.DeflaterOutpuStream (like
in Sun's JDK), however (unlike Sun's) it doesn't internally
use write(byte[], int, int) which is overridden in
GZIPOutputStream to update the CRC.
So one has to either override also write(void) in
GZIPOutputStream or modify write(void) in
DeflaterOutputStream.
>Release-Note:
>Audit-Trail:
>Unformatted: