Re: libstdc++/4503: __enc_traits destructor crashes if initialisation failed

Re: libstdc++/4503: __enc_traits destructor crashes if initialisation failed

[bkoz]

Synopsis: __enc_traits destructor crashes if initialisation failed

State-Changed-From-To: feedback->closed
State-Changed-By: bkoz
State-Changed-When: Thu Nov 15 12:39:15 2001
State-Changed-Why:
    This is fixed in mainline.

http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&pr=4503&database=gcc

Re: libstdc++/4503: __enc_traits destructor crashes if initialisation failed

[bkoz]

The following reply was made to PR libstdc++/4503; it has been noted by GNATS.

From: bkoz@gcc.gnu.org
To: ben.hutchings@roundpoint.com, bkoz@gcc.gnu.org, gcc-bugs@gcc.gnu.org,
  gcc-gnats@gcc.gnu.org, gcc-prs@gcc.gnu.org
Cc:  
Subject: Re: libstdc++/4503: __enc_traits destructor crashes if initialisation failed
Date: 15 Nov 2001 20:39:16 -0000

 Synopsis: __enc_traits destructor crashes if initialisation failed
 
 State-Changed-From-To: feedback->closed
 State-Changed-By: bkoz
 State-Changed-When: Thu Nov 15 12:39:15 2001
 State-Changed-Why:
     This is fixed in mainline.
 
 http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&pr=4503&database=gcc

Re: libstdc++/4503: __enc_traits destructor crashes if initialisation failed

[bkoz]

Synopsis: __enc_traits destructor crashes if initialisation failed

Responsible-Changed-From-To: unassigned->bkoz
Responsible-Changed-By: bkoz
Responsible-Changed-When: Thu Oct 25 23:46:29 2001
Responsible-Changed-Why:
    Mine.
State-Changed-From-To: open->feedback
State-Changed-By: bkoz
State-Changed-When: Thu Oct 25 23:46:29 2001
State-Changed-Why:
    2001-10-25  Benjamin Kosnik  <bkoz@redhat.com>
    
    	libstdc++/4503
    	* config/locale/codecvt_specializations_ieee_1003.1-200x.h: Fix.
    
    
    
    I fixed this in mainline CVS, gcc-3.1. I will confess that the error handling strategy for __enc_traits is a bit up in the air. 
    
    I'm not quite sure what to do when the iconv descriptor's can't be opened, or fail. 
    
    In the meantime, thanks!
    
    -benjamin

http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&pr=4503&database=gcc

libstdc++/4503: __enc_traits destructor crashes if initialisation failed

[ben.hutchings]

>Number:         4503
>Category:       libstdc++
>Synopsis:       __enc_traits destructor crashes if initialisation failed
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    unassigned
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Oct 08 08:56:01 PDT 2001
>Closed-Date:
>Last-Modified:
>Originator:     ben.hutchings@roundpoint.com
>Release:        gcc-3.0.1
>Organization:
>Environment:
Solaris 8 on SPARC
>Description:
__enc_traits::~__enc_traits() calls iconv_close() on each of its iconv_t members.  On Solaris, iconv_close crashes if given the error value (iconv_t)(-1), rather than doing nothing (as one might expect). I'm unclear on what public functions utilise__enc_traits. The test programs 22_locale/codecvt_unicode_*.cc use it directly and crash on Solaris (after I apply kluges so that _GLIBCPP_USE_WCHAR_T is defined), so I've written a trivial test case based on that.
>How-To-Repeat:
Compile and run the attached file test.cc
>Fix:
Make each iconv_close call conditional on the descriptor not being equal to (iconv_t)(-1).
>Release-Note:
>Audit-Trail:
>Unformatted:
----gnatsweb-attachment----
Content-Type: application/octet-stream; name="test.cc"
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="test.cc"

I2luY2x1ZGUgPGxvY2FsZT4KaW50IG1haW4oKQp7CiAgICBzdGQ6Ol9fZW5jX3RyYWl0cyB0cmFp
dHMoImZvbyIsImJhciIpOyAvLyBub24tZXhpc3RlbnQgZW5jb2RpbmdzCiAgICB0cmFpdHMuX01f
aW5pdCgpOwp9Cg==