Re: libstdc++/4536: ostream seekp & istream seekg should scope failbit

Re: libstdc++/4536: ostream seekp & istream seekg should scope failbit

[bkoz]

Synopsis: ostream seekp & istream seekg should scope failbit

State-Changed-From-To: feedback->closed
State-Changed-By: bkoz
State-Changed-When: Thu Nov 15 12:41:26 2001
State-Changed-Why:
    Fixed.

http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&pr=4536&database=gcc

Re: libstdc++/4536: ostream seekp & istream seekg should scope failbit

[bkoz]

The following reply was made to PR libstdc++/4536; it has been noted by GNATS.

From: bkoz@gcc.gnu.org
To: bkoz@gcc.gnu.org, brendan@zen.org, gcc-bugs@gcc.gnu.org,
  gcc-gnats@gcc.gnu.org, gcc-prs@gcc.gnu.org
Cc:  
Subject: Re: libstdc++/4536: ostream seekp & istream seekg should scope failbit
Date: 15 Nov 2001 20:41:27 -0000

 Synopsis: ostream seekp & istream seekg should scope failbit
 
 State-Changed-From-To: feedback->closed
 State-Changed-By: bkoz
 State-Changed-When: Thu Nov 15 12:41:26 2001
 State-Changed-Why:
     Fixed.
 
 http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&pr=4536&database=gcc

Re: libstdc++/4536: ostream seekp & istream seekg should scope failbit

[bkoz]

Synopsis: ostream seekp & istream seekg should scope failbit

Responsible-Changed-From-To: unassigned->bkoz
Responsible-Changed-By: bkoz
Responsible-Changed-When: Thu Oct 25 21:49:27 2001
Responsible-Changed-Why:
    Mine.
State-Changed-From-To: open->feedback
State-Changed-By: bkoz
State-Changed-When: Thu Oct 25 21:49:27 2001
State-Changed-Why:
    Thanks Brendan, this is in now.

http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&pr=4536&database=gcc

Re: libstdc++/4536 ostream seekp & istream seekg should scope failbit

[Craig Rodrigues]

The following reply was made to PR libstdc++/4536; it has been noted by GNATS.

From: Craig Rodrigues <rodrigc@mediaone.net>
To: gcc-patches@gcc.gnu.org
Cc: libstdc++@gcc.gnu.org, gcc-gnats@gcc.gnu.org, brendan@zen.org,
   rodrigc@gcc.gnu.org
Subject: Re: libstdc++/4536 ostream seekp & istream seekg should scope failbit
Date: Sun, 14 Oct 2001 15:25:19 -0400

 http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view&pr=4536&database=gcc
 
 Hi,
 
 Following patch addresses PR 4536 on mainline.
 
 "ostream's seekp and istream's seekg methods need to use failbit as
 `ios_base::failbit'.
 It may be worth noting that the setting of failbit goes in line 
 with the change for library DR #129. The standard pre-DR edits 
 does not include the clause in $27.6.2.4(2) regarding the setting 
 of failbit."
 
 
 2001-10-11  Brendan Kehoe  <brendan@zen.org>
 
 	* bits/ostream.tcc (seekp): Scope use as ios_base::failbit.
 	* bits/istream.tcc (seekg): Likewise.
 
 Index: include/bits/ostream.tcc
 ===================================================================
 RCS file: /cvs/gcc/egcs/libstdc++-v3/include/bits/ostream.tcc,v
 retrieving revision 1.15
 diff -u -p -r1.15 ostream.tcc
 --- ostream.tcc	2001/09/25 23:51:17	1.15
 +++ ostream.tcc	2001/10/10 11:44:23
 @@ -346,7 +346,7 @@ namespace std 
        if (__sbin && __cerb)
  	__xtrct = __copy_streambufs(*this, __sbin, __sbout);
        if (!__sbin || !__xtrct)
 -	this->setstate(ios_base::failbit);
 +	this->setstate(ios_base::failbit);
        return *this;
      }
  
 Index: include/bits/istream.tcc
 ===================================================================
 RCS file: /cvs/gcc/egcs/libstdc++-v3/include/bits/istream.tcc,v
 retrieving revision 1.19
 diff -u -p -r1.19 istream.tcc
 --- istream.tcc	2001/09/25 23:51:17	1.19
 +++ istream.tcc	2001/10/10 11:44:13
 @@ -963,7 +963,7 @@ namespace std 
  
  // 129. Need error indication from seekp() and seekg()
  	      if (__err == pos_type(off_type(-1)))
 -		this->setstate(failbit);
 +		this->setstate(ios_base::failbit);
  #endif
  	    }
  	  catch(exception& __fail)
 @@ -996,7 +996,7 @@ namespace std 
  
  // 129. Need error indication from seekp() and seekg()
  	      if (__err == pos_type(off_type(-1)))
 -		this->setstate(failbit);
 +		this->setstate(ios_base::failbit);
  #endif
  	    }
  	  catch(exception& __fail)
 -- 
 Craig Rodrigues        
 http://www.gis.net/~craigr    
 rodrigc@mediaone.net          

libstdc++/4536: ostream seekp & istream seekg should scope failbit

[brendan]

>Number:         4536
>Category:       libstdc++
>Synopsis:       ostream seekp & istream seekg should scope failbit
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    unassigned
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Oct 11 06:56:00 PDT 2001
>Closed-Date:
>Last-Modified:
>Originator:     Brendan Kehoe
>Release:        CVS tree
>Organization:
>Environment:

>Description:
ostream's seekp and istream's seekg methods need to use failbit as  `ios_base::failbit'.
It may be worth noting that the setting of failbit goes in line with the change for library DR #129.  The standard pre-DR edits does not include the clause in $27.6.2.4(2) regarding the setting of failbit.

>How-To-Repeat:

>Fix:
See attached patch.
>Release-Note:
>Audit-Trail:
>Unformatted:
----gnatsweb-attachment----
Content-Type: text/plain; name="diffs-istream-1.txt"
Content-Disposition: inline; filename="diffs-istream-1.txt"

2001-10-11  Brendan Kehoe  <brendan@zen.org>

	* bits/ostream.tcc (seekp): Scope use as ios_base::failbit.
	* bits/istream.tcc (seekg): Likewise.

Index: include/bits/ostream.tcc
===================================================================
RCS file: /cvs/gcc/egcs/libstdc++-v3/include/bits/ostream.tcc,v
retrieving revision 1.15
diff -u -p -r1.15 ostream.tcc
--- ostream.tcc	2001/09/25 23:51:17	1.15
+++ ostream.tcc	2001/10/10 11:44:23
@@ -346,7 +346,7 @@ namespace std 
       if (__sbin && __cerb)
 	__xtrct = __copy_streambufs(*this, __sbin, __sbout);
       if (!__sbin || !__xtrct)
-	this->setstate(ios_base::failbit);
+	this->setstate(ios_base::failbit);
       return *this;
     }
 
Index: include/bits/istream.tcc
===================================================================
RCS file: /cvs/gcc/egcs/libstdc++-v3/include/bits/istream.tcc,v
retrieving revision 1.19
diff -u -p -r1.19 istream.tcc
--- istream.tcc	2001/09/25 23:51:17	1.19
+++ istream.tcc	2001/10/10 11:44:13
@@ -963,7 +963,7 @@ namespace std 
 
 // 129. Need error indication from seekp() and seekg()
 	      if (__err == pos_type(off_type(-1)))
-		this->setstate(failbit);
+		this->setstate(ios_base::failbit);
 #endif
 	    }
 	  catch(exception& __fail)
@@ -996,7 +996,7 @@ namespace std 
 
 // 129. Need error indication from seekp() and seekg()
 	      if (__err == pos_type(off_type(-1)))
-		this->setstate(failbit);
+		this->setstate(ios_base::failbit);
 #endif
 	    }
 	  catch(exception& __fail)