Re: libstdc++/4622: incorrect implementation of complex operator/=

Re: libstdc++/4622: incorrect implementation of complex operator/=

[bkoz]

Synopsis: incorrect implementation of complex operator/=

State-Changed-From-To: feedback->closed
State-Changed-By: bkoz
State-Changed-When: Thu Nov 15 13:26:11 2001
State-Changed-Why:
    Fixed.

http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&pr=4622&database=gcc

Re: libstdc++/4622: incorrect implementation of complex operator/=

[bkoz]

The following reply was made to PR libstdc++/4622; it has been noted by GNATS.

From: bkoz@gcc.gnu.org
To: edward.e.meyer@boeing.com, gcc-bugs@gcc.gnu.org, gcc-gnats@gcc.gnu.org,
  gcc-prs@gcc.gnu.org, gdr@gcc.gnu.org
Cc:  
Subject: Re: libstdc++/4622: incorrect implementation of complex operator/=
Date: 15 Nov 2001 21:26:13 -0000

 Synopsis: incorrect implementation of complex operator/=
 
 State-Changed-From-To: feedback->closed
 State-Changed-By: bkoz
 State-Changed-When: Thu Nov 15 13:26:11 2001
 State-Changed-Why:
     Fixed.
 
 http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&pr=4622&database=gcc

Re: libstdc++/4622: incorrect implementation of complex operator/=

[bkoz]

Synopsis: incorrect implementation of complex operator/=

State-Changed-From-To: open->feedback
State-Changed-By: bkoz
State-Changed-When: Wed Oct 31 00:36:40 2001
State-Changed-Why:
    I just checked in this patch: Gaby had approved it a week ago.
    
    Thanks again,
    Benjamin

http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&pr=4622&database=gcc

Re: libstdc++/4622: incorrect implementation of complex operator/=

[bkoz]

Synopsis: incorrect implementation of complex operator/=

Responsible-Changed-From-To: unassigned->gdr
Responsible-Changed-By: bkoz
Responsible-Changed-When: Thu Oct 25 23:15:40 2001
Responsible-Changed-Why:
    Hey Gaby can you look at this patch please?
    
    Thanks,
    benjamin

http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&pr=4622&database=gcc

libstdc++/4622: incorrect implementation of complex operator/=

[Edward E Meyer]

>Number:         4622
>Category:       libstdc++
>Synopsis:       incorrect implementation of complex operator/=
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    unassigned
>State:          open
>Class:          wrong-code
>Submitter-Id:   net
>Arrival-Date:   Fri Oct 19 13:56:00 PDT 2001
>Closed-Date:
>Last-Modified:
>Originator:     Edward E Meyer
>Release:        3.0.1
>Organization:
Boeing
>Environment:
System: IRIX64 origin 6.5 01101245 IP35


	
host: mips-sgi-irix6.5
build: mips-sgi-irix6.5
target: mips-sgi-irix6.5
configured with: ../gcc-3.0.1/configure --prefix=/acct/eem2314/local
>Description:
the implementation of the operator/= function for std template complex
is wrong - the sign is reversed on the imaginary part on line 240 of
libstdc++-v3/include/bits/std_complex.h
>How-To-Repeat:
	
>Fix:
--- std_complex.h	Fri Oct 19 20:04:32 2001
+++ std_complex.h.patch	Fri Oct 19 20:05:41 2001
@@ -237,7 +237,7 @@
     {
       const _Tp __r =  _M_real * __z.real() + _M_imag * __z.imag();
       const _Tp __n = norm(__z);
-      _M_imag = (_M_real * __z.imag() - _M_imag * __z.real()) / __n;
+      _M_imag = (_M_imag * __z.real() - _M_real * __z.imag()) / __n;
       _M_real = __r / __n;
       return *this;
     }
>Release-Note:
>Audit-Trail:
>Unformatted: