Re: other/4932: the i386 backend crashes on incorrect asm("... %c0 ...")

Re: other/4932: the i386 backend crashes on incorrect asm("... %c0 ...")

[rodrigc]

Synopsis: the i386 backend crashes on incorrect asm("... %c0 ...")

State-Changed-From-To: analyzed->closed
State-Changed-By: rodrigc
State-Changed-When: Sat Dec  1 08:49:56 2001
State-Changed-Why:
    Patch committed.
    2001-11-29  Craig Rodrigues  <rodrigc@gcc.gnu.org>
            
            PR other/4932
            * config/i386/i386.c (print_operand):  Verify that the
            argument to %c is a constant and not a conditional which
            needs to be reversed.

http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&pr=4932&database=gcc

Re: other/4932: the i386 backend crashes on incorrect asm("... %c0 ...")

[rodrigc]

The following reply was made to PR other/4932; it has been noted by GNATS.

From: rodrigc@gcc.gnu.org
To: espenlaub@informatik.uni-ulm.de, gcc-bugs@gcc.gnu.org,
  gcc-gnats@gcc.gnu.org, gcc-prs@gcc.gnu.org, nobody@gcc.gnu.org
Cc:  
Subject: Re: other/4932: the i386 backend crashes on incorrect asm("... %c0 ...")
Date: 1 Dec 2001 16:49:56 -0000

 Synopsis: the i386 backend crashes on incorrect asm("... %c0 ...")
 
 State-Changed-From-To: analyzed->closed
 State-Changed-By: rodrigc
 State-Changed-When: Sat Dec  1 08:49:56 2001
 State-Changed-Why:
     Patch committed.
     2001-11-29  Craig Rodrigues  <rodrigc@gcc.gnu.org>
             
             PR other/4932
             * config/i386/i386.c (print_operand):  Verify that the
             argument to %c is a constant and not a conditional which
             needs to be reversed.
 
 http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&pr=4932&database=gcc

Re: other/4932: the i386 backend crashes on incorrect asm("... %c0 ...")

[rodrigc]

The following reply was made to PR other/4932; it has been noted by GNATS.

From: rodrigc@gcc.gnu.org
To: espenlaub@informatik.uni-ulm.de, gcc-bugs@gcc.gnu.org,
  gcc-gnats@gcc.gnu.org, gcc-prs@gcc.gnu.org, nobody@gcc.gnu.org
Cc:  
Subject: Re: other/4932: the i386 backend crashes on incorrect asm("... %c0 ...")
Date: 29 Nov 2001 17:26:43 -0000

 Synopsis: the i386 backend crashes on incorrect asm("... %c0 ...")
 
 State-Changed-From-To: feedback->analyzed
 State-Changed-By: rodrigc
 State-Changed-When: Thu Nov 29 09:26:42 2001
 State-Changed-Why:
     OK, I saw your testcase submitted with this PR.
     I have submitted this patch with your testcase to the gcc-patches
     mailing list, where it will be evaluated:
     
     http://gcc.gnu.org/ml/gcc-patches/2001-11/msg01987.html
 
 http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&pr=4932&database=gcc

Re: other/4932: the i386 backend crashes on incorrect asm("... %c0 ...")

[rodrigc]

Synopsis: the i386 backend crashes on incorrect asm("... %c0 ...")

State-Changed-From-To: feedback->analyzed
State-Changed-By: rodrigc
State-Changed-When: Thu Nov 29 09:26:42 2001
State-Changed-Why:
    OK, I saw your testcase submitted with this PR.
    I have submitted this patch with your testcase to the gcc-patches
    mailing list, where it will be evaluated:
    
    http://gcc.gnu.org/ml/gcc-patches/2001-11/msg01987.html

http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&pr=4932&database=gcc

Re: other/4932: the i386 backend crashes on incorrect asm("... %c0 ...")

[rodrigc]

The following reply was made to PR other/4932; it has been noted by GNATS.

From: rodrigc@gcc.gnu.org
To: espenlaub@informatik.uni-ulm.de, gcc-bugs@gcc.gnu.org,
  gcc-gnats@gcc.gnu.org, gcc-prs@gcc.gnu.org, nobody@gcc.gnu.org
Cc:  
Subject: Re: other/4932: the i386 backend crashes on incorrect asm("... %c0 ...")
Date: 29 Nov 2001 16:19:16 -0000

 Synopsis: the i386 backend crashes on incorrect asm("... %c0 ...")
 
 State-Changed-From-To: open->feedback
 State-Changed-By: rodrigc
 State-Changed-When: Thu Nov 29 08:19:16 2001
 State-Changed-Why:
     Do you have a testcase for this?
 
 http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&pr=4932&database=gcc

Re: other/4932: the i386 backend crashes on incorrect asm("... %c0 ...")

[rodrigc]

Synopsis: the i386 backend crashes on incorrect asm("... %c0 ...")

State-Changed-From-To: open->feedback
State-Changed-By: rodrigc
State-Changed-When: Thu Nov 29 08:19:16 2001
State-Changed-Why:
    Do you have a testcase for this?

http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&pr=4932&database=gcc

other/4932: the i386 backend crashes on incorrect asm("... %c0 ...")

[espenlaub]

>Number:         4932
>Category:       other
>Synopsis:       the i386 backend crashes on incorrect asm("... %c0 ...")
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    unassigned
>State:          open
>Class:          ice-on-illegal-code
>Submitter-Id:   net
>Arrival-Date:   Fri Nov 23 01:46:01 PST 2001
>Closed-Date:
>Last-Modified:
>Originator:     Klaus Espenlaub
>Release:        gcc-3.0
>Organization:
>Environment:
System: Linux deadbeef 2.4.4-4GB #2 Fri Jul 20 08:48:42 CEST 2001 i686 unknown
Architecture: i686
host: i686-pc-linux-gnu
build: i686-pc-linux-gnu
target: i686-pc-linux-gnu
configured with: ./configure --enable-languages=c
>Description:
If an asm(...) output pattern contains the `%c' code, but
the actual operand isn't a constant, then the code in
i386.c tries to treat it as a condition code that should
be reversed - and that fails with a SIGSEGV.
>How-To-Repeat:
gcc testcase.c -S testcase.s
>Fix:
--- i386.c-orig	Fri Nov 23 10:29:42 2001
+++ i386.c	Fri Nov 23 10:35:19 2001
@@ -3522,6 +3522,15 @@ print_operand (file, x, code)
 
 	  /* Like above, but reverse condition */
 	case 'c':
+	  /* Buggy user-written assembler instructions may contain this code
+	   * (the user expects the meaning "output constant value without the
+	   * syntax that normally indicates an immediate operand"), but the
+	   * actual operand the compiler uses isn't a constant after all.  */
+	  if (GET_RTX_CLASS (GET_CODE (x)) != '<')
+	    {
+	      output_operand_lossage ("operand is neither a constant nor a condition code, invalid operand code `c'");
+	      return;
+	    }
 	  put_condition_code (GET_CODE (x), GET_MODE (XEXP (x, 0)), 1, 0, file);
 	  return;
 	case 'f':
>Release-Note:
>Audit-Trail:
>Unformatted:
----gnatsweb-attachment----
Content-Type: text/plain; name="testcase.c"
Content-Disposition: inline; filename="testcase.c"

void *abc;

int main(void)
{
	__asm__ __volatile__("some assembly code containing %c0"
		: /* no output */ : "ir" (abc));
}