Re: c/5105: compound literal patch broken with inlining

Re: c/5105: compound literal patch broken with inlining

[aj]

Synopsis: compound literal patch broken with inlining

Responsible-Changed-From-To: unassigned->jsm28
Responsible-Changed-By: aj
Responsible-Changed-When: Thu Dec 13 12:14:21 2001
Responsible-Changed-Why:
    Joseph wants to look into this - thanks Joseph!

http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&pr=5105&database=gcc

Re: c/5105: compound literal patch broken with inlining

[aj]

Synopsis: compound literal patch broken with inlining

State-Changed-From-To: open->closed
State-Changed-By: aj
State-Changed-When: Mon Dec 17 01:40:51 2001
State-Changed-Why:
    
    This has been fixed with Joseph's patch (just tested glibc),
    
    thanks,
    Andreas
    
    
    2001-12-17  Joseph S. Myers  <jsm28@cam.ac.uk>
    
    	* c-common.def (COMPOUND_LITERAL_EXPR): Contain a DECL_STMT, not
    	a DECL directly.
    	* c-common.h (COMPOUND_LITERAL_EXPR_DECL_STMT): New.
    	(COMPOUND_LITERAL_EXPR_DECL): Adjust definition.
    	* c-decl.c (build_compound_literal): Put the decl inside a
    	DECL_STMT.
    	* doc/c-tree.texi (COMPOUND_LITERAL_EXPR): Update documentation.
    	Fixes PR c/5105.

http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gcc&pr=5105

Re: c/5105: compound literal patch broken with inlining

[aj]

The following reply was made to PR c/5105; it has been noted by GNATS.

From: aj@gcc.gnu.org
To: aj@suse.de, bo@suse.de, gcc-bugs@gcc.gnu.org, gcc-gnats@gcc.gnu.org,
  gcc-prs@gcc.gnu.org, jsm28@gcc.gnu.org, nobody@gcc.gnu.org
Cc:  
Subject: Re: c/5105: compound literal patch broken with inlining
Date: 13 Dec 2001 20:14:22 -0000

 Synopsis: compound literal patch broken with inlining
 
 Responsible-Changed-From-To: unassigned->jsm28
 Responsible-Changed-By: aj
 Responsible-Changed-When: Thu Dec 13 12:14:21 2001
 Responsible-Changed-Why:
     Joseph wants to look into this - thanks Joseph!
 
 http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&pr=5105&database=gcc

c/5105: compound literal patch broken with inlining

[aj]

>Number:         5105
>Category:       c
>Synopsis:       compound literal patch broken with inlining
>Confidential:   no
>Severity:       critical
>Priority:       medium
>Responsible:    unassigned
>State:          open
>Class:          ice-on-legal-code
>Submitter-Id:   net
>Arrival-Date:   Thu Dec 13 11:56:01 PST 2001
>Closed-Date:
>Last-Modified:
>Originator:     aj@suse.de
>Release:        gcc 3.1 CVS - any version later than 4th of December
>Organization:
>Environment:
i686-linux-gnu, or crosscompiler to x86_64-linux-gnu,
or ia64-linux, or ppc-linux
>Description:
typedef struct { long p; } pt;

inline pt f(pt _p)
{
  long p = _p.p;

  return (pt) { (p) };
}

The following test case fails with -O2, it works with
-fno-inline added:

static int mmap_mem(void)
{
  pt p;
  p = f(p);

  return 0;
}

for more details check:
http://gcc.gnu.org/ml/gcc/2001-12/msg00576.html
http://gcc.gnu.org/ml/gcc/2001-12/msg00697.html
http://gcc.gnu.org/ml/gcc-bugs/2001-12/msg00269.html
>How-To-Repeat:
Just compile the file.
>Fix:
Revert Joseph's compound literals patch.;-)

Andreas
>Release-Note:
>Audit-Trail:
>Unformatted: