public inbox for gcc-prs@sourceware.org
help / color / mirror / Atom feed
* java/4715
@ 2001-12-20 22:46 Tom Tromey
0 siblings, 0 replies; 3+ messages in thread
From: Tom Tromey @ 2001-12-20 22:46 UTC (permalink / raw)
To: nobody; +Cc: gcc-prs
The following reply was made to PR java/4715; it has been noted by GNATS.
From: Tom Tromey <tromey@redhat.com>
To: Bryce McKinlay <bryce@waitaki.otago.ac.nz>
Cc: gcc-gnats@gcc.gnu.org
Subject: java/4715
Date: 20 Dec 2001 23:43:17 -0700
I looked at this PR a bit tonight. I didn't really get very far.
This scenario seems too complex to figure out in one night (for me
anyway).
It wasn't clear to me that simply returning NULL_TREE when we
encountered an incomplete type was correct. I came up with the
appended patch, which seems to work. However, I don't vouch for its
correctness.
Tom
Index: parse.y
===================================================================
RCS file: /cvs/gcc/gcc/gcc/java/parse.y,v
retrieving revision 1.338
diff -u -r1.338 parse.y
--- parse.y 2001/12/21 05:28:27 1.338
+++ parse.y 2001/12/21 06:29:48
@@ -5232,14 +5232,23 @@
if (!basetype_vec)
return NULL_TREE;
-
+
for (i = 0; i < TREE_VEC_LENGTH (basetype_vec); i++)
{
- tree su = BINFO_TYPE (TREE_VEC_ELT (basetype_vec, i));
+ tree su;
+
+ /* We can end up with a NULL_TREE or an incomplete type here if
+ we are compiling multiple files at once. It's safe to simply
+ ignore these cases. */
+ if (TREE_VEC_ELT (basetype_vec, i) == NULL_TREE)
+ continue;
+ su = BINFO_TYPE (TREE_VEC_ELT (basetype_vec, i));
+ if (INCOMPLETE_TYPE_P (su))
+ continue;
if (inherits_from_p (su, target))
return lookup_cl (TYPE_NAME (su));
-
+
for (ctx = DECL_CONTEXT (TYPE_NAME (su)); ctx; ctx = DECL_CONTEXT (ctx))
{
/* An enclosing context shouldn't be TARGET */
^ permalink raw reply [flat|nested] 3+ messages in thread
* java/4715
@ 2002-03-28 16:16 apbianco
0 siblings, 0 replies; 3+ messages in thread
From: apbianco @ 2002-03-28 16:16 UTC (permalink / raw)
To: apbianco; +Cc: gcc-prs
The following reply was made to PR java/4715; it has been noted by GNATS.
From: apbianco@gcc.gnu.org
To: gcc-gnats@gcc.gnu.org
Cc:
Subject: java/4715
Date: 29 Mar 2002 00:14:01 -0000
CVSROOT: /cvs/gcc
Module name: gcc
Branch: gcc-3_1-branch
Changes by: apbianco@gcc.gnu.org 2002-03-28 16:14:01
Modified files:
gcc/java : ChangeLog jcf-parse.c
Log message:
2002-03-28 Alexandre Petit-Bianco <apbianco@redhat.com>
Fix for PR java/4715:
* jcf-parse.c (parse_source_file_3): New function.
(read_class): Call it.
(java_parse_file): Likewise.
(http://gcc.gnu.org/ml/gcc-patches/2002-03/msg01917.html)
Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/java/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-3_1-branch&r1=1.925.2.28&r2=1.925.2.29
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/java/jcf-parse.c.diff?cvsroot=gcc&only_with_tag=gcc-3_1-branch&r1=1.104.2.4&r2=1.104.2.5
^ permalink raw reply [flat|nested] 3+ messages in thread
* java/4715
@ 2002-03-28 15:46 apbianco
0 siblings, 0 replies; 3+ messages in thread
From: apbianco @ 2002-03-28 15:46 UTC (permalink / raw)
To: apbianco; +Cc: gcc-prs
The following reply was made to PR java/4715; it has been noted by GNATS.
From: apbianco@gcc.gnu.org
To: gcc-gnats@gcc.gnu.org
Cc:
Subject: java/4715
Date: 28 Mar 2002 23:40:21 -0000
CVSROOT: /cvs/gcc
Module name: gcc
Changes by: apbianco@gcc.gnu.org 2002-03-28 15:40:21
Modified files:
gcc/java : ChangeLog jcf-parse.c
Log message:
2002-03-28 Alexandre Petit-Bianco <apbianco@redhat.com>
Fix for PR java/4715:
* jcf-parse.c (parse_source_file_3): New function.
(read_class): Call it.
(java_parse_file): Likewise.
(http://gcc.gnu.org/ml/gcc-patches/2002-03/msg01917.html)
Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/java/ChangeLog.diff?cvsroot=gcc&r1=1.967&r2=1.968
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/java/jcf-parse.c.diff?cvsroot=gcc&r1=1.111&r2=1.112
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2002-03-29 0:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-12-20 22:46 java/4715 Tom Tromey
2002-03-28 15:46 java/4715 apbianco
2002-03-28 16:16 java/4715 apbianco
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).