Re: libstdc++/4096: libstdc++-v3/include/Makefile.in has several errors in it

Re: libstdc++/4096: libstdc++-v3/include/Makefile.in has several errors in it

[pme]

Synopsis: libstdc++-v3/include/Makefile.in has several errors in it

State-Changed-From-To: open->closed
State-Changed-By: pme
State-Changed-When: Fri Dec 28 15:18:32 2001
State-Changed-Why:
    None of these are bugs; no discussion has taken place since August.

http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gcc&pr=4096

Re: libstdc++/4096: libstdc++-v3/include/Makefile.in has several errors in it

[Phil Edwards]

The following reply was made to PR libstdc++/4096; it has been noted by GNATS.

From: Phil Edwards <pedwards@disaster.jaj.com>
To: rkl@connect.org.uk
Cc: gcc-gnats@gcc.gnu.org
Subject: Re: libstdc++/4096: libstdc++-v3/include/Makefile.in has several errors in it
Date: Thu, 23 Aug 2001 16:29:47 -0400

 On Thu, Aug 23, 2001 at 02:40:48PM -0000, rkl@connect.org.uk wrote:
 > >Environment:
 > HP-UX 11.00, but probably applies to most platforms
 
 Nope.
 
 > >Description:
 > The new Makefile.in added with 3.0.1, namely
 > libstdc++-v3/include/Makefile.in has several problems:
 > 
 > * The lengths of lines are excessive - HP-UX 11.00's vi
 >   can't edit them.
 
 The very first line of Makefile.in tells you that the file is automatically
 generated.  You're not supposed to be editing them directly.  (Users who
 do are assumed to have a decent text editor like vim.)
 
 > * The path for the rules involving gthr.h, gthr-single.h
 >   and gthr-default.h seem to be one level too low, causing
 >   the build to bomb out.
 
 That is a bug, already reported.  I think it might already be fixed in
 the development tree.
 
 > * Use of "-d" with the $(INSTALL) command isn't
 >   cross-platform (many install scripts don't support it) -
 >   see the install-data-local rule.
 
 Have you seen what $(INSTALL) evaluates to?  GCC ships its own installation
 script.
 
 
 > * "make install" installs the Makefile.in, Makefile and
 >   Makefile.am files into the install tree of gcc !!!!!
 
 Already fixed in the 3.1 tree.  The patch that did it hasn't yet been
 applied to the 3.0.x tree, but probably will be soon.  (It's a harmless
 but amusing bug.)
 
 
 Phil
 
 -- 
 Would I had phrases that are not known, utterances that are strange, in
 new language that has not been used, free from repetition, not an utterance
 which has grown stale, which men of old have spoken.
                                      - anonymous Egyptian scribe, c.1700 BC

libstdc++/4096: libstdc++-v3/include/Makefile.in has several errors in it

[rkl]

>Number:         4096
>Category:       libstdc++
>Synopsis:       libstdc++-v3/include/Makefile.in has several errors in it
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    unassigned
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Aug 23 07:46:01 PDT 2001
>Closed-Date:
>Last-Modified:
>Originator:     rkl@connect.org.uk
>Release:        3.0.1
>Organization:
>Environment:
HP-UX 11.00, but probably applies to most platforms
>Description:
The new Makefile.in added with 3.0.1, namely
libstdc++-v3/include/Makefile.in has several problems:

* The lengths of lines are excessive - HP-UX 11.00's vi
  can't edit them.

* The path for the rules involving gthr.h, gthr-single.h
  and gthr-default.h seem to be one level too low, causing
  the build to bomb out.

* Use of "-d" with the $(INSTALL) command isn't
  cross-platform (many install scripts don't support it) -
  see the install-data-local rule.

* "make install" installs the Makefile.in, Makefile and
  Makefile.am files into the install tree of gcc !!!!!
>How-To-Repeat:
You won't be able to build with "make" or "make install"
on HP-UX 11.00.
>Fix:
* Use "vim" to edit the Makefile.in instead of "vi" on
  HP-UX 11.00. Would be nice if no Makefile* files in
  gcc exceeded, say, 200 chars on any one line.

* Add a "../" to the middle of the path for the
  gthr*.h: rules - for example, the gthr.h rule now reads:

${thread_builddir}/gthr.h:
        sed -e '/^#/s/\(${uppercase}${uppercase}*\)/_GLIBCPP_\1/g' \
            -e 's,^#include "\(.*\)",#include <bits/\1>,g' \
            < ${glibcpp_srcdir}/../../gcc/gthr.h > $@

* In the install-data-local: rule, change:
            $(INSTALL) -d $${installFile} ;\
  to:
          mkdir -p $${installFile} ;\

* Add an ! -name directive to the find command in the
  install-data-local rule:

  for file in `find . ! -name stamp-\* ! -name Makefile\* -print`; do \
>Release-Note:
>Audit-Trail:
>Unformatted: