public inbox for gcc-prs@sourceware.org
help / color / mirror / Atom feed
* Re: target/5378: ICE: unrecognizable insn prefetch
@ 2002-01-21 19:48 rodrigc
0 siblings, 0 replies; 8+ messages in thread
From: rodrigc @ 2002-01-21 19:48 UTC (permalink / raw)
To: gcc-bugs, gcc-prs, nobody, ritzert
Synopsis: ICE: unrecognizable insn prefetch
State-Changed-From-To: open->closed
State-Changed-By: rodrigc
State-Changed-When: Mon Jan 21 19:48:17 2002
State-Changed-Why:
http://gcc.gnu.org/ml/gcc-cvs/2002-01/msg00417.html
http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gcc&pr=5378
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: target/5378: ICE: unrecognizable insn prefetch
@ 2002-01-15 9:26 Janis Johnson
0 siblings, 0 replies; 8+ messages in thread
From: Janis Johnson @ 2002-01-15 9:26 UTC (permalink / raw)
To: nobody; +Cc: gcc-prs
The following reply was made to PR target/5378; it has been noted by GNATS.
From: Janis Johnson <janis187@us.ibm.com>
To: Richard Henderson <rth@redhat.com>
Cc: Janis Johnson <janis187@us.ibm.com>, ritzert@t-online.de,
gcc-gnats@gcc.gnu.org
Subject: Re: target/5378: ICE: unrecognizable insn prefetch
Date: Tue, 15 Jan 2002 09:27:19 -0800
On Mon, Jan 14, 2002 at 04:59:44PM -0800, Richard Henderson wrote:
> On Mon, Jan 14, 2002 at 04:53:23PM -0800, Janis Johnson wrote:
> > My 3dnow and athlon tests still ICE with this fix.
>
> Really? It didn't here...
They failed yesterday when I applied your patch to a tree I had updated
yesterday morning. Today I updated the whole tree and the tests pass;
sorry about that.
Janis
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: target/5378: ICE: unrecognizable insn prefetch
@ 2002-01-14 17:06 Richard Henderson
0 siblings, 0 replies; 8+ messages in thread
From: Richard Henderson @ 2002-01-14 17:06 UTC (permalink / raw)
To: nobody; +Cc: gcc-prs
The following reply was made to PR target/5378; it has been noted by GNATS.
From: Richard Henderson <rth@redhat.com>
To: Janis Johnson <janis187@us.ibm.com>
Cc: ritzert@t-online.de, gcc-gnats@gcc.gnu.org
Subject: Re: target/5378: ICE: unrecognizable insn prefetch
Date: Mon, 14 Jan 2002 16:59:44 -0800
On Mon, Jan 14, 2002 at 04:53:23PM -0800, Janis Johnson wrote:
> My 3dnow and athlon tests still ICE with this fix.
Really? It didn't here...
r~
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: target/5378: ICE: unrecognizable insn prefetch
@ 2002-01-14 16:56 Janis Johnson
0 siblings, 0 replies; 8+ messages in thread
From: Janis Johnson @ 2002-01-14 16:56 UTC (permalink / raw)
To: nobody; +Cc: gcc-prs
The following reply was made to PR target/5378; it has been noted by GNATS.
From: Janis Johnson <janis187@us.ibm.com>
To: Richard Henderson <rth@redhat.com>
Cc: Janis Johnson <janis187@us.ibm.com>, ritzert@t-online.de,
gcc-gnats@gcc.gnu.org
Subject: Re: target/5378: ICE: unrecognizable insn prefetch
Date: Mon, 14 Jan 2002 16:53:23 -0800
On Mon, Jan 14, 2002 at 03:36:58PM -0800, Richard Henderson wrote:
> On Mon, Jan 14, 2002 at 01:03:25PM -0800, Janis Johnson wrote:
> > > a.c:15: unrecognizable insn:
> > > (insn 154 81 31 (prefetch (plus:SI (reg/f:SI 72)
> > > (const_int 384 [0x180]))
> > > (const_int 1 [0x1])
> > > (const_int 3 [0x3])) -1 (nil)
> > > (nil))
>
> It was indeed a stupid typo. Fixed thus.
>
> (prefetch_3dnow): Fix locality operand.
>
My 3dnow and athlon tests still ICE with this fix.
Janis
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: target/5378: ICE: unrecognizable insn prefetch
@ 2002-01-14 15:46 Richard Henderson
0 siblings, 0 replies; 8+ messages in thread
From: Richard Henderson @ 2002-01-14 15:46 UTC (permalink / raw)
To: nobody; +Cc: gcc-prs
The following reply was made to PR target/5378; it has been noted by GNATS.
From: Richard Henderson <rth@redhat.com>
To: Janis Johnson <janis187@us.ibm.com>
Cc: ritzert@t-online.de, gcc-gnats@gcc.gnu.org
Subject: Re: target/5378: ICE: unrecognizable insn prefetch
Date: Mon, 14 Jan 2002 15:36:58 -0800
On Mon, Jan 14, 2002 at 01:03:25PM -0800, Janis Johnson wrote:
> > a.c:15: unrecognizable insn:
> > (insn 154 81 31 (prefetch (plus:SI (reg/f:SI 72)
> > (const_int 384 [0x180]))
> > (const_int 1 [0x1])
> > (const_int 3 [0x3])) -1 (nil)
> > (nil))
It was indeed a stupid typo. Fixed thus.
r~
* config/i386/i386.md (prefetch): Tidy.
(prefetch_3dnow): Fix locality operand.
Index: i386.md
===================================================================
RCS file: /cvs/gcc/gcc/gcc/config/i386/i386.md,v
retrieving revision 1.329
diff -c -p -d -u -r1.329 i386.md
--- i386.md 2002/01/12 10:05:26 1.329
+++ i386.md 2002/01/14 23:31:06
@@ -19607,6 +19607,7 @@
{
int rw = INTVAL (operands[1]);
int locality = INTVAL (operands[2]);
+
if (rw != 0 && rw != 1)
abort ();
if (locality < 0 || locality > 3)
@@ -19617,13 +19618,9 @@
(K6 machines). Otherwise use SSE prefetch as it allows specifying
of locality. */
if (TARGET_3DNOW && (!TARGET_PREFETCH_SSE || rw))
- {
- operands[2] = GEN_INT (3);
- }
+ operands[2] = GEN_INT (3);
else
- {
- operands[1] = const0_rtx;
- }
+ operands[1] = const0_rtx;
})
(define_insn "*prefetch_sse"
@@ -19647,7 +19644,7 @@
(define_insn "*prefetch_3dnow"
[(prefetch (match_operand:SI 0 "address_operand" "p")
(match_operand:SI 1 "const_int_operand" "n")
- (const_int 0))]
+ (const_int 3))]
"TARGET_3DNOW"
{
if (INTVAL (operands[1]) == 0)
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: target/5378: ICE: unrecognizable insn prefetch
@ 2002-01-14 13:26 Richard Henderson
0 siblings, 0 replies; 8+ messages in thread
From: Richard Henderson @ 2002-01-14 13:26 UTC (permalink / raw)
To: nobody; +Cc: gcc-prs
The following reply was made to PR target/5378; it has been noted by GNATS.
From: Richard Henderson <rth@redhat.com>
To: Janis Johnson <janis187@us.ibm.com>
Cc: ritzert@t-online.de, gcc-gnats@gcc.gnu.org
Subject: Re: target/5378: ICE: unrecognizable insn prefetch
Date: Mon, 14 Jan 2002 13:16:52 -0800
On Mon, Jan 14, 2002 at 01:03:25PM -0800, Janis Johnson wrote:
> > (insn 154 81 31 (prefetch (plus:SI (reg/f:SI 72)
> > (const_int 384 [0x180]))
> > (const_int 1 [0x1])
> > (const_int 3 [0x3])) -1 (nil)
> > (nil))
[...]
> This worked last week, but I think it broken with this patch:
That's strange. That patch forces the non-tweakable parameter to
zero. Perhaps I've done something silly. I'll check in a minute.
> http://gcc.gnu.org/ml/gcc-patches/2002-01/msg00452.html.
This is fine except for the __builtin_ia32 parts which aren't
there anymore.
r~
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: target/5378: ICE: unrecognizable insn prefetch
@ 2002-01-14 13:06 Janis Johnson
0 siblings, 0 replies; 8+ messages in thread
From: Janis Johnson @ 2002-01-14 13:06 UTC (permalink / raw)
To: nobody; +Cc: gcc-prs
The following reply was made to PR target/5378; it has been noted by GNATS.
From: Janis Johnson <janis187@us.ibm.com>
To: ritzert@t-online.de
Cc: gcc-gnats@gcc.gnu.org, rth@redhat.com
Subject: Re: target/5378: ICE: unrecognizable insn prefetch
Date: Mon, 14 Jan 2002 13:03:25 -0800
On Mon, Jan 14, 2002 at 06:36:40PM -0000, ritzert@t-online.de wrote:
>
> >Number: 5378
> >Synopsis: ICE: unrecognizable insn prefetch
> >Arrival-Date: Mon Jan 14 10:46:02 PST 2002
> >Originator: ritzert@t-online.de
> >Release: gcc version 3.1 20020114 (experimental)
> Linux 2.4.16, Athlon
> >Description:
> # gcc -c a.c -fprefetch-loop-arrays -march=athlon -O2
> a.c: In function `KDE_IceOpenConnection':
> a.c:15: unrecognizable insn:
> (insn 154 81 31 (prefetch (plus:SI (reg/f:SI 72)
> (const_int 384 [0x180]))
> (const_int 1 [0x1])
> (const_int 3 [0x3])) -1 (nil)
> (nil))
> a.c:15: Internal compiler error in extract_insn, at recog.c:2129
> Please submit a full bug report,
> with preprocessed source if appropriate.
> See <URL:http://www.gnu.org/software/gcc/bugs.html> for instructions.
This worked last week, but I think it broken with this patch:
2002-01-12 Richard Henderson <rth@redhat.com>
* config/i386/i386.c (override_options): If SSE, enable sse prefetch.
(ix86_expand_vector_move): New.
(bdesc_2arg): Remove andps, andnps, orps, xorps.
(ix86_init_mmx_sse_builtins): Make static. Remove composite builtins.
Remove old prefetch builtins. Special case the logicals removed above.
(ix86_expand_builtin): Likewise.
(safe_vector_operand): Use V4SFmode, not TImode.
(ix86_expand_store_builtin): Remove shuffle arg. Update callers.
(ix86_expand_timode_binop_builtin): New.
* config/i386/i386-protos.h: Update.
* config/i386/i386.h (enum ix86_builtins): Update.
* config/i386/i386.md: Correct predicates on MMX/SSE patterns.
Use ix86_expand_vector_move in vector move expanders.
(movti_internal, movti_rex64): Add xorps alternative.
(sse_clrv4sf): Rename and adjust from sse_clrti.
(prefetch): Don't work so hard.
(prefetch_sse, prefetch_3dnow): Use PREFETCH rtx, not UNSPEC.
* config/i386/xmmintrin.h (__m128): Use V4SFmode.
(_mm_getcsr, _mm_setcsr): Fix typo in builtin name.
The same problem is demonstrated with the following compiled with
-march=athlon:
void foo (int *p)
{
__builtin_prefetch (p, 1, 3);
}
Last week I submitted a patch with tests for __builtin_prefetch on ix86
targets; it has not yet been reviewed, although Honza looked at it and
verified that the behavior being checked is the expected behavior. The
prefetch support for specific ix86 cpus is complicated, which is why I
wrote these tests. When the tests were submitted on January 7 they all
passed, but today there are several failures. That patch is at
http://gcc.gnu.org/ml/gcc-patches/2002-01/msg00452.html.
Janis
^ permalink raw reply [flat|nested] 8+ messages in thread
* target/5378: ICE: unrecognizable insn prefetch
@ 2002-01-14 10:46 ritzert
0 siblings, 0 replies; 8+ messages in thread
From: ritzert @ 2002-01-14 10:46 UTC (permalink / raw)
To: gcc-gnats
>Number: 5378
>Category: target
>Synopsis: ICE: unrecognizable insn prefetch
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: unassigned
>State: open
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Mon Jan 14 10:46:02 PST 2002
>Closed-Date:
>Last-Modified:
>Originator: ritzert@t-online.de
>Release: gcc version 3.1 20020114 (experimental)
>Organization:
>Environment:
Linux 2.4.16, Athlon
>Description:
# gcc -c a.c -fprefetch-loop-arrays -march=athlon -O2
a.c: In function `KDE_IceOpenConnection':
a.c:15: unrecognizable insn:
(insn 154 81 31 (prefetch (plus:SI (reg/f:SI 72)
(const_int 384 [0x180]))
(const_int 1 [0x1])
(const_int 3 [0x3])) -1 (nil)
(nil))
a.c:15: Internal compiler error in extract_insn, at recog.c:2129
Please submit a full bug report,
with preprocessed source if appropriate.
See <URL:http://www.gnu.org/software/gcc/bugs.html> for instructions.
>How-To-Repeat:
Compile the attached file with
gcc -c a.c -fprefetch-loop-arrays -march=athlon -O2
>Fix:
Do not use optimization or -fprefetch-loop-arrays.
>Release-Note:
>Audit-Trail:
>Unformatted:
----gnatsweb-attachment----
Content-Type: text/x-csrc; name="a.c"
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="a.c"
dm9pZApLREVfSWNlT3BlbkNvbm5lY3Rpb24gKCkKewogICAgaW50IF9LREVfSWNlQXV0aENvdW50
OwogICAgaW50IGksIGo7CiAgICBpbnQgYXV0aFVzYWJsZUNvdW50OwogICAgaW50IGF1dGhVc2Fi
bGVGbGFnc1szMl07CgogICAgZm9yIChpID0gMDsgaSA8IF9LREVfSWNlQXV0aENvdW50OyBpKysp
CiAgICB7CiAgICAgICAgYXV0aFVzYWJsZUZsYWdzW2ldID0gMDsKICAgICAgICBmb3IgKGogPSAw
OyBqIDwgYXV0aFVzYWJsZUNvdW50OyBqKyspCiAgICAgICAgICAgIGF1dGhVc2FibGVGbGFnc1tp
XSA9IDA7CiAgICB9Cn0KCg==
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2002-01-22 3:48 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-01-21 19:48 target/5378: ICE: unrecognizable insn prefetch rodrigc
-- strict thread matches above, loose matches on Subject: below --
2002-01-15 9:26 Janis Johnson
2002-01-14 17:06 Richard Henderson
2002-01-14 16:56 Janis Johnson
2002-01-14 15:46 Richard Henderson
2002-01-14 13:26 Richard Henderson
2002-01-14 13:06 Janis Johnson
2002-01-14 10:46 ritzert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).