Re: libgcj/6187: method distance of class java.awt.geom.Point2D causes infinite recursion

Re: libgcj/6187: method distance of class java.awt.geom.Point2D causes infinite recursion

[tromey]

Synopsis: method distance of class java.awt.geom.Point2D causes infinite recursion

Responsible-Changed-From-To: unassigned->tromey
Responsible-Changed-By: tromey
Responsible-Changed-When: Mon Apr  8 07:47:38 2002
Responsible-Changed-Why:
    I'm handling this.
State-Changed-From-To: open->closed
State-Changed-By: tromey
State-Changed-When: Mon Apr  8 07:47:38 2002
State-Changed-Why:
    Thanks for your patch.
    I'm checking it in on the trunk.
    I'll try to check it in on the branch, too (so it will appear
    in 3.1), but that depends on the current branch status.

http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gcc&pr=6187

libgcj/6187: method distance of class java.awt.geom.Point2D causes infinite recursion

[alberto.biancardi]

>Number:         6187
>Category:       libgcj
>Synopsis:       method distance of class java.awt.geom.Point2D causes infinite recursion
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    unassigned
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Apr 05 06:56:00 PST 2002
>Closed-Date:
>Last-Modified:
>Originator:     alberto.biancardi@unipv.it
>Release:        3.0.4
>Organization:
>Environment:
i686-pc-linux-gnu
uname -r: 2.2.14-5.0
>Description:
the implementation of the static method distance
of class java.awt.geom.Point2D calls itself instead
of static method distanceSq thus causing an infinite
recursion and a stack overflow

>How-To-Repeat:
class TestPoint2D {
    public static void main(String[] args) {
	java.awt.geom.Point2D.distance( 0.0, 0.0, 1.0, 1.0);
    }
}
>Fix:
--- Point2D.java.orig	Mon Dec  4 03:27:21 2000
+++ Point2D.java	Fri Apr  5 16:05:39 2002
@@ -41,7 +41,7 @@
 
   static public double distance (double X1, double Y1, double X2, double Y2)
   {
-    return Math.sqrt(distance(X1, Y1, X2, Y2));
+    return Math.sqrt(distanceSq(X1, Y1, X2, Y2));
   }
 
   public double distanceSq (double PX, double PY)
>Release-Note:
>Audit-Trail:
>Unformatted: