Re: libstdc++/1072: Exception-unsafe code in locale

Re: libstdc++/1072: Exception-unsafe code in locale

[bkoz]

Synopsis: Exception-unsafe code in locale

Responsible-Changed-From-To: unassigned->bkoz
Responsible-Changed-By: bkoz
Responsible-Changed-When: Tue Apr  9 14:06:08 2002
Responsible-Changed-Why:
    Mine.
State-Changed-From-To: open->closed
State-Changed-By: bkoz
State-Changed-When: Tue Apr  9 14:06:08 2002
State-Changed-Why:
    Fixed with....
    
    2002-04-09  Benjamin Kosnik  <bkoz@redhat.com>
    
    	libstdc++/1072
    	* include/bits/localefwd.h (locale::_Impl::_M_facets): Change from
    	pointer to vector.
    	Remove forward declaration of vector.
    	Include vector.
    	* include/bits/locale_facets.tcc: Remove vector include.
    	(use_locale): Adjust.
    	(has_locale): Adjust.
    	* src/locale.cc: Adjust.
    	* src/localename.cc: Same.
    	
    
    Also, I audited the rest of the library code for this kind of stuff. I think we're ok now.
    
    thanks,
    -benjamin

http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gcc&pr=1072

Re: libstdc++/1072: Exception-unsafe code in locale

[Petter Reinholdtsen]

The following reply was made to PR libstdc++/1072; it has been noted by GNATS.

From: Petter Reinholdtsen <pere@hungry.com>
To: peturr@usa.net
Cc: gcc-gnats@gcc.gnu.org
Subject: Re: libstdc++/1072: Exception-unsafe code in locale
Date: Sun, 27 May 2001 13:19:26 +0200

 Here are a few comments from a simple gcc user.
 
 I checked the current source in CVS and compared it to the code in
 your bug report, and the code is different now.
 
 > These catch blocks are useless since the target pointers are never
 > modified if either operator new or the constructors throw an
 > exception.
 
 I believe this is correct.  The try/catch block is completely useless,
 and it would be better to use auto_ptr.
 
 > In fact, they will probably cause a crash since the pointers are not
 > initialized before the try block.
 
 This seem to be correct with gcc 2.95.2, but the C++ standard
 specifies the pointer member variables should be initialized to
 0. (Read clause 12.6.2, 8.5 and 3.9 to learn more).
 
 > Also, if an exception is thrown from the second try block, the
 > object allocated in the first one is leaked.
 
 This is correct, but seem to have been fixed.
 -- 
 ##>  Petter Reinholdtsen  <##  |  pere@hungry.com