public inbox for gcc-prs@sourceware.org
help / color / mirror / Atom feed
From: bkoz@gcc.gnu.org
To: bkoz@gcc.gnu.org, edh@twcny.rr.com, gcc-bugs@gcc.gnu.org,
	gcc-prs@gcc.gnu.org, nobody@gcc.gnu.org
Subject: Re: libstdc++/6594: strstreambuf leaks 16 bytes - gcc 3.0.x
Date: Wed, 15 May 2002 05:57:00 -0000	[thread overview]
Message-ID: <20020515125731.12862.qmail@sources.redhat.com> (raw)

Synopsis: strstreambuf leaks 16 bytes - gcc 3.0.x

Responsible-Changed-From-To: unassigned->bkoz
Responsible-Changed-By: bkoz
Responsible-Changed-When: Wed May 15 05:57:30 2002
Responsible-Changed-Why:
    Mine.
State-Changed-From-To: open->feedback
State-Changed-By: bkoz
State-Changed-When: Wed May 15 05:57:30 2002
State-Changed-Why:
    So it does....
    
    strstream.cc: 69 has
    
    strstreambuf::strstreambuf(streamsize initial_capacity)
      : _Base(),
        _M_alloc_fun(0), _M_free_fun(0),
        _M_dynamic(true), _M_frozen(false), _M_constant(false)
    {
      streamsize n = max(initial_capacity, streamsize(16));
    
      char* buf = _M_alloc(n);
      if (buf) {
        setp(buf, buf + n);
        setg(buf, buf, buf);
      }
    
    Wow. 
    
    Are you aware that this class has been deprecated by std::stringstream? You might consider using it instead.
    
    However, it turns out that the bug is pretty easy to fix. You might try this, and let me know how it goes. 
    
    2002-05-15  Benjamin Kosnik  <bkoz@redhat.com>
    
    	PR libstdc++/6594
    	* src/strstream.cc (strstreambuf): Fix leak.
    
    The patch is here:
    http://gcc.gnu.org/ml/gcc-patches/2002-05/msg01204.html
    
    best,
    benjamin

http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gcc&pr=6594


             reply	other threads:[~2002-05-15 12:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-05-15  5:57 bkoz [this message]
  -- strict thread matches above, loose matches on Subject: below --
2003-01-07 16:24 bkoz
2002-08-02 13:51 bkoz
2002-05-17  3:09 bkoz
2002-05-15 17:36 Ed Hourigan
2002-05-07  7:56 edh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020515125731.12862.qmail@sources.redhat.com \
    --to=bkoz@gcc.gnu.org \
    --cc=edh@twcny.rr.com \
    --cc=gcc-bugs@gcc.gnu.org \
    --cc=gcc-gnats@gcc.gnu.org \
    --cc=gcc-prs@gcc.gnu.org \
    --cc=nobody@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).