Re: objc/5587: Objc problems with user_label_prefix

Re: objc/5587: Objc problems with user_label_prefix

[Krister Walfridsson]

The following reply was made to PR objc/5587; it has been noted by GNATS.

From: Krister Walfridsson <cato@df.lth.se>
To: neil@gcc.gnu.org, <cato@df.lth.se>, <gcc-bugs@gcc.gnu.org>,
   <gcc-prs@gcc.gnu.org>, <nobody@gcc.gnu.org>, <shebs@gcc.gnu.org>,
   <gcc-gnats@gcc.gnu.org>
Cc:  
Subject: Re: objc/5587: Objc problems with user_label_prefix
Date: Thu, 16 May 2002 02:11:25 +0200 (MEST)

 On 15 May 2002 neil@gcc.gnu.org wrote:
 
 > Synopsis: Objc problems with user_label_prefix
 >
 > Responsible-Changed-From-To: unassigned->shebs
 > Responsible-Changed-By: neil
 > Responsible-Changed-When: Wed May 15 01:16:27 2002
 > Responsible-Changed-Why:
 >     Stan - would you look at this?  It appears to be a minor
 >     regression from one of your patches.
 >
 > http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gcc&pr=5587
 >
 
 Those test-suite failures went away some time ago, so I guess the problem
 is already solved.
 
    /Krister
 

Re: objc/5587: Objc problems with user_label_prefix

[neil]

Synopsis: Objc problems with user_label_prefix

State-Changed-From-To: open->closed
State-Changed-By: neil
State-Changed-When: Wed May 15 22:51:23 2002
State-Changed-Why:
    Reported fixed by submitter.

http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gcc&pr=5587

Re: objc/5587: Objc problems with user_label_prefix

[neil]

Synopsis: Objc problems with user_label_prefix

Responsible-Changed-From-To: unassigned->shebs
Responsible-Changed-By: neil
Responsible-Changed-When: Wed May 15 01:16:27 2002
Responsible-Changed-Why:
    Stan - would you look at this?  It appears to be a minor
    regression from one of your patches.

http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gcc&pr=5587

objc/5587: Objc problems with user_label_prefix

[cato]

>Number:         5587
>Category:       objc
>Synopsis:       Objc problems with user_label_prefix
>Confidential:   no
>Severity:       critical
>Priority:       medium
>Responsible:    unassigned
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Feb 04 11:06:08 PST 2002
>Closed-Date:
>Last-Modified:
>Originator:     Krister Walfridsson
>Release:        gcc version 3.1 20020201 (experimental)
>Organization:
>Environment:
arm-unknown-netbsd1.5Y
Configured with: ../gcc/configure --disable-nls
>Description:
The objc testsuite fails most of the tests (and of course real programs too)
for arm/netbsd because the compiler cannot decide if it should add the
user_label_prefix or not to __objc_class_name_XXX. This used to work, but
was changed in the cleanup

   2001-06-27  Stan Shebs  <shebs@apple.com>
           * objc/objc-act.c (handle_impent): Rewrite to be more portable
           and to use ASM_DECLARE_CLASS_REFERENCE.

The patch below corrects the construction of the label names.
>How-To-Repeat:
Run the objc test-suite on arm-unknown-netbsd1.5Y (or any other target that uses user_label_prefix?)

See for example http://gcc.gnu.org/ml/gcc-testresults/2002-02/msg00035.html
>Fix:
2002-02-03  Krister Walfridsson  <cato@df.lth.se>

        * objc/objc-act.c (handle_impent): Remove '*' from label names.


Index: gcc/gcc/objc/objc-act.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/objc/objc-act.c,v
retrieving revision 1.124
diff -c -3 -p -r1.124 objc-act.c
*** objc-act.c  2002/01/29 17:19:56     1.124
--- objc-act.c  2002/02/03 22:56:43
*************** handle_impent (impent)
*** 8323,8329 ****
  
        string = (char *) alloca (strlen (class_name) + 30);
  
!       sprintf (string, "*%sobjc_class_name_%s",
                 (flag_next_runtime ? "." : "__"), class_name);
      }
    else if (TREE_CODE (impent->imp_context) == CATEGORY_IMPLEMENTATION_TYPE)
--- 8323,8329 ----
  
        string = (char *) alloca (strlen (class_name) + 30);
  
!       sprintf (string, "%sobjc_class_name_%s",
                 (flag_next_runtime ? "." : "__"), class_name);
      }
    else if (TREE_CODE (impent->imp_context) == CATEGORY_IMPLEMENTATION_TYPE)
*************** handle_impent (impent)
*** 8339,8345 ****
        /* Do the same for categories.  Even though no references to
           these symbols are generated automatically by the compiler, it
           gives you a handle to pull them into an archive by hand.  */
!       sprintf (string, "*%sobjc_category_name_%s_%s",
                 (flag_next_runtime ? "." : "__"), class_name, class_super_name);
      }
    else
--- 8339,8345 ----
        /* Do the same for categories.  Even though no references to
           these symbols are generated automatically by the compiler, it
           gives you a handle to pull them into an archive by hand.  */
!       sprintf (string, "%sobjc_category_name_%s_%s",
                 (flag_next_runtime ? "." : "__"), class_name, class_super_name);
      }
    else
>Release-Note:
>Audit-Trail:
>Unformatted: