libstdc++/6701: do_narrow on range is fubar

libstdc++/6701: do_narrow on range is fubar

[dale]

>Number:         6701
>Category:       libstdc++
>Synopsis:       do_narrow on range is fubar
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    unassigned
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri May 17 10:16:00 PDT 2002
>Closed-Date:
>Last-Modified:
>Originator:     Dale Peakall
>Release:        gcc 3.1 20020510 (prerelease)
>Organization:
>Environment:
solaris 8
>Description:
The implementation of do_narrow in ctype.cc for a range:
1) always changes the first character to the default char
2) doesn't narrow the whole string if a non-ascii char is
   found

22.2.1.1.2 para 13 of the C++ standard states:

The second form [range form] transforms each character *p
in the range [low, high), placing the result (or dfault if
no simple transformation is readily available) in dest[p-low].
>How-To-Repeat:
std::wstring wide(L"wibble");
std::vector<char> narrow_chars(wide.length() + 1);

std::locale loc;
std::use_facet<std::ctype<wchar_t> >(loc).narrow(
   &wide[0], &wide[wide.length()], '?', &narrow_chars[0]);
>Fix:
  const wchar_t*
  ctype<wchar_t>::
  do_narrow(const wchar_t* __lo, const wchar_t* __hi, char __dfault, 
	    char* __dest) const
  {
    size_t __offset = 0;
    
    for(;;)
    {
      const wchar_t* __start = __lo + __offset;        
      size_t __len = __hi - __start;

      mbstate_t __state;
      memset(static_cast<void*>(&__state), 0, sizeof(mbstate_t));
      size_t __conv = wcsrtombs(__dest + __offset, &__start, __len, &__state);
      if(__conv != __len && __start != 0)
      {
          __offset = __start - __lo;          
          __dest[__offset++] = __dfault;
      }
      else
          break;
    }
      
    return __hi;
  }
>Release-Note:
>Audit-Trail:
>Unformatted:

Re: libstdc++/6701: do_narrow on range is fubar

[bkoz]

Synopsis: do_narrow on range is fubar

Responsible-Changed-From-To: unassigned->bkoz
Responsible-Changed-By: bkoz
Responsible-Changed-When: Mon May 27 02:33:05 2002
Responsible-Changed-Why:
    Mine.
State-Changed-From-To: open->closed
State-Changed-By: bkoz
State-Changed-When: Mon May 27 02:33:05 2002
State-Changed-Why:
    Fixed.

http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gcc&pr=6701