Re: libstdc++/6795: stringbuf failure

Re: libstdc++/6795: stringbuf failure

[Benjamin Kosnik]

The following reply was made to PR libstdc++/6795; it has been noted by GNATS.

From: Benjamin Kosnik <bkoz@redhat.com>
To: Stein Somers <ssomers@opnet.com>
Cc: bkoz@gcc.gnu.org, gcc-bugs@gcc.gnu.org, gcc-prs@gcc.gnu.org,
   nobody@gcc.gnu.org, ssomers@opnet.com, gcc-gnats@gcc.gnu.org
Subject: Re: libstdc++/6795: stringbuf failure
Date: Wed, 29 May 2002 02:10:53 -0700

 > Yes, that solves the problem!  Now all of my tests succeed.  Thanks.
 
 Great! Thanks, I've closed this PR.
 
 > Probably a silly remark - I have no prior experience with cvs and how
 > the gcc team uses it - but I've checked out the sources with "-r 
 > cvs_latest_snapshot" and without -r, and both gave the old version, so
 > I corrected it manually.
 
 Hmm. Ok. You might want to post to overseers@sources.redhat.com with
 this info, as I am most definitely not a CVS guru.
 
 -benjamin

Re: libstdc++/6795: stringbuf failure

[bkoz]

Synopsis: stringbuf failure

State-Changed-From-To: feedback->closed
State-Changed-By: bkoz
State-Changed-When: Wed May 29 02:01:56 2002
State-Changed-Why:
    Fixed.

http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gcc&pr=6795

Re: libstdc++/6795: stringbuf failure

[Stein Somers]

The following reply was made to PR libstdc++/6795; it has been noted by GNATS.

From: Stein Somers <ssomers@opnet.com>
To: bkoz@gcc.gnu.org, bkoz@gcc.gnu.org, gcc-bugs@gcc.gnu.org,
	gcc-prs@gcc.gnu.org, nobody@gcc.gnu.org, ssomers@opnet.com,
	gcc-gnats@gcc.gnu.org
Cc:  
Subject: Re: libstdc++/6795: stringbuf failure
Date: Mon, 27 May 2002 21:11:41 +0200

 At 27-05-02 11:37 +0000, you wrote:
 >Synopsis: stringbuf failure
 >
 >Responsible-Changed-From-To: unassigned->bkoz
 >Responsible-Changed-By: bkoz
 >Responsible-Changed-When: Mon May 27 04:37:54 2002
 >Responsible-Changed-Why:
 >     Mine.
 >State-Changed-From-To: open->feedback
 >State-Changed-By: bkoz
 >State-Changed-When: Mon May 27 04:37:54 2002
 >State-Changed-Why:
 
 Yes, that solves the problem!  Now all of my tests succeed.  Thanks.
 
 Probably a silly remark - I have no prior experience with cvs and how the 
 gcc team uses it - but I've checked out the sources with "-r 
 cvs_latest_snapshot" and without -r, and both gave the old version, so I 
 corrected it manually.
 
 Stein
 

Re: libstdc++/6795: stringbuf failure

[bkoz]

Synopsis: stringbuf failure

Responsible-Changed-From-To: unassigned->bkoz
Responsible-Changed-By: bkoz
Responsible-Changed-When: Mon May 27 04:37:54 2002
Responsible-Changed-Why:
    Mine.
State-Changed-From-To: open->feedback
State-Changed-By: bkoz
State-Changed-When: Mon May 27 04:37:54 2002
State-Changed-Why:
    I cannot reproduce this with gcc-3.1 or gcc-3.2 sources on x86/linux.
    
    There seem to be a number of input failures for Solaris 5.6 hosts. I'm not quite sure what they are, but you might look at the differences between the ctype_base.h and ctype_noninline files between gcc-3.0.x and gcc-3.1.x: perhaps that is it.
    
    Never mind. I've done it myself and fixed the obvious error. I'll commit it, and ask you to try either 3.1 or 3.2 sources and confirm the fix.
    
    This should fix the solaris 2.5 and 2.6 issues.
    
    thanks for your patience,
    benjamin
    
    
    2002-05-27  Benjamin Kosnik  <bkoz@redhat.com>
    
    	PR libstdc++/6795.
    	* config/os/solaris/solaris2.6/bits/ctype_noninline.h
    	(classic_table): Fix.
    	* config/os/solaris/solaris2.5/bits/ctype_noninline.h: Same.
    
    Index: config/os/solaris/solaris2.5/bits/ctype_noninline.h
    ===================================================================
    RCS file: /cvs/gcc/gcc/libstdc++-v3/config/os/solaris/solaris2.5/bits/ctype_noninline.h,v
    retrieving revision 1.8
    diff -c -p -r1.8 ctype_noninline.h
    *** config/os/solaris/solaris2.5/bits/ctype_noninline.h	13 Mar 2002 02:32:04 -0000	1.8
    --- config/os/solaris/solaris2.5/bits/ctype_noninline.h	27 May 2002 11:36:47 -0000
    ***************
    *** 35,41 ****
      
        const ctype_base::mask*
        ctype<char>::classic_table() throw()
    !   { return 0; }
      
        ctype<char>::ctype(__c_locale, const mask* __table, bool __del, 
      		     size_t __refs) 
    --- 35,41 ----
      
        const ctype_base::mask*
        ctype<char>::classic_table() throw()
    !   { return __ctype; }
      
        ctype<char>::ctype(__c_locale, const mask* __table, bool __del, 
      		     size_t __refs) 
    Index: config/os/solaris/solaris2.6/bits/ctype_noninline.h
    ===================================================================
    RCS file: /cvs/gcc/gcc/libstdc++-v3/config/os/solaris/solaris2.6/bits/ctype_noninline.h,v
    retrieving revision 1.9
    diff -c -p -r1.9 ctype_noninline.h
    *** config/os/solaris/solaris2.6/bits/ctype_noninline.h	13 Mar 2002 02:32:05 -0000	1.9
    --- config/os/solaris/solaris2.6/bits/ctype_noninline.h	27 May 2002 11:36:47 -0000
    ***************
    *** 35,41 ****
        
        const ctype_base::mask*
        ctype<char>::classic_table() throw()
    !   { return 0; }  
      
        ctype<char>::ctype(__c_locale, const mask* __table, bool __del, 
      		     size_t __refs) 
    --- 35,41 ----
        
        const ctype_base::mask*
        ctype<char>::classic_table() throw()
    !   { return __ctype_mask; }  
      
        ctype<char>::ctype(__c_locale, const mask* __table, bool __del, 
      		     size_t __refs) 

http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gcc&pr=6795