public inbox for gcc-prs@sourceware.org
help / color / mirror / Atom feed
From: mendell@ca.ibm.com
To: gcc-gnats@gcc.gnu.org
Subject: c++/7459: Missing '*' in unwind-dw2.c ?
Date: Wed, 31 Jul 2002 13:16:00 -0000	[thread overview]
Message-ID: <20020731200842.21520.qmail@sources.redhat.com> (raw)


>Number:         7459
>Category:       c++
>Synopsis:       Missing '*' in unwind-dw2.c ?
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    unassigned
>State:          open
>Class:          wrong-code
>Submitter-Id:   net
>Arrival-Date:   Wed Jul 31 13:16:00 PDT 2002
>Closed-Date:
>Last-Modified:
>Originator:     Mark Mendell
>Release:        gcc 3.1
>Organization:
>Environment:
Linux/PPC
>Description:
In routine uw_update_context_1, there is code:
    switch (fs->regs.reg[i].how)
      {
      case REG_UNSAVED:
        break;
      case REG_SAVED_OFFSET:
        context->reg[i] = cfa + fs->regs.reg[i].loc.offset;
        break;
      ...

Should the case for REG_SAVED_OFFSET be indirecting the value?  It seems that you are saving the address of the value, not the value itself.  This is inconsistent with the
other cases in the switch.
>How-To-Repeat:

>Fix:

>Release-Note:
>Audit-Trail:
>Unformatted:


             reply	other threads:[~2002-07-31 20:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-07-31 13:16 mendell [this message]
2002-12-19 18:23 bangerth
2003-01-09  3:06 mendell
2003-01-09 15:05 bangerth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020731200842.21520.qmail@sources.redhat.com \
    --to=mendell@ca.ibm.com \
    --cc=gcc-gnats@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).