c++/7459: Missing '*' in unwind-dw2.c ?

c++/7459: Missing '*' in unwind-dw2.c ?

[mendell]

>Number:         7459
>Category:       c++
>Synopsis:       Missing '*' in unwind-dw2.c ?
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    unassigned
>State:          open
>Class:          wrong-code
>Submitter-Id:   net
>Arrival-Date:   Wed Jul 31 13:16:00 PDT 2002
>Closed-Date:
>Last-Modified:
>Originator:     Mark Mendell
>Release:        gcc 3.1
>Organization:
>Environment:
Linux/PPC
>Description:
In routine uw_update_context_1, there is code:
    switch (fs->regs.reg[i].how)
      {
      case REG_UNSAVED:
        break;
      case REG_SAVED_OFFSET:
        context->reg[i] = cfa + fs->regs.reg[i].loc.offset;
        break;
      ...

Should the case for REG_SAVED_OFFSET be indirecting the value?  It seems that you are saving the address of the value, not the value itself.  This is inconsistent with the
other cases in the switch.
>How-To-Repeat:

>Fix:

>Release-Note:
>Audit-Trail:
>Unformatted:

Re: c++/7459: Missing '*' in unwind-dw2.c ?

[bangerth]

Synopsis: Missing '*' in unwind-dw2.c ?

State-Changed-From-To: feedback->closed
State-Changed-By: bangerth
State-Changed-When: Thu Jan  9 07:05:03 2003
State-Changed-Why:
    On request of submitter.

http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gcc&pr=7459

Re: c++/7459: Missing '*' in unwind-dw2.c ?

[mendell]

The following reply was made to PR c++/7459; it has been noted by GNATS.

From: mendell@ca.ibm.com
To: bangerth@dealii.org, gcc-bugs@gcc.gnu.org, gcc-prs@gcc.gnu.org,
   nobody@gcc.gnu.org, gcc-gnats@gcc.gnu.org
Cc:  
Subject: Re: c++/7459: Missing '*' in unwind-dw2.c ?
Date: Wed, 8 Jan 2003 22:05:26 -0500

 This is a multipart message in MIME format.
 --=_alternative 0010FB8C85256CA9_=
 Content-Type: text/plain; charset="US-ASCII"
 
 Originally, I was under the impression that the actual values of the 
 registers were stored in the context, but in fact the address is.  In 
 fact, there is no method to see if a register has been saved, as the 
 standard query will segmentation fault if asking about an unsaved 
 register.
 
 You may cancel the bug report.  I would do so if I had any idea how to do 
 so.  There is no 'Edit' button in my gnatsweb screen.
 
 Mark
 
 
 
 
 bangerth@dealii.org
 19/12/2002 09:23 PM
 Please respond to bangerth; Please respond to gcc-bugs; Please respond to 
 gcc-prs; Please respond to Mark Mendell; Please respond to nobody; Please 
 respond to gcc-gnats
 
 
 To
 gcc-bugs@gcc.gnu.org, gcc-prs@gcc.gnu.org, Mark Mendell/Toronto/IBM@IBMCA, 
 nobody@gcc.gnu.org
 cc
 
 bcc
 
 Subject
 Re: c++/7459: Missing '*' in unwind-dw2.c ?
 
 
 
 Synopsis: Missing '*' in unwind-dw2.c ?
 
 State-Changed-From-To: open->feedback
 State-Changed-By: bangerth
 State-Changed-When: Thu Dec 19 18:23:48 2002
 State-Changed-Why:
     Mark,
     I have looked so often at this report, and never really
     understood it. Could you describe a little bit in more
     detail why you think this?
  
     Unfortunately, cvs annotate does not tell who wrote
     the code, so I cannot CC: anyone with more knowledge :-(
  
     Thanks
       Wolfgang
 
 http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gcc&pr=7459
 
 
 
 --=_alternative 0010FB8C85256CA9_=
 Content-Type: text/html; charset="US-ASCII"
 
 
 <br><font size=2 face="sans-serif">Originally, I was under the impression
 that the actual values of the registers were stored in the context, but
 in fact the address is. &nbsp;In fact, there is no method to see if a register
 has been saved, as the standard query will segmentation fault if asking
 about an unsaved register.</font>
 <br>
 <br><font size=2 face="sans-serif">You may cancel the bug report. &nbsp;I
 would do so if I had any idea how to do so. &nbsp;There is no 'Edit' button
 in my gnatsweb screen.</font>
 <br>
 <br><font size=2 face="sans-serif">Mark</font>
 <br>
 <br>
 <br>
 <br>
 <table width=100%>
 <tr valign=top>
 <td width=37%><font size=1 face="sans-serif"><b>bangerth@dealii.org</b></font>
 <p><font size=1 face="sans-serif">19/12/2002 09:23 PM</font>
 <table border>
 <tr valign=top>
 <td bgcolor=white>
 <div align=center><font size=1 face="sans-serif">Please respond to bangerth;
 Please respond to gcc-bugs; Please respond to gcc-prs; Please respond to
 Mark Mendell; Please respond to nobody; Please respond to gcc-gnats</font></div></table>
 <br>
 <td width=62%>
 <table width=100%>
 <tr valign=top>
 <td width=9%>
 <div align=right><font size=1 face="sans-serif">To</font></div>
 <td width=90%><font size=1 face="sans-serif">gcc-bugs@gcc.gnu.org, gcc-prs@gcc.gnu.org,
 Mark Mendell/Toronto/IBM@IBMCA, nobody@gcc.gnu.org</font>
 <tr valign=top>
 <td>
 <div align=right><font size=1 face="sans-serif">cc</font></div>
 <td>
 <tr valign=top>
 <td>
 <div align=right><font size=1 face="sans-serif">bcc</font></div>
 <td>
 <tr valign=top>
 <td>
 <div align=right><font size=1 face="sans-serif">Subject</font></div>
 <td><font size=1 face="sans-serif">Re: c++/7459: Missing '*' in unwind-dw2.c
 ?</font></table>
 <br></table>
 <br>
 <br>
 <br><font size=2><tt>Synopsis: Missing '*' in unwind-dw2.c ?<br>
 <br>
 State-Changed-From-To: open-&gt;feedback<br>
 State-Changed-By: bangerth<br>
 State-Changed-When: Thu Dec 19 18:23:48 2002<br>
 State-Changed-Why:<br>
  &nbsp; &nbsp;Mark,<br>
  &nbsp; &nbsp;I have looked so often at this report, and never really<br>
  &nbsp; &nbsp;understood it. Could you describe a little bit in more<br>
  &nbsp; &nbsp;detail why you think this?<br>
  &nbsp; &nbsp;<br>
  &nbsp; &nbsp;Unfortunately, cvs annotate does not tell who wrote<br>
  &nbsp; &nbsp;the code, so I cannot CC: anyone with more knowledge :-(<br>
  &nbsp; &nbsp;<br>
  &nbsp; &nbsp;Thanks<br>
  &nbsp; &nbsp; &nbsp;Wolfgang<br>
 <br>
 http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&amp;database=gcc&amp;pr=7459<br>
 </tt></font>
 <br>
 --=_alternative 0010FB8C85256CA9_=--

Re: c++/7459: Missing '*' in unwind-dw2.c ?

[bangerth]

Synopsis: Missing '*' in unwind-dw2.c ?

State-Changed-From-To: open->feedback
State-Changed-By: bangerth
State-Changed-When: Thu Dec 19 18:23:48 2002
State-Changed-Why:
    Mark,
    I have looked so often at this report, and never really
    understood it. Could you describe a little bit in more
    detail why you think this?
    
    Unfortunately, cvs annotate does not tell who wrote
    the code, so I cannot CC: anyone with more knowledge :-(
    
    Thanks
      Wolfgang

http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gcc&pr=7459