c/7543: Suggest new warning message for gcc

c/7543: Suggest new warning message for gcc

[trt]

>Number:         7543
>Category:       c
>Synopsis:       Suggest new warning message for gcc
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    unassigned
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Thu Aug 08 09:06:00 PDT 2002
>Closed-Date:
>Last-Modified:
>Originator:     Tom Truscott
>Release:        gcc version 2.96 20000731 (Red Hat Linux 7.1 2.96-81)
>Organization:
>Environment:

>Description:
gcc currently does not warn about the logic error
in the following program:

int subr(int flags)
{
   return (!flags & 0x80) ? 1 : 0;
}


It should have been (!(flags & 0x80))

>How-To-Repeat:
Compile the above program, with -W -Wall, whatever.
No warning message.
>Fix:
A patch to gcc which gives a warning in this situation appears in
http://gcc.gnu.org/ml/gcc-patches/2002-06/msg01523.html
>Release-Note:
>Audit-Trail:
>Unformatted:

Re: c/7543: Suggest new warning message for gcc

[Wolfgang Bangerth]

The following reply was made to PR c/7543; it has been noted by GNATS.

From: Wolfgang Bangerth <bangerth@ticam.utexas.edu>
To: gcc-gnats@gcc.gnu.org
Cc:  
Subject: Re: c/7543: Suggest new warning message for gcc
Date: Mon, 10 Mar 2003 14:46:47 -0600 (CST)

 ---------- Forwarded message ----------
 Date: Fri, 7 Mar 2003 11:43:55 -0500 (EST)
 From: Tom Truscott <trt@unx.sas.com>
 To: bangerth@dealii.org
 Subject: Re: c/7543: Suggest new warning message for gcc
 
 >     Tom, did your patch get applied to CVS? What's the state of
 >     this?
 
 I don't know if it was applied, but I strongly doubt it.
 
 The state of this is totally defunct.
 I have tried different request strategies for a few years
 and have concluded that only if I become a gcc insider
 can I get even the simplest changes made.
 I don't have the time, energy, or interest in that.
 
 I'm content with the dozens of a warnings I've added
 to my personal copy of gcc, which I run daily
 to spot problems in my company's product (20M+ LOC).
 
 If there is a gcc insider who would like to shepherd
 specific warning changes I will be happy to supply them.
 Beyond that I'm not interested, not even in discussing this,
 so feel to mark this bug NOFIX or whatever.
 
 Thanks,
 Tom Truscott
 

Re: c/7543: Suggest new warning message for gcc

[bangerth]

Synopsis: Suggest new warning message for gcc

State-Changed-From-To: feedback->analyzed
State-Changed-By: bangerth
State-Changed-When: Mon Mar 10 20:50:11 2003
State-Changed-Why:
    I checked it, the patch is not applied.

http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gcc&pr=7543

Re: c/7543: Suggest new warning message for gcc

[bangerth]

Synopsis: Suggest new warning message for gcc

State-Changed-From-To: open->feedback
State-Changed-By: bangerth
State-Changed-When: Fri Mar  7 02:48:27 2003
State-Changed-Why:
    Tom, did your patch get applied to CVS? What's the state of
    this?
    Thanks
      Wolfgang

http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gcc&pr=7543