public inbox for gcc-prs@sourceware.org
help / color / mirror / Atom feed
* Re: libgcj/7785: Calendar.getTimeInMillis/setTimeInMillis should be public
@ 2002-08-30 22:26 Tom Tromey
0 siblings, 0 replies; 4+ messages in thread
From: Tom Tromey @ 2002-08-30 22:26 UTC (permalink / raw)
To: tromey; +Cc: gcc-prs
The following reply was made to PR libgcj/7785; it has been noted by GNATS.
From: Tom Tromey <tromey@redhat.com>
To: jmr@ugcs.caltech.edu
Cc: gcc-gnats@gcc.gnu.org
Subject: Re: libgcj/7785: Calendar.getTimeInMillis/setTimeInMillis should be public
Date: 30 Aug 2002 23:24:34 -0600
>> Synopsis: Calendar.getTimeInMillis/setTimeInMillis should be public
Thanks. I'll make this change shortly.
I'm also going to add a bit of javadoc. These methods were made
public in 1.4.
Tom
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: libgcj/7785: Calendar.getTimeInMillis/setTimeInMillis should be public
@ 2002-08-30 22:36 Tom Tromey
0 siblings, 0 replies; 4+ messages in thread
From: Tom Tromey @ 2002-08-30 22:36 UTC (permalink / raw)
To: tromey; +Cc: gcc-prs
The following reply was made to PR libgcj/7785; it has been noted by GNATS.
From: Tom Tromey <tromey@redhat.com>
To: jmr@ugcs.caltech.edu
Cc: gcc-gnats@gcc.gnu.org
Subject: Re: libgcj/7785: Calendar.getTimeInMillis/setTimeInMillis should be public
Date: 30 Aug 2002 23:25:08 -0600
>> Synopsis: Calendar.getTimeInMillis/setTimeInMillis should be public
Also, FYI: just send patches like this with a ChangeLog entry to the
java-patches list. There's no need for a PR for them.
Tom
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: libgcj/7785: Calendar.getTimeInMillis/setTimeInMillis should be public
@ 2002-08-30 22:26 tromey
0 siblings, 0 replies; 4+ messages in thread
From: tromey @ 2002-08-30 22:26 UTC (permalink / raw)
To: gcc-bugs, gcc-prs, java-prs, jmr, nobody, tromey
Synopsis: Calendar.getTimeInMillis/setTimeInMillis should be public
Responsible-Changed-From-To: unassigned->tromey
Responsible-Changed-By: tromey
Responsible-Changed-When: Fri Aug 30 22:24:42 2002
Responsible-Changed-Why:
I'm handling this.
State-Changed-From-To: open->closed
State-Changed-By: tromey
State-Changed-When: Fri Aug 30 22:24:42 2002
State-Changed-Why:
I'm checking this in along with a javadoc update.
Thanks.
http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gcc&pr=7785
^ permalink raw reply [flat|nested] 4+ messages in thread
* libgcj/7785: Calendar.getTimeInMillis/setTimeInMillis should be public
@ 2002-08-30 20:56 jmr
0 siblings, 0 replies; 4+ messages in thread
From: jmr @ 2002-08-30 20:56 UTC (permalink / raw)
To: gcc-gnats
>Number: 7785
>Category: libgcj
>Synopsis: Calendar.getTimeInMillis/setTimeInMillis should be public
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: unassigned
>State: open
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Fri Aug 30 19:46:00 PDT 2002
>Closed-Date:
>Last-Modified:
>Originator: Jesse Rosenstock
>Release: 3.3 20020828 (experimental)
>Organization:
>Environment:
System: Linux churchill 2.4.3-12 #1 Fri Jun 8 15:05:56 EDT 2001 i686 unknown
Architecture: i686
host: i686-pc-linux-gnu
build: i686-pc-linux-gnu
target: i686-pc-linux-gnu
configured with: ../gcc/configure --prefix=/home/user/jmr/app/gcc --enable-langs=c++,java --enable-shared --enable-threads=posix --with-as=/home/user/jmr/app/binutils/bin/as --with-ld=/home/user/jmr/app/binutils/bin/ld : (reconfigured)
>Description:
Both Calendar.getTimeInMillis and Calendar.setTimeInMillis are
specified as public in Sun's javadoc, but libjava declares them
as protected.
>How-To-Repeat:
>Fix:
--- Calendar.java 18 Jun 2002 15:39:48 -0000 1.13
+++ Calendar.java 31 Aug 2002 02:41:16 -0000
@@ -505,7 +505,7 @@
* Returns the time represented by this Calendar.
* @return the time in milliseconds since the epoch.
*/
- protected long getTimeInMillis()
+ public long getTimeInMillis()
{
if (!isTimeSet)
computeTime();
@@ -517,7 +517,7 @@
* are invalidated by this method.
* @param time the time in milliseconds since the epoch
*/
- protected void setTimeInMillis(long time)
+ public void setTimeInMillis(long time)
{
this.time = time;
isTimeSet = true;
>Release-Note:
>Audit-Trail:
>Unformatted:
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2002-08-31 5:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-08-30 22:26 libgcj/7785: Calendar.getTimeInMillis/setTimeInMillis should be public Tom Tromey
-- strict thread matches above, loose matches on Subject: below --
2002-08-30 22:36 Tom Tromey
2002-08-30 22:26 tromey
2002-08-30 20:56 jmr
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).