public inbox for gcc-prs@sourceware.org
help / color / mirror / Atom feed
From: Gabriel Dos Reis <gdr@integrable-solutions.net>
To: bkoz@gcc.gnu.org
Cc: gcc-prs@gcc.gnu.org,
Subject: Re: libstdc++/8230: Buggy allocator behaviour
Date: Wed, 20 Nov 2002 23:03:00 -0000 [thread overview]
Message-ID: <20021114204603.8814.qmail@sources.redhat.com> (raw)
The following reply was made to PR libstdc++/8230; it has been noted by GNATS.
From: Gabriel Dos Reis <gdr@integrable-solutions.net>
To: Benjamin Kosnik <bkoz@redhat.com>
Cc: bkoz@gcc.gnu.org, gcc-bugs@gcc.gnu.org, jkanze@caicheuvreux.com,
gcc-gnats@gcc.gnu.org, libstdc++@gcc.gnu.org
Subject: Re: libstdc++/8230: Buggy allocator behaviour
Date: 14 Nov 2002 21:39:50 +0100
Benjamin Kosnik <bkoz@redhat.com> writes:
| See attached patch for a way to fix this with the pool allocators.
I agree with your patch.
The following comment is for possible improvements. What about using
if (__builtin_expect(__ret == 0, 0))
__throw_bad_alloc("allocate::allocate");
?
That gives a hint to the compiler that the branch is expected to be
taken very unfrequently, and it should make scheduling accordingly.
In general, I would like to see us starting using use __builtin_expect()
at places where we do checks for limits cases. Thoughts?
-- Gaby
next reply other threads:[~2002-11-14 20:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-20 23:03 Gabriel Dos Reis [this message]
-- strict thread matches above, loose matches on Subject: below --
2002-11-23 1:16 bkoz
2002-11-21 14:01 Richard Henderson
2002-11-21 4:06 Gabriel Dos Reis
2002-11-21 3:47 Matt Austern
2002-11-20 19:09 Gabriel Dos Reis
2002-11-20 18:20 Benjamin Kosnik
2002-11-20 18:19 Benjamin Kosnik
2002-11-20 18:02 Gabriel Dos Reis
2002-11-20 5:07 bkoz
2002-10-15 5:56 gdr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021114204603.8814.qmail@sources.redhat.com \
--to=gdr@integrable-solutions.net \
--cc=bkoz@gcc.gnu.org \
--cc=gcc-prs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).