Re: c/6815: [3.2/3.3 regression] ICE with longjmp if -fprofile-arcs -O is specified

Re: c/6815: [3.2/3.3 regression] ICE with longjmp if -fprofile-arcs -O is specified

[Christian Ehrhardt]

The following reply was made to PR c/6815; it has been noted by GNATS.

From: "Christian Ehrhardt" <ehrhardt@mathematik.uni-ulm.de>
To: gcc-gnats@gcc.gnu.org, gcc-prs@gcc.gnu.org, gcc-bugs@gcc.gnu.org,
  nobody@gcc.gnu.org, dtucker@zip.com.au
Cc: rth@redhat.com
Subject: Re: c/6815: [3.2/3.3 regression] ICE with longjmp if -fprofile-arcs -O is specified
Date: Thu, 12 Dec 2002 13:37:26 +0100

 http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gcc&pr=6815
 
 These messages on gcc@gcc.gnu.org are about the same problem. This mail
 is mainly meant to make sure that this information is attached to the
 audit trail of PR 6815:
 
 http://gcc.gnu.org/ml/gcc/2002-12/msg00377.html
 http://gcc.gnu.org/ml/gcc/2002-12/msg00378.html
 http://gcc.gnu.org/ml/gcc/2002-12/msg00458.html
 http://gcc.gnu.org/ml/gcc/2002-12/msg00475.html
 
 Citing rth in one of theses mails:
 | Before the invocation of the profiling routines, no successors is correct.
 | During the invocation of the profiling routines, however, we add fake 
 | edges from calls to the exit block.  I would not expect this to change
 | for a noreturn function like longjmp.
 |
 | So I guess the quesion is "where did you get this null, exactly?"
 
 The crash is in cfgrtl.c:1314 in function insert_insn_on_edge in this
 piece of code:
 
 | void
 | insert_insn_on_edge (pattern, e)
 |      rtx pattern;
 |      edge e;
 | {
 |   /* We cannot insert instructions on an abnormal critical edge.
 |      It will be easier to find the culprit if we die now.  */
 |   if ((e->flags & EDGE_ABNORMAL) && EDGE_CRITICAL_P (e))
 |     abort ();
 | [ ... ]
 
 where e is NULL. insert_insn_on_edge in turn is called from
 flow_call_edges_add in cfganal.c:325 with this piece of code:
 
 | for (e = bb->succ; e; e = e->succ_next)
 |   if (e->dest == EXIT_BLOCK_PTR)
 |     break;
 |
 | insert_insn_on_edge (gen_rtx_USE (VOIDmode, const0_rtx), e);
 | commit_edge_insertions ();
 
 which looks a bit strange if we keep in mind that insert_insn_on_edge
 will crash if the second parameter is NULL.
 
     regards  Christian
 
 -- 
 THAT'S ALL FOLKS!

Re: c/6815: [3.2/3.3 regression] ICE with longjmp if -fprofile-arcs -O is specified

[reichelt]

Synopsis: [3.2/3.3 regression] ICE with longjmp if -fprofile-arcs -O is specified

State-Changed-From-To: analyzed->closed
State-Changed-By: reichelt
State-Changed-When: Mon Jan 13 13:24:59 2003
State-Changed-Why:
    Fixed on 3.2/3.3 branch and mainline by rth:
    
    http://gcc.gnu.org/ml/gcc-cvs/2003-01/msg00278.html
    http://gcc.gnu.org/ml/gcc-cvs/2003-01/msg00279.html
    http://gcc.gnu.org/ml/gcc-cvs/2003-01/msg00276.html

http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gcc&pr=6815

Re: c/6815: [3.2/3.3 regression] ICE with longjmp if -fprofile-arcs -O is specified

[Christian Ehrhardt]

The following reply was made to PR c/6815; it has been noted by GNATS.

>From ehrhardt@mathematik.uni-ulm.de  Mon Jan 13 00:48:39 2003
From: "Christian Ehrhardt" <ehrhardt@mathematik.uni-ulm.de>
To: gcc-gnats@gcc.gnu.org, gcc-prs@gcc.gnu.org, gcc-bugs@gcc.gnu.org,
  nobody@gcc.gnu.org, dtucker@zip.com.au, rth@redhat.com
Cc:  
Subject: Re: c/6815: [3.2/3.3 regression] ICE with longjmp if -fprofile-arcs -O is specified
Date: Fri, 10 Jan 2003 13:39:12 +0100

 Richard,
 
 you proposed a patch for this PR that didn't make it into CVS for
 about 4 weeks now (see the audit trail for more details). What happend
 to this patch? 
 
     regards   Christian
 

Re: c/6815: [3.2/3.3 regression] ICE with longjmp if -fprofile-arcs -O is specified

[Richard Henderson]

The following reply was made to PR c/6815; it has been noted by GNATS.

From: Richard Henderson <rth@redhat.com>
To: Christian Ehrhardt <ehrhardt@mathematik.uni-ulm.de>
Cc: gcc-gnats@gcc.gnu.org, gcc-prs@gcc.gnu.org, gcc-bugs@gcc.gnu.org,
   nobody@gcc.gnu.org, dtucker@zip.com.au
Subject: Re: c/6815: [3.2/3.3 regression] ICE with longjmp if -fprofile-arcs -O is specified
Date: Thu, 12 Dec 2002 10:08:35 -0800

 On Thu, Dec 12, 2002 at 01:37:26PM +0100, Christian Ehrhardt wrote:
 > where e is NULL. insert_insn_on_edge in turn is called from
 > flow_call_edges_add in cfganal.c:325 with this piece of code:
 > 
 > | for (e = bb->succ; e; e = e->succ_next)
 > |   if (e->dest == EXIT_BLOCK_PTR)
 > |     break;
 > |
 > | insert_insn_on_edge (gen_rtx_USE (VOIDmode, const0_rtx), e);
 > | commit_edge_insertions ();
 > 
 > which looks a bit strange if we keep in mind that insert_insn_on_edge
 > will crash if the second parameter is NULL.
 
 Indeed, this piece of code cannot handle a noreturn function
 in the last block.  The following should fix it.
 
 
 r~
 
 
 
 Index: cfganal.c
 ===================================================================
 RCS file: /cvs/gcc/gcc/gcc/cfganal.c,v
 retrieving revision 1.30
 diff -c -p -d -u -r1.30 cfganal.c
 --- cfganal.c	11 Oct 2002 21:09:59 -0000	1.30
 +++ cfganal.c	12 Dec 2002 18:07:41 -0000
 @@ -320,10 +320,11 @@ flow_call_edges_add (blocks)
  
  	  for (e = bb->succ; e; e = e->succ_next)
  	    if (e->dest == EXIT_BLOCK_PTR)
 -	      break;
 -
 -	  insert_insn_on_edge (gen_rtx_USE (VOIDmode, const0_rtx), e);
 -	  commit_edge_insertions ();
 +	      {
 +		insert_insn_on_edge (gen_rtx_USE (VOIDmode, const0_rtx), e);
 +		commit_edge_insertions ();
 +		break;
 +	      }
  	}
      }