public inbox for gcc-prs@sourceware.org
help / color / mirror / Atom feed
* Re: libgcj/8997: spin() calls Thread.sleep
@ 2002-12-31  9:44 tromey
  0 siblings, 0 replies; 3+ messages in thread
From: tromey @ 2002-12-31  9:44 UTC (permalink / raw)
  To: gcc-bugs, gcc-prs, java-prs, tromey, tromey

Synopsis: spin() calls Thread.sleep

State-Changed-From-To: analyzed->closed
State-Changed-By: tromey
State-Changed-When: Tue Dec 31 09:44:56 2002
State-Changed-Why:
    I've checked in the fix.

http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gcc&pr=8997


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: libgcj/8997: spin() calls Thread.sleep
@ 2002-12-19 11:13 tromey
  0 siblings, 0 replies; 3+ messages in thread
From: tromey @ 2002-12-19 11:13 UTC (permalink / raw)
  To: gcc-bugs, gcc-prs, java-prs, nobody, tromey, tromey

Synopsis: spin() calls Thread.sleep

Responsible-Changed-From-To: unassigned->tromey
Responsible-Changed-By: tromey
Responsible-Changed-When: Thu Dec 19 11:13:28 2002
Responsible-Changed-Why:
    I'm handling this.
State-Changed-From-To: open->analyzed
State-Changed-By: tromey
State-Changed-When: Thu Dec 19 11:13:28 2002
State-Changed-Why:
    I've submitted a partial patch.
    It is waiting for a follow-up patch from Ranjit or Adam.

http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gcc&pr=8997


^ permalink raw reply	[flat|nested] 3+ messages in thread

* libgcj/8997: spin() calls Thread.sleep
@ 2002-12-18 14:26 tromey
  0 siblings, 0 replies; 3+ messages in thread
From: tromey @ 2002-12-18 14:26 UTC (permalink / raw)
  To: gcc-gnats


>Number:         8997
>Category:       libgcj
>Synopsis:       spin() calls Thread.sleep
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    unassigned
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Dec 18 14:26:01 PST 2002
>Closed-Date:
>Last-Modified:
>Originator:     Tom Tromey
>Release:        unknown-1.0
>Organization:
>Environment:

>Description:
I let in a small change to natObject.cc that changed spin() to call
Thread::sleep instead of usleep().

I think this was a mistake (to be honest I don't recall seeing that
code in a patch, double oops on me).  spin() is used in the
implementation of _Jv_MonitorEnter; the point as I understand it is to
sleep a bit to avoid creating a heavyweight mutex.  However,
Thread::sleep() acquires just such a mutex -- defeating the purpose of
spin().

(See java list for more info.)
>How-To-Repeat:

>Fix:

>Release-Note:
>Audit-Trail:
>Unformatted:


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2002-12-31 17:44 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-12-31  9:44 libgcj/8997: spin() calls Thread.sleep tromey
  -- strict thread matches above, loose matches on Subject: below --
2002-12-19 11:13 tromey
2002-12-18 14:26 tromey

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).