public inbox for gcc-prs@sourceware.org
help / color / mirror / Atom feed
* libstdc++/9520: Garbled input from wcin
@ 2003-01-31 12:16 peturr02
0 siblings, 0 replies; 2+ messages in thread
From: peturr02 @ 2003-01-31 12:16 UTC (permalink / raw)
To: gcc-gnats
>Number: 9520
>Category: libstdc++
>Synopsis: Garbled input from wcin
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: unassigned
>State: open
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Fri Jan 31 12:16:01 UTC 2003
>Closed-Date:
>Last-Modified:
>Originator: peturr02@ru.is
>Release: gcc-3.2.1
>Organization:
>Environment:
Red Hat Linux 8.0
>Description:
If wcin.rdbuf()->sgetc() is called followed by wcin.rdbuf()->sbumpc(), the return value is not always the same, unless the charset in use happens to be ISO-8859-1.
Reason: basic_filebuf<wchar_t>::_M_underflow_common returns wide characters to the FILE* using ungetc. This happens to work if the charset is ISO-8859-1 (because the values are the same as in UCS-4), but breaks for all other single-byte charsets.
Note that there is an even more serious bug here when dealing with multibyte charsets: in general a single wide character can have been converted from more than one narrow character. This is however shadowed by other problems in _M_underflow_common.
>How-To-Repeat:
See attachment.
>Fix:
>Release-Note:
>Audit-Trail:
>Unformatted:
----gnatsweb-attachment----
Content-Type: text/plain; name="ungetcbug.cc"
Content-Disposition: inline; filename="ungetcbug.cc"
#include <iostream>
#include <fstream>
#include <locale>
#include <cwchar>
#include <unistd.h>
#include <sys/types.h>
#include <sys/stat.h>
#include <fcntl.h>
int main()
{
using namespace std;
const char* name = "tmp";
filebuf fbuf1;
fbuf1.open(name, ios_base::out | ios_base::trunc);
for (int i = 1; i < 256; ++i)
fbuf1.sputc(static_cast<unsigned char>(i));
fbuf1.close();
int fd = open(name, O_RDONLY);
assert(fd != -1);
dup2(fd, 0);
locale loc ("en_US.ISO-8859-15");
locale::global(loc);
wcin.imbue(loc);
for (int j = 1; j < 256; ++j)
{
wint_t c1 = wcin.rdbuf()->sgetc();
wint_t c2 = wcin.rdbuf()->sbumpc();
assert(c1 == c2);
assert(c1 != WEOF);
}
return 0;
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: libstdc++/9520: Garbled input from wcin
@ 2003-05-16 19:59 bkoz
0 siblings, 0 replies; 2+ messages in thread
From: bkoz @ 2003-05-16 19:59 UTC (permalink / raw)
To: gcc-bugs, gcc-prs, nobody, peturr02
Synopsis: Garbled input from wcin
State-Changed-From-To: open->feedback
State-Changed-By: bkoz
State-Changed-When: Fri May 16 19:59:32 2003
State-Changed-Why:
This is fixed on mainline, but not on the 3.3.x branch. Should this
just be closed?
-benjamin
http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gcc&pr=9520
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2003-05-16 19:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-01-31 12:16 libstdc++/9520: Garbled input from wcin peturr02
2003-05-16 19:59 bkoz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).